From: Florent Revest <revest@chromium.org>
To: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: akpm@linux-foundation.org, catalin.marinas@arm.com,
anshuman.khandual@arm.com, joey.gouly@arm.com, mhocko@suse.com,
keescook@chromium.org, david@redhat.com, peterx@redhat.com,
izbyshev@ispras.ru, nd@arm.com, broonie@kernel.org,
szabolcs.nagy@arm.com
Subject: Re: [PATCH 2/4] kselftest: vm: Fix mdwe's mmap_FIXED test case
Date: Thu, 4 May 2023 19:13:04 +0200 [thread overview]
Message-ID: <CABRcYm+xcGuyGOUhrMpH_9RMPA3oADCdOQbgHN4bSGcRFSsmQg@mail.gmail.com> (raw)
In-Reply-To: <20230504170942.822147-3-revest@chromium.org>
On Thu, May 4, 2023 at 7:10 PM Florent Revest <revest@chromium.org> wrote:
>
> I checked with the original author, the mmap_FIXED test case wasn't
> properly tested and fails. Currently, it maps two consecutive (non
> overlapping) pages and expects the second mapping to be denied by MDWE
> but these two pages have nothing to do with each other so MDWE is
> actually out of the picture here.
>
> What the test actually intended to do was to remap a virtual address
> using MAP_FIXED. However, this operation unmaps the existing mapping and
> creates a new one so the va is backed by a new page and MDWE is again
> out of the picture, all remappings should succeed.
>
> This patch keeps the test case to make it clear that this situation is
> expected to work.
>
> Signed-off-by: Florent Revest <revest@chromium.org>
Ah, snap, I hit send to fast and forgot to add:
Fixes: 4cf1fe34fd18 ("kselftest: vm: add tests for memory-deny-write-execute")
I will do it in the next iteration (surely there'll be other things to
fix... :))
next prev parent reply other threads:[~2023-05-04 17:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 17:09 [PATCH 0/4] MDWE without inheritance Florent Revest
2023-05-04 17:09 ` [PATCH 1/4] kselftest: vm: Fix tabs/spaces inconsistency in the mdwe test Florent Revest
2023-05-04 17:09 ` [PATCH 2/4] kselftest: vm: Fix mdwe's mmap_FIXED test case Florent Revest
2023-05-04 17:13 ` Florent Revest [this message]
2023-05-04 17:09 ` [PATCH 3/4] mm: Add a NO_INHERIT flag to the PR_SET_MDWE prctl Florent Revest
2023-05-05 18:34 ` Catalin Marinas
2023-05-08 12:11 ` Florent Revest
2023-05-04 17:09 ` [PATCH 4/4] kselftest: vm: Add tests for no-inherit memory-deny-write-execute Florent Revest
2023-05-04 20:29 ` Alexey Izbyshev
2023-05-05 16:42 ` Florent Revest
2023-05-05 21:26 ` Alexey Izbyshev
2023-05-08 12:12 ` Florent Revest
2023-05-04 20:06 ` [PATCH 0/4] MDWE without inheritance Peter Xu
2023-05-05 16:42 ` Florent Revest
2023-05-08 1:29 ` Peter Xu
2023-05-08 12:12 ` Florent Revest
2023-05-08 14:10 ` Catalin Marinas
2023-05-08 17:21 ` Topi Miettinen
2023-05-09 10:04 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABRcYm+xcGuyGOUhrMpH_9RMPA3oADCdOQbgHN4bSGcRFSsmQg@mail.gmail.com \
--to=revest@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=izbyshev@ispras.ru \
--cc=joey.gouly@arm.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=nd@arm.com \
--cc=peterx@redhat.com \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox