From: Vlad Dumitrescu <vladum@google.com>
To: dennis@kernel.org
Cc: Eddie Hao <eddieh@google.com>,
Willem de Bruijn <willemb@google.com>,
ast@kernel.org, tj@kernel.org, cl@linux.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>
Subject: Re: LPC Traffic Shaping w/ BPF Talk - percpu followup
Date: Wed, 21 Nov 2018 20:01:04 -0800 [thread overview]
Message-ID: <CABDEL=+Q7eOycRC9zvjdffq3Kyn6Fcau4HVponM-Y6-dHYewNg@mail.gmail.com> (raw)
In-Reply-To: <20181120221659.GA61322@dennisz-mbp.dhcp.thefacebook.com>
On Tue, Nov 20, 2018 at 2:17 PM Dennis Zhou <dennis@kernel.org> wrote:
>
> Hi Eddie, Vlad, and Willem,
>
> A few people mentioned to me that you guys were experiencing issues with
> the percpu memory allocator. I saw the talk slides mention the
> following two bullets:
>
> 1) allocation pattern makes the per cpu allocator reach a highly
> fragmented state
> 2) sometimes takes a long time (up to 12s) to create the PERCPU_HASH
> maps at startup
>
> Could you guys elaborate a little more about the above? Some things
> that would help: kernel version, cpu info, and a reproducer if possible?
>
> Also, I did some work last summer to make percpu allocation more
> efficient, which went into the 4.14 kernel. Just to be sure, is that a
> part of the kernel you guys are running?
>
> Thanks,
> Dennis
Hi, Dennis,
Thanks a lot for reaching out and sorry for the delay in answering. I
was trying to build something which shows the problem on a recent
upstream kernel, but I was unable to do so until now.
It seems like I can still reliably reproduce on one of our kernels,
which has a lot of 'percpu: *' patches by you from 4.14, and with an
internal application. Unfortunately, we haven't spent too much time on
this issue, and I will have 'page in' state from a few months back.
Hopefully, I'll be able to reproduce on a vanilla kernel and a simpler
application, that we can publish, in the following days (after TG
weekend).
Thanks,
Vlad
prev parent reply other threads:[~2018-11-22 4:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 22:16 Dennis Zhou
2018-11-22 4:01 ` Vlad Dumitrescu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABDEL=+Q7eOycRC9zvjdffq3Kyn6Fcau4HVponM-Y6-dHYewNg@mail.gmail.com' \
--to=vladum@google.com \
--cc=ast@kernel.org \
--cc=cl@linux.com \
--cc=dennis@kernel.org \
--cc=eddieh@google.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tj@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox