From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61460C433F5 for ; Wed, 12 Jan 2022 01:46:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8B4256B0105; Tue, 11 Jan 2022 20:46:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 83B8E6B0106; Tue, 11 Jan 2022 20:46:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B6936B0107; Tue, 11 Jan 2022 20:46:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0174.hostedemail.com [216.40.44.174]) by kanga.kvack.org (Postfix) with ESMTP id 5A6F26B0105 for ; Tue, 11 Jan 2022 20:46:33 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 24BEF901A7 for ; Wed, 12 Jan 2022 01:46:33 +0000 (UTC) X-FDA: 79019945466.05.19348C6 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by imf19.hostedemail.com (Postfix) with ESMTP id A0EEB1A0002 for ; Wed, 12 Jan 2022 01:46:32 +0000 (UTC) Received: by mail-wr1-f54.google.com with SMTP id s1so1459559wra.6 for ; Tue, 11 Jan 2022 17:46:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Jfvsr8PR3GjeTvciCbxfFgfs5vC3rlXelyaQOInqWns=; b=jpZOnqubfJ0hnEhpOd1UgVHFjcFGZvUD1EvP6SUEZcQOhrbAaa/xGlMNgtViJBEN9b TS3Onjx6QOHUseMhJ6AfbRR2PDachzWW+PUvAdKLONL7MyYYGMUJ78xcqa/j7jyBNv/E dRhbsnB3ka3OxcsW7aSwD2gLXVIQvG1sFSpl/7JE/9V/+eFAathAKk49OJlM9DLNszjz XySZdrGz3n2rjofi9CcsyOShAntfICBUPa8Rf3BKmlOHDdC+yCeviyV+OHx4JU5P7HFu QQ79C5sDc5LafR3I85TgyVETbURK8Sw7vAKO8XyaL7XO/OMZ2OIqy5cCNL4pwoCKyFeS Xj0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Jfvsr8PR3GjeTvciCbxfFgfs5vC3rlXelyaQOInqWns=; b=lu+908mXXbiWXMG3Tjn+DBDwNPfl+VzyZnebbfkxfXAW1Re/iLJfCGkhumP3LJj+P8 kQfIbc6WNFvwK3TB0h/JkUgPfDN/9EIvGAadopIJpw1nHl90u5LksNpBRq76NK7kRmOY rqvU2fcozoHVpZwmOHkp8VhMEM3ViBNeCHtrOIFOKJTB+WhIJ4kVinQS2KWkYuRakude zXtzTzKzuyPuOvFwTVlditkoqYMwGGtDV8bKphSBAE+fn1CS0jUQD4xRVp+VgPbftLQx KYE1uahi8daIwCz6mvhKqoJ3JVs1uALv1CQkEYMqDUK7AZJ6mswKL3SfuzqJXy/wz0qd ijUg== X-Gm-Message-State: AOAM530C9p7FVlCTgk2u3ugyKkM1psD4OgbaLlJaU+PB8kOuX6bLwWgK rNNTeQFgor3YAfx+ODN8j99IPrlmOj2YOazq/Macjg== X-Google-Smtp-Source: ABdhPJwtHkljLUOCxyakqEbUb2j/J0vIrKEKy0mZ5iJW02TGkn+sQPf3J4n7Od0UkQ8UTmgDmDmQZVMrdAYemlDlCY0= X-Received: by 2002:adf:f151:: with SMTP id y17mr5748842wro.547.1641951991215; Tue, 11 Jan 2022 17:46:31 -0800 (PST) MIME-Version: 1.0 References: <20220104202227.2903605-1-yuzhao@google.com> In-Reply-To: From: Suleiman Souhlal Date: Wed, 12 Jan 2022 10:46:19 +0900 Message-ID: Subject: Re: [PATCH v6 0/9] Multigenerational LRU Framework To: Yu Zhao Cc: Alexandre Frade , Brian Geffon , Daniel Byrne , =?UTF-8?Q?Holger_Hoffst=C3=A4tte?= , Jan Alexander Steffens , Shuang Zhai , Sofia Trinh , Steven Barrett , Andi Kleen , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, Linux Kernel , linux-mm@kvack.org, page-reclaim@google.com, x86@kernel.org, Andrew Morton , Linus Torvalds Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: A0EEB1A0002 X-Stat-Signature: 6kehczm1dc1gf5c8kfupyy14xtqb8dp6 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=jpZOnqub; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of suleiman@google.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=suleiman@google.com X-Rspamd-Server: rspam06 X-HE-Tag: 1641951992-869744 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 11, 2022 at 5:41 PM Yu Zhao wrote: > > On Tue, Jan 04, 2022 at 01:30:00PM -0700, Yu Zhao wrote: > > On Tue, Jan 04, 2022 at 01:22:19PM -0700, Yu Zhao wrote: > > > TLDR > > > ==== > > > The current page reclaim is too expensive in terms of CPU usage and it > > > often makes poor choices about what to evict. This patchset offers an > > > alternative solution that is performant, versatile and > > > straightforward. > > > > > > > > > Summery > > > ======= > > > The facts are: > > > 1. The independent lab results and the real-world applications > > > indicate substantial improvements; there are no known regressions. > > > 2. Thrashing prevention, working set estimation and proactive reclaim > > > work out of the box; there are no equivalent solutions. > > > 3. There is a lot of new code; nobody has demonstrated smaller changes > > > with similar effects. > > > > > > Our options, accordingly, are: > > > 1. Given the amount of evidence, the reported improvements will likely > > > materialize for a wide range of workloads. > > > 2. Gauging the interest from the past discussions [14][15][16], the > > > new features will likely be put to use for both personal computers > > > and data centers. > > > 3. Based on Google's track record, the new code will likely be well > > > maintained in the long term. It'd be more difficult if not > > > impossible to achieve similar effects on top of the existing > > > design. > > > > Hi Andrew, Linus, > > > > Can you please take a look at this patchset and let me know if it's > > 5.17 material? > > > > My goal is to get it merged asap so that users can reap the benefits > > and I can push the sequels. Please examine the data provided -- I > > think the unprecedented coverage and the magnitude of the improvements > > warrant a green light. > > Downstream kernel maintainers who have been carrying MGLRU for more than > 3 versions, can you please provide your Acked-by tags? > > Having this patchset in the mainline will make your job easier :) > > Alexandre - the XanMod Kernel maintainer > https://xanmod.org > > Brian - the Chrome OS kernel memory maintainer > https://www.chromium.org > > Jan - the Arch Linux Zen kernel maintainer > https://archlinux.org > > Steven - the Liquorix kernel maintainer > https://liquorix.net > > Suleiman - the ARCVM (Android downstream) kernel memory maintainer > https://chromium.googlesource.com/chromiumos/third_party/kernel Android on ChromeOS has been using MGLRU for a while now, with great results. It would be great for more people to more easily be able to benefit from it. Acked-by: Suleiman Souhlal -- Suleiman