From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx143.postini.com [74.125.245.143]) by kanga.kvack.org (Postfix) with SMTP id 319CB6B004A for ; Tue, 28 Feb 2012 18:36:28 -0500 (EST) Received: by qcsd16 with SMTP id d16so2860674qcs.14 for ; Tue, 28 Feb 2012 15:36:27 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <4F4CD7E7.1070901@parallels.com> References: <1330383533-20711-1-git-send-email-ssouhlal@FreeBSD.org> <1330383533-20711-9-git-send-email-ssouhlal@FreeBSD.org> <4F4CD7E7.1070901@parallels.com> Date: Tue, 28 Feb 2012 15:36:27 -0800 Message-ID: Subject: Re: [PATCH 08/10] memcg: Add CONFIG_CGROUP_MEM_RES_CTLR_KMEM_ACCT_ROOT. From: Suleiman Souhlal Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa Cc: Suleiman Souhlal , cgroups@vger.kernel.org, kamezawa.hiroyu@jp.fujitsu.com, penberg@kernel.org, yinghan@google.com, hughd@google.com, gthelen@google.com, linux-mm@kvack.org, devel@openvz.org On Tue, Feb 28, 2012 at 5:34 AM, Glauber Costa wrote: > On 02/27/2012 07:58 PM, Suleiman Souhlal wrote: >> >> This config option dictates whether or not kernel memory in the >> root cgroup should be accounted. >> >> This may be useful in an environment where everything is supposed to be >> in a cgroup and accounted for. Large amounts of kernel memory in the >> root cgroup would indicate problems with memory isolation or accounting. > > > I don't like accounting this stuff to the root memory cgroup. This causes > overhead for everybody, including people who couldn't care less about memcg. > > If it were up to me, we would simply not account it, and end of story. > > However, if this is terribly important for you, I think you need to at > least make it possible to enable it at runtime, and default it to disabled. Yes, that is why I made it a config option. If the config option is disabled, that memory does not get accounted at all. Making it configurable at runtime is not ideal, because we would prefer slab memory that was allocated before cgroups are created to still be counted toward root. -- Suleiman -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org