From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7A56E7734B for ; Fri, 29 Sep 2023 22:53:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33DFB8D0107; Fri, 29 Sep 2023 18:53:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EE3C8D006D; Fri, 29 Sep 2023 18:53:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B6D28D0107; Fri, 29 Sep 2023 18:53:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 087608D006D for ; Fri, 29 Sep 2023 18:53:02 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BE77D80612 for ; Fri, 29 Sep 2023 22:53:01 +0000 (UTC) X-FDA: 81291136962.30.6A82515 Received: from mail-vs1-f49.google.com (mail-vs1-f49.google.com [209.85.217.49]) by imf13.hostedemail.com (Postfix) with ESMTP id CEAEE2002A for ; Fri, 29 Sep 2023 22:52:59 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=alfXrJV4; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of samitolvanen@google.com designates 209.85.217.49 as permitted sender) smtp.mailfrom=samitolvanen@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696027979; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vVD0NwiVgmmQvibC1xInA0otG2T0uniQ4SKhb3BsNQI=; b=3o3K0fNdPKAM7KoT6oU56ZDFt3qu9NiBjVhlNlEwqK+rw7MZfhdoUhszPk5xAjLFBZcxE5 nWrd94gv0ga6gKG/1nS88FwYU5zC7MkubjgZSfvCNB+ws9T9fQA9C3Ba6qhOpgQp8F6zlM +wgnPuIE1CLwR84NUea8pvKqv39tPDg= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=alfXrJV4; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of samitolvanen@google.com designates 209.85.217.49 as permitted sender) smtp.mailfrom=samitolvanen@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696027979; a=rsa-sha256; cv=none; b=xH3xqhJn6iXAvzgOOl/95hmGkkCZhmKJNOLATCSinsrusyjkS36LymUxoIw0mNrwW7E8CU n/0shkR5ZHzSmkAyBa0z0ccXxpA2uoFXMiKyGwdY5NP9myymFGWnV18E/mJsC5aArOwEch ZCH6/lafbstkKwDFW/EMoL6a3PNocaU= Received: by mail-vs1-f49.google.com with SMTP id ada2fe7eead31-4527ba546d2so5891347137.2 for ; Fri, 29 Sep 2023 15:52:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696027979; x=1696632779; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vVD0NwiVgmmQvibC1xInA0otG2T0uniQ4SKhb3BsNQI=; b=alfXrJV4M9z7g4RdpeaiipFMgz93oycPWakRRbkxZzcGk/FTTPgLfo9qOyk1PwPfC0 DpecqABESKcDYTBGTqtaBlptrYdFWAczWRcm2V6lW3EZNyM99ajA3KbPgtQMb0EnhNOa NLxd+jUiRoRS0CedKdE2p4TiqrNT9fYJsXx/ZwDlvAh3POi1rns2hOjOxXJMvCj67oLd 9KuBk/EjNwePIIJJoTQEkj+VxMIwnsRqWQP4G1UYbzPuZMPqmN19u/ZeAUW+f7zcsPs/ Z5dqZzVHEvrw+nR324bBEq2NT/O5FfJd+F0BPznpOvjS8SHoVIMZaKedmefOV0W9C81F 76Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696027979; x=1696632779; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vVD0NwiVgmmQvibC1xInA0otG2T0uniQ4SKhb3BsNQI=; b=J5SfZs5Q+WvtT2mHLtDZoK+q2ixmpz2W2cDO/etzZMBVE7o1uS5+Rj3Q5zPEkkgiES 2hVNtd9PjecAF6ligOeo9p9nXrOBb7vdM6bvF6bH6OH9vygAAv1RcMQe5sA6AQD+Y9Vg 7JC9aN3vC4MYcmf+iNM5FwmJm79dhecXrqcOG6v0TzrKIkFG4PPB/YC8PvyuqwH2WVOR vqMj8wUWqN3lEuu+IcUURWrvdxAql+1yqzae35LrzuTv032XjmCNCdw0KMkmok9p53W8 UGqwcXtWznhWi1pGJfpig+ocDSSCAcuFzgMHRgkPtAODHJaoJhtgk+hAsbqxVTO3P0XT qdbg== X-Gm-Message-State: AOJu0YzwikdCAjqwkdCcNQptqJKmAmH1+aceNluaihnUCCPgub1+eC02 vIB1ph4dIte7KGGlZondeGcPgohEa5g+4EJBUcK+mA== X-Google-Smtp-Source: AGHT+IFIzioa8M+FkbhUdK48/e055YeWZrhKv/naxGAzU7YglwP+Nfq9WJ8bCC7WBhwhOz65LtF9FwPuJudNt5dBpwY= X-Received: by 2002:a05:6102:134b:b0:452:77f1:f1e8 with SMTP id j11-20020a056102134b00b0045277f1f1e8mr4849186vsl.33.1696027978754; Fri, 29 Sep 2023 15:52:58 -0700 (PDT) MIME-Version: 1.0 References: <20230929211155.3910949-4-samitolvanen@google.com> <20230929211155.3910949-6-samitolvanen@google.com> <202309291452.66ED9B4D83@keescook> In-Reply-To: <202309291452.66ED9B4D83@keescook> From: Sami Tolvanen Date: Fri, 29 Sep 2023 15:52:22 -0700 Message-ID: Subject: Re: [PATCH 2/2] riscv: mm: Update mmap_rnd_bits_max To: Kees Cook Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrew Morton , linux-mm@kvack.org, linux-riscv@lists.infradead.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: CEAEE2002A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: otw5wn959f4u8sc1ayf1yo1xiq3c4xgg X-HE-Tag: 1696027979-342103 X-HE-Meta: U2FsdGVkX1/+42RjK3yPtjP/Yrj0zgSMOsARYONmDDPBtKKgBDrC+tSQhM90cExx3qcrpbmRCIBi3YeswxELYv3DWu+eYJg1JQkThazuFXyyDFbNy7kkEthra1Nskbtuf7RIqC1op9vGA2VugX11kc2OycGht8Prz3ajq+D/4Z/HzQYHxZWt33iGxrGDibYE7KuanmnwwfjYtkTCze8dwapJzbagcGz4GNIRTKN9ybe7CHTtGK4YrdOXKig7gSxeWk1CFXbHIDrxDSzb5ObC5JhIb0rFiMy2WlDvPLMPfGizCS2XL91sNtQ2/TnSBpftcDIiaQ0vuVpCQDllp0qa5xly5RqbG+FkKs1W/DkEKx3wKlA149zn+v5CgFLeshaZVRzWVPSslGSfD3tson+Pj8lCWnkca0KTXb6zlK0Kyou+qvZxxA201KGM5zKQpLQwSsmdmwjPJW49VvkhBoU2Z+iQ/jv8A/svi9jB2MsmvUQ7AUklpTem9psXCdNDKXg4gPAwVO/XN7p4Q/qPXDNjPNozZoCliNaeflOe2py8IZtdmmO0JCTysrzv01o7r6nlcXcmd9wNWwF00WfTCinCeEkIOFYJhvXYONTgxshOitRCSbHZujXgsAw+LuaBZrEF39riS7NAyc0SJ07akomcC6foaUu0LS6Z/f8bzpZKFQz0ETL33WwBJjkGfqxnJdqbA8WbyqvfFe31XcQCFcoVQCJjVp0TlYsqjQ57mfZ+NH8o/fs+A7Tzq1isrXAQ9hc7ftgZMmPfzhzIg9r8tt7pTmI2U4kNcjTvfvgGtXIgObvX7QLjZinu+rut9Xf8g0Ixi45Ree8gwvhb1lUrDvULlpiuZk+0p2OnY8qLqTuh+ZURMlYcnGFVWI2Kkmb/p9JN54kYWBtx06I7Liv32naSDR7bvNaEiLEMFvyYwhzswWR3HuQ4roWKMwtuvI+x9d8iwHfwwO0RQaP4MWf0h4Y /VtRCvmO s2+jkBaY55MoRFUAaW1i+11oCxTZXrYdJmhKQT/qrMvygre4qELDQGcwJxz5ELpSyyxn/oO+ru9jnNgBxDhkMSJQ5Xtddkgji7XI7s9+cYEo1yNDdArOfA0LmoNu1X6yJDv3W9r49aAobwQCx0KECdoewwp1FvqGJzMVTAaAAr7tcWQlGNWfrJCIPiOrtFwFCzvYZ5u1P2UUQV3EyKDEy04rWX2pjR9ihQ/ISSrgqkx4mZA+g1FEAN9zZ2NCoqZ19LQd2yW5w5qk8cc+6BboQ/ERUDyLdEyAqrqIZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000019, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 29, 2023 at 2:54=E2=80=AFPM Kees Cook w= rote: > > On Fri, Sep 29, 2023 at 09:11:58PM +0000, Sami Tolvanen wrote: > > ARCH_MMAP_RND_BITS_MAX is based on Sv39, which leaves a few > > potential bits of mmap randomness on the table if we end up enabling > > 4/5-level paging. Update mmap_rnd_bits_max to take the final address > > space size into account. This increases mmap_rnd_bits_max from 24 to > > 33 with Sv48/57. > > > > Signed-off-by: Sami Tolvanen > > I like this. Is RISCV the only arch where the paging level can be chosen > at boot time? I haven't seen this elsewhere, but I also haven't looked at all the other architectures that closely. arm64 does something interesting with ARM64_VA_BITS_52, but I think we can still handle that in Kconfig. Sami