From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2CBFC61DA4 for ; Thu, 2 Feb 2023 20:12:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A29F6B0072; Thu, 2 Feb 2023 15:12:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 229F56B0073; Thu, 2 Feb 2023 15:12:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CB046B0074; Thu, 2 Feb 2023 15:12:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EE2F36B0072 for ; Thu, 2 Feb 2023 15:12:28 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A7F5880F0F for ; Thu, 2 Feb 2023 20:12:28 +0000 (UTC) X-FDA: 80423449176.11.BE8EB9B Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by imf15.hostedemail.com (Postfix) with ESMTP id E1E3CA001A for ; Thu, 2 Feb 2023 20:12:25 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=b8S977PC; spf=pass (imf15.hostedemail.com: domain of samitolvanen@google.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=samitolvanen@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675368746; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IHla39CiSn/iJKWSdMLdZQxGn8KNa71czZ//HIF7jnM=; b=Zrt8LrsbNfx0LwNVM2UFu2qGux1Dj1Y5TwVqy61/LdMflMANbBARC5FeqwXrjZQa72DA6B QnY4vUuG3JGxe9xm4j0+i39bIkCQrHyThFG8mpdLTlXEBORX4imYOE+iLy9tpGIxOCMFMF IKdCZW+bpq74mq0II5LXRGRCNALN1EU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=b8S977PC; spf=pass (imf15.hostedemail.com: domain of samitolvanen@google.com designates 209.85.218.50 as permitted sender) smtp.mailfrom=samitolvanen@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675368746; a=rsa-sha256; cv=none; b=C6zuKET83BAVodVWPSs7acT4wEWhcMnGpZ/6vvJ+/JWcGWPP6jDMOBFiKxtWqDzmtq6mof ykHnMSGGwCgXMQ1U4YhBIo2vChud3Qwyq3qLkFCrdIPSKfCZYstBfsZK0PbC5ahVf5o5Qf DK1JMAAL899BWyHZSJKvRHrrawD47So= Received: by mail-ej1-f50.google.com with SMTP id mc11so9270317ejb.10 for ; Thu, 02 Feb 2023 12:12:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=IHla39CiSn/iJKWSdMLdZQxGn8KNa71czZ//HIF7jnM=; b=b8S977PCJvYsm5/wWBBCuQu2MDqR3X3fUtF8X1r8mnXi8t+O+XjMQWNZFQCdwK3bQu bb2h40Lx6JiJTPlREK6y28ArbDlrecfcNjSuHQnO41A9KR2NvWMo8fBku8bWXW2ZsmOT 3i1S7Ci7/Mz77ZbG9n+tgyGlxlIcHYfqwqElIshS4Q7ZnQdxZJwxp6hOfOB3IdRqQktA ly/hhMbpiYCBguunqDfA9g9Bu3cgo3d8McgbLXFFfupAu9Hqi1jppqaC0Qwjb+NRZC+h nOm8+qHMKnw3bcVXpH6k/6Y+ne2nkjuHiDVxYx23qm/zBpVknekHllYAtdJURLIsp0U2 2E7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IHla39CiSn/iJKWSdMLdZQxGn8KNa71czZ//HIF7jnM=; b=KvZZ3WFx7fLHqMLHOZ/x91ZySSEFFUR5qK6Vd+wF4OmBV0hO/JeX6it8oVExIsZeEg Mqo/el9/SdB8SXJ9yeW/iEY1NwyV0zvOT3deii1TAyDd2O3R+DByWgvC+H/pZ0hLTiJ3 /RDPG+9pcE9ge8pBP+8OjGtzKz/e+POH9jnwGQ+0jgP07rjqPtPxIaKTZpSUevoesNKp m2wIoDdyYh6ZWyTPmhYo/yQ0J3i98AWBBw4MwOkIhiC4Bu53QF+OBnqEo5TlhSZtBT7K HuzsZNMDnIGrMwnXYVBm3tirXt7tDXmNpwfpPyi8AhdNZnDa/Rp3yXqEHuI816EAIb7E pclw== X-Gm-Message-State: AO0yUKXSUe0D08pVkc8QoG3CNIx17vF/fv4BNe4mRsrdYHwEN4rfGotp 1wrjEkj+VPiFNmxyfdqQ/Jjd/4rbmdC+C6rsku37EQ== X-Google-Smtp-Source: AK7set9rIsutx+Ca2x+6Py7LpZCPwL53KUZH34ZDzhf5YBTLMNdyYbcMOhiSyZoKwKZW2sL2evQ4iBv7Bl6I/3PriEM= X-Received: by 2002:a17:906:2c42:b0:88a:b6ca:7d3a with SMTP id f2-20020a1709062c4200b0088ab6ca7d3amr1942408ejh.1.1675368744381; Thu, 02 Feb 2023 12:12:24 -0800 (PST) MIME-Version: 1.0 References: <20221101222520.never.109-kees@kernel.org> <20221101223321.1326815-5-keescook@chromium.org> <63dbf04a.630a0220.2608a.0149@mx.google.com> <63dc0a89.170a0220.49507.0091@mx.google.com> <63dc14a2.170a0220.beb2a.0275@mx.google.com> In-Reply-To: <63dc14a2.170a0220.beb2a.0275@mx.google.com> From: Sami Tolvanen Date: Thu, 2 Feb 2023 12:11:47 -0800 Message-ID: Subject: Re: [PATCH 5/6] driver core: Add __alloc_size hint to devm allocators To: Kees Cook Cc: Nick Desaulniers , Ard Biesheuvel , John Stultz , Yongqin Liu , Vlastimil Babka , Greg Kroah-Hartman , Rasmus Villemoes , Thomas Gleixner , Jason Gunthorpe , Nishanth Menon , Michael Kelley , Dan Williams , Won Chung , David Gow , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Guenter Roeck , Andy Shevchenko , Paolo Abeni , Geert Uytterhoeven , Nathan Chancellor , Tom Rix , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, llvm@lists.linux.dev, Sumit Semwal Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: xmpx3edrrhtko5ruq8xsd73r5japjcuj X-Rspam-User: X-Rspamd-Queue-Id: E1E3CA001A X-Rspamd-Server: rspam06 X-HE-Tag: 1675368745-257338 X-HE-Meta: U2FsdGVkX19EnzdgcqVqVgoPABGrDd8UoY2tk6/qJD9xwTYTIdzroxSZBRmLkQ1E/BErgzb1IFZGIZYjhgBdEeJ/9qp0ypH9hbpud0NKV68pmudHqJ3MKDt2eYcsLwV4p1PCXlogBlnGwWmOeg/FYi5L7F1Kk+Z0uNlc5XNr/S8t9pMZlmO5Lyk9ifIxxxB3nKwQHiehVm5iRYWnhZpF+JknPQEoGIbMHdj9cgEBwAA9qDgA7yEbtsSVf/c6HIFfA+3z5AYLpAOJsF153WBeW3FGfAc7YBuK/1+v/Qd/H8MC25Z2aAwYvFyu6ZRE+8qkXzdO/zpFcmbLsBgqPwHPWsxXIgPrZ29Xz3dgxZEJDgPb7mn59gvKmc8+Sqjjqag7L2ctl/1ygtG7gBiTNe9DpPftxBXfyCVC2Eygp595Wsr1Yl7dzYoQzjrz8XbxKcrcd9VrYWoXm4Qpq7M2jhVhMg4Hj56U6Qac/8r3vz/pFK9Vf1Oh1HvdukwUk9pvjdf67tAF7OQXCEICmz3NEMxv2hXGqssZuF5gu0aIEEIKqXffO3jinaeCvoABFEByho2/P/WD4HhB+8tligYxV9Q4/XiJ7ficgw3jKO6pU257wGXPjW4/lcxCwEr4SAoR3eobX9IE80JXB6yaemL9iw84I2hCz2H1aVOMs2/jfDgTM5lwkgNE2cwu8AdJJhJGOSNBAygjlIICSP0o5ENnpr1tg0M5nXqSRL9wIdAtSWMk+8U+HXJcqd5XJr9d8qeGlccRmH+OUhcMxBZCrhmLxr0IcfNpfZWuV3kNtnlgHyS4EdsmmSlJ6AxunMcVBoEZc8Pi3Jaa86GxW6zDKxzSj5ciXci3IivrfU3KHC3+HDUWgFH4udJk9f9e9aoVg/StPSYT0viuctmLjnzSbxSLKg/ZWQc6Coc3fhs9H0AJaf3W6F3xGaZEsCoKn5shaccd5K+Il6vfC3VxVfDTDT+UPpf Rkb5GVlD 5nNhFADeL1IvW3n9TOObhtXeenM+G1m9S8moCRLmAn4hiNJGbP3JjzR9HtgfgjOXjVR+9wHQXy3xhTVxAabFm2CoctyCCiemnS3PaVWWy+m0Ric3We3Mpc51Se57/kWPNUT07Ju5S8NhMrlX6c59nqhcZOuN5+dlCxvvloBxSDexo3ON1zilfvIa3pOh3IUOiDv+PRQ6VWUyOcS4dyiW/Xw41oCcS2u/nghXJNXFmZn79f3lwaQsZXf0SvQtTMOk2eNu9hgakDrWYF8NgxXxbJJV/lH8BFNKbnx3jD2Zk/Jc/TL5ipp3BmNNLY5MQFVx/G7BJl3HTH0o2IByi59yczHAUAGLD2fpFSTkragCYSeappQo0thEs3otppe9TbEvMJaZBWeCnXGUfHdJ6CKLDPCpN0UKA96bt/Ct6xYzQUKjY5VV0gNW1VBqiuQLMZaL9ce6W X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 2, 2023 at 11:53 AM Kees Cook wrote: > > On Thu, Feb 02, 2023 at 11:49:42AM -0800, Sami Tolvanen wrote: > > A quick look at Clang's source code suggests that Intrinsic::ubsantrap > > already accepts the handler ID (from the SanitizerHandler enum) as an > > argument and the arm64 LLVM back-end appears to encode the value as an > > immediate for the brk instruction. I didn't confirm that this actually > > works, but perhaps we just need to teach the kernel about the possible > > values? > > Oh excellent. Yeah, if that's all that's needed here that would be > great. What are the values? The arm64 brk immediate encoding seems to be "ubsantrap arg | 'U' << 8": https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/AArch64/AArch64InstrInfo.td#L7571 The argument values come from the SanitizerHandler enum, which is populated from this list: https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CodeGenFunction.h#L113 Therefore, according to the tests, for ubsantrap(12) we'll get brk #0x550c, for example: https://github.com/llvm/llvm-project/blob/main/llvm/test/CodeGen/AArch64/ubsantrap.ll Sami