From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E95EEC2BB85 for ; Fri, 10 Apr 2020 21:27:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AB5F72078E for ; Fri, 10 Apr 2020 21:27:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="s/nBaA6L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB5F72078E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 523B58E0062; Fri, 10 Apr 2020 17:27:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D36E8E004D; Fri, 10 Apr 2020 17:27:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39ACF8E0062; Fri, 10 Apr 2020 17:27:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id 1F6498E004D for ; Fri, 10 Apr 2020 17:27:40 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id CFF8D482A for ; Fri, 10 Apr 2020 21:27:39 +0000 (UTC) X-FDA: 76693232238.08.spoon17_8aa0292b6d32 X-HE-Tag: spoon17_8aa0292b6d32 X-Filterd-Recvd-Size: 3752 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Apr 2020 21:27:39 +0000 (UTC) Received: from mail-ua1-f52.google.com (mail-ua1-f52.google.com [209.85.222.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8ACF521744 for ; Fri, 10 Apr 2020 21:27:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586554058; bh=V8QhhiRTymtAGzS4jMm11mYDdFfOWqwXJ0Awmxqa7oM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=s/nBaA6LOPpckWlwyeu6G42+wIf81zq6VVgY/lVhpQpkRhgz03nPSamZe1NK+HPq/ D7M7tbdynL5FR499sS8D6zY/s8Xpq3iLG7vm6xDpfqwefsnO9khABcOVrqTHv8Yf0r qeXKgH66aRJSC+2OLj65YDrzKFiF+ftWEMJFf8xw= Received: by mail-ua1-f52.google.com with SMTP id c7so1098581uap.12 for ; Fri, 10 Apr 2020 14:27:38 -0700 (PDT) X-Gm-Message-State: AGi0PuaJ4DxbW5081j1Q4ZBNkZylHhJrVu9CU+vMIcNWqL9Ju5bKlDD3 m2wf5wvqpUuoNY/WX2/CL1JTcnXylVkusEQ82Qk= X-Google-Smtp-Source: APiQypKL5aZ2RNqUUOB0SjAH5YbjeLzshTc1ta+JOreiajZrgqBymzHOh8oGSfSKa2KXtA1f94T8sQs2WZLp2sC77bg= X-Received: by 2002:ab0:1e89:: with SMTP id o9mr4281024uak.93.1586554057531; Fri, 10 Apr 2020 14:27:37 -0700 (PDT) MIME-Version: 1.0 References: <20200409214530.2413-1-mcgrof@kernel.org> <20200409214530.2413-6-mcgrof@kernel.org> <161e938d-929b-1fdb-ba77-56b839c14b5b@acm.org> <20200410143412.GK11244@42.do-not-panic.com> In-Reply-To: From: Luis Chamberlain Date: Fri, 10 Apr 2020 15:27:30 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC v2 5/5] block: revert back to synchronous request_queue removal To: Bart Van Assche Cc: Jens Axboe , Al Viro , Greg Kroah-Hartman , Steven Rostedt , Ingo Molnar , Jan Kara , Ming Lei , Nicolai Stange , Andrew Morton , Michal Hocko , yu kuai , linux-block@vger.kernel.org, Linux FS Devel , linux-mm , "linux-kernel@vger.kernel.org" , Omar Sandoval , Hannes Reinecke , Michal Hocko Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 10, 2020 at 2:50 PM Luis Chamberlain wrote: > > On Fri, Apr 10, 2020 at 8:34 AM Luis Chamberlain wrote: > > On Thu, Apr 09, 2020 at 08:12:21PM -0700, Bart Van Assche wrote: > > > Please add a might_sleep() call in blk_put_queue() since with this patch > > > applied it is no longer allowed to call blk_put_queue() from atomic context. > > > > Sure thing. > > On second though, I don't think blk_put_queue() would be the right > place for might_sleep(), given we really only care about the *last* > refcount decrement to 0. So I'll move it to blk_release_queue(). > Granted, at that point we are too late, and we'd get a splat about > this issue *iff* we really sleep. So yeah, I do suppose that forcing > this check there still makes sense. I'll add might_sleep() to both blk_release_queue() *and* blk_cleanup_queue(). Luis