From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF71AC64EC4 for ; Thu, 9 Mar 2023 06:58:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 155D26B0071; Thu, 9 Mar 2023 01:58:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 106556B0072; Thu, 9 Mar 2023 01:58:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0F73280001; Thu, 9 Mar 2023 01:58:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E289A6B0071 for ; Thu, 9 Mar 2023 01:58:46 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A73C7C052E for ; Thu, 9 Mar 2023 06:58:46 +0000 (UTC) X-FDA: 80548457052.27.F5D1B21 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf15.hostedemail.com (Postfix) with ESMTP id 81991A0011 for ; Thu, 9 Mar 2023 06:58:44 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KwDhTJYW; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of mcgrof@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=mcgrof@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678345124; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W8f2ea6L1ZQM/RXA2NeeGLhnlXB11kWyC89O2xsJcLI=; b=7YsAdVekn9dZ2deiiC2wlr2028BzgRbrzhODeZW1xAc48dnQc7ZN3cY2tqeDV/B2/teX5Y uVaOTcu8Cv/iHeVxuygmwqFfP8ilBlAIweJfHGWCcA5MD0V8AAuWbuZMKv4hO8b9/DyBlb 5Z5Hr4S89g0VoJVUbi8Atx9JrQNqAJM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KwDhTJYW; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of mcgrof@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=mcgrof@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678345124; a=rsa-sha256; cv=none; b=GLyUrP9MawuySjhVI/Um9DjuwXetMMaJ+Kr26h85GC4nHMutNFRcdPxhkYQ6zdKNI5GKG0 ySHekS6aU7vzbau8TXUPtZXOPGDHDiQs8fnOIEPoimVy43r2HGFOuO7B2fEgvdGtYSPX0T T5TfRQJ8JJXOHZvS5PnYqQ3IMcLzPUM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D12C4B81269 for ; Thu, 9 Mar 2023 06:58:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0E4FC433EF for ; Thu, 9 Mar 2023 06:58:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678345121; bh=1S/wd+hKpOa/F8dKBaLK9Ag5Kf372Hr9z85x1GNP+6I=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=KwDhTJYWMIhfQx7U/0W7WRERYtJCIKgA9N/QlpDU6zCHdbohCkfxCsdhRVyerUlC2 qd0fyzF3q/QL75SkGMWtaWtNLEOH2Juj7xqqWYnq8+gbK8g0hyOtUcZ6qIHNEJ3Mfz nmRvrnNECni+KyXl2cRsfechqY130tvAZxtulnwYXM61xWUJhjPLb/CEdrHFvTNvpy kOh02BXT//B+Ck/jy5KqEYpznJY/yQdX0Vxms6yeBbXfIpAFA7CzDQtwEDBZHjjw4E YL+XzLpVwfpbKmni2bwkvBaZHyd+u1wNixhqPR2NRrIAdz/M5CDMZvGw9L7UuHLuKL 63YFVB2l+qkiA== Received: by mail-ua1-f53.google.com with SMTP id f20so493289uam.3 for ; Wed, 08 Mar 2023 22:58:41 -0800 (PST) X-Gm-Message-State: AO0yUKXnY9XJGFa0P1b5qCy0yYZ/fgAsgrIRqEUpfbkSYfg/mUvXTh// 0M0uVOt/3gvmQOC95c6QlhqPMBUH7J/KavH/FPU= X-Google-Smtp-Source: AK7set+0KhOx4nFMbYwRTzmk7V1SZ2d4YStgui1xCX7I1Op8Jf1XACHidFLrWfhbxVuEUr6HHMBSleLFW0Koi/398X8= X-Received: by 2002:ab0:54c5:0:b0:68a:702a:2494 with SMTP id q5-20020ab054c5000000b0068a702a2494mr13114939uaa.0.1678345120583; Wed, 08 Mar 2023 22:58:40 -0800 (PST) MIME-Version: 1.0 References: <202303091142580726760@zte.com.cn> In-Reply-To: From: Luis Chamberlain Date: Wed, 8 Mar 2023 22:58:30 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V3 2/2] mm: compaction: limit illegal input parameters of compact_memory interface To: ye.xingchen@zte.com.cn Cc: Kees Cook , Iurii Zaikin , Andrew Morton , "linux-kernel@vger.kernel.org" , Linux FS Devel , linux-mm , Vlastimil Babka Content-Type: multipart/alternative; boundary="000000000000b91a9a05f6722c00" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 81991A0011 X-Stat-Signature: rz6jcere5zo3fap6npnhq8fdb7o9zsga X-HE-Tag: 1678345124-543003 X-HE-Meta: U2FsdGVkX19c1aOReOmoZispZnYrVOVU7wvsrOrnTVIvYsoaYqbSZtji317/navMSrJFFCoKHXUi/vHCCgLxjgEtNCrjRUJy6pHuI8IDjWaibL+vf/Mo5b3fsvLT34IhO5ouhVbBDqYAOMqU9zKalAhZcMOhrZvFEb3Zdoa5flqIG1nPmqB1DZxWD2a9qEHvYjE+0lyg5zz2CkRDCES4EesaefZSpApVzK1vMprhEeZHqBkngzeA9FYG+WoHmnXnYKocKV/VIsFmuOVc1CFpIqpJdRprVnN9UQDYxpLgjswekvJ3TO4s9VPfF2IIfD49CDQjb/K7mdDLjZjcukHSGhUd9iSTXZolJ2MBR7iPz3ye79bkPaCDyw/2X7KxdA5conT2HE7gptbiuMNtNMOSdfkYmEzCA/z3W20DfIX1KasQMYT9HzJ8m9jtq0eYXTeuRJAixw5swBMzBlNTdibcsPgXzXx2EK1L3WAmCWinSuZ7UEinD2etQZXCLL7hN6P6QleT/aGv/fH7sk8YmY0vtz+uwTa1Xt/T2tWvuOnjU6mfDUyLZHlb6xQusPWGcurLZ9OY63NcMkaurtrYTg7aBJ+uJACeGBrV4p2Z9LmZ4O9dboxsKqrNOxrCsOpD7HwecQc2qCmJYfRVbNBaCtIZqMLcQZMHjn3AV0LJcAruFldtLGGBi9sgjptGFwYHCtdFny9wgDawNAO+MksHxy7NaFck3lcJtUPjoqcaQpBRkzR/y9vpsN5WxXHCaiV/HKn/rl4MJeN8tjFC0ajhPx9/OI+4XT00vdnHrl8kAGob+asdr9h3tPZW5fBm/6qU90mlKnGRlU9Wafn2gBGjjkZWoWLeWy3EsDPqYF/m0b4yG3wu1YyHvXPBSOIpr2vNmAwdlVN9OaJw1ziemODGAnCNQHMbo1FTFaSB2qlM+BtcGK0+ppjl01uHQgLwpae/qjdnb0mqyyBzD+UDrRmU9UO IwyICg1V GmUQoZ/W57qvnn+DpQess0ugcTPToSNWUS0kW+0VvefSIWwJnZngwbQx72MRmEWKGFunq8+pUA0RrqHd9rkxX8hlkS+Di3zJ8owJ5hAUFbYVyjva99OVScuYEWec0XE+VIDfxX24bJ89vcn0rO3HqhCBiFS53AtSVEFW+HGZojq6h9h7U0DBoOrs5LDqmhWl9g71mpjOnUlQjZwThKez9qnsSsJKAvY1DRQcDlfiAqd7rUqrc4qoygf+Ycf1/yPgQavW8SoPsQ0pzDNjUt/grPfsH1wmD5vxmbd98NL7FkJ1ozqXulGcH/c5r4oQDrd7vhPPfQ4eaqLyc9Hoz0MGmw7h3XRmlOCSGnLDPBIlK0FXVjzSEFF5O7CnoqdsbH/Zmnnz75u4wfExeMcpGBvtDA6N1cqV2zK4Tw52QjmUl8m2F+nb83K5eaei4v4ISPBs5jJ1UzIqrebrTuLL5r00NgBhm+S63LcdRHITG5ManLmiucjPVMy1MSS1o27oBh96fyqprmcs2+GaC/yPY26k3xZufSJoOt769pWilPQXY9WW8pVgtI/3o46v9qjD9AyeXda+XnBuucg/sCPFZbHpFCdW7swVA8ixUGwVQfttke2MwYP/mYUY7Dg9NMlAI/DmJtZUxY5RqsBxExQI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --000000000000b91a9a05f6722c00 Content-Type: text/plain; charset="UTF-8" Actually, it seems odd to use a min setting and configure it to map to SYSCTL_ONE to SYSCTL_ONE so just a SYCTL_$(type)_MAX or just the type max would be better and not break old userspace. On Wed, Mar 8, 2023, 7:56 PM Luis Chamberlain wrote: > On Thu, Mar 09, 2023 at 11:42:58AM +0800, ye.xingchen@zte.com.cn wrote: > > From: Minghao Chi > > > > Available only when CONFIG_COMPACTION is set. When 1 is written to > > the file, all zones are compacted such that free memory is available > > in contiguous blocks where possible. > > But echo others-parameter > compact_memory, this function will be > > triggered by writing parameters to the interface. > > > > Applied this patch, > > sh/$ echo 1.1 > /proc/sys/vm/compact_memory > > sh/$ sh: write error: Invalid argument > > Didn't echo 2 > /proc/sys/vm/compact_memory used to work too? > > Why kill that? Did the docs say only 1 was possible? If not > perhaps the docs need to be updated? > > Luis > > --000000000000b91a9a05f6722c00 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Actually, it seems odd to use a min setting and configure= it to map to SYSCTL_ONE to SYSCTL_ONE so just a SYCTL_$(type)_MAX or just = the type max would be better and not break old userspace.

On Wed, Mar 8, 202= 3, 7:56 PM Luis Chamberlain <mcgrof= @kernel.org> wrote:
On Thu, = Mar 09, 2023 at 11:42:58AM +0800, ye.xingchen@zte.com.cn wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> Available only when CONFIG_COMPACTION is set. When 1 is written to
> the file, all zones are compacted such that free memory is available > in contiguous blocks where possible.
> But echo others-parameter > compact_memory, this function will be > triggered by writing parameters to the interface.
>
> Applied this patch,
> sh/$ echo 1.1 > /proc/sys/vm/compact_memory
> sh/$ sh: write error: Invalid argument

Didn't echo 2 > /proc/sys/vm/compact_memory used to work too?

Why kill that? Did the docs say only 1 was possible? If not
perhaps the docs need to be updated?

=C2=A0 Luis

--000000000000b91a9a05f6722c00--