From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E02DEB64D7 for ; Wed, 21 Jun 2023 07:04:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 326B68D0003; Wed, 21 Jun 2023 03:04:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D6FD8D0001; Wed, 21 Jun 2023 03:04:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C7428D0003; Wed, 21 Jun 2023 03:04:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0D29D8D0001 for ; Wed, 21 Jun 2023 03:04:07 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A5C57160748 for ; Wed, 21 Jun 2023 07:04:06 +0000 (UTC) X-FDA: 80925865692.06.2ED3D74 Received: from mail-ua1-f41.google.com (mail-ua1-f41.google.com [209.85.222.41]) by imf15.hostedemail.com (Postfix) with ESMTP id A2369A001E for ; Wed, 21 Jun 2023 07:04:04 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=VLd89J2V; spf=pass (imf15.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.222.41 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687331044; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DZkHfp4tV94i9NTvQ3Qk2n4CpRzZ00rCA1jUemN32yM=; b=o5geycDlfBSOcAByeQ7XJuZqjnZvw2MsEASnhJpaGR0gw0BgAcFGl8+GXPO2bOIWSIT7gO X8peoTjoAuGefoFhar4j+Q44xEUS5T5w7BYySb7dvrO9sG50KVCiZ+XFFWp9H9Pwh1RnYJ 9UfE8dNGMIKZgHaMaQJtWpztDP/0/PM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687331044; a=rsa-sha256; cv=none; b=Ic92ri542SJcH45sTr7OauSkk9L7B+4DYFqKNfIt2lokJnoWvM6hVRTOO1MmkkrHlfzizO ObGyZvi0hIG3BXynm6Y6+ulwbr3sPt9x9QmDINX6ZStLZSqRMd78LUDHiu09WqvIgVQMAj bTXX6vWJWek7WHXg1PFFiTfY83xVSR8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=VLd89J2V; spf=pass (imf15.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.222.41 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ua1-f41.google.com with SMTP id a1e0cc1a2514c-78f4799f4c9so1828036241.1 for ; Wed, 21 Jun 2023 00:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687331044; x=1689923044; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DZkHfp4tV94i9NTvQ3Qk2n4CpRzZ00rCA1jUemN32yM=; b=VLd89J2VBCLEliMIUHRzbTXL6Yj9ED3LW04MQzGs/m8Jy4Fuewd0gpLoDMZnA3tH6x QtbgclUdAir0CRVqxOXax9Zem2XazRWk4IR7nEvjFjQPSULPP1wIEqUxVJEjhr6t9xLX 6ml5U0rR3U3q5cnjamGxpW75HHJpeaSb/Ff6jDdHhmFEjDRlU+X6ZbDP1xVQC+1jG7xg MV2NVBwYbUjfUmEz63E50C24e6XM5jq1WG4Ubi1RAeJnxbGyGn6ZDGH8zyzthqu6nWs0 f8AnsQZ8Yx4RmbH/9XdSTaipJS4IN7yTIwuurcavxZR1sth/ZVmIZNeQLJkHRFseajOo UqSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687331044; x=1689923044; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DZkHfp4tV94i9NTvQ3Qk2n4CpRzZ00rCA1jUemN32yM=; b=geahZ6KvX5NUqYVrpxryVMXCYiQJa1jpxWqto6gVrYq4/t4b0YOo+zWRRJxw8/4gPU zkBllq8KSGJqHMwcuLM7fSqMRcUpGjlerhmmcX8oWc2SJuTkae0DjM+/9lfUFngEZ1wC F7mA9eHB/L1GRLw7VPegRbo4DoZThtvGeqlLXMm0MZm5bt6TSLwYC4G92DuV4KAg57yU Qn9W9r3FQAKZwRJDR72ToQsjdlXZZUt1xx060nVGgB57r8xvw27Qiv1+N95DTk7XvEf+ WM5AARQ29LO+TKjTVht8XVLy9kO/eF+i99Vin301/oSiEQEn9Ww2BZK+IZP97wZg8ZP5 PZqw== X-Gm-Message-State: AC+VfDzQShf/qspOUBIH5kZGgqUNUE3lfr6ijiihAVc9P37CeMY2AJgw VZyW4t2CUqdlWmKL3RSBNbOT3rIMAlSzoZ2ILcA= X-Google-Smtp-Source: ACHHUZ43ttIuFJA0tq13ftbFfQCC7hv4/NWWz3lHgpfWG5y1ZXedfh+hUl6GzKehxFC68R0bgIrZhJZLqcQ3LN6Is3s= X-Received: by 2002:a67:f297:0:b0:440:bf7f:f46f with SMTP id m23-20020a67f297000000b00440bf7ff46fmr3858606vsk.4.1687331043641; Wed, 21 Jun 2023 00:04:03 -0700 (PDT) MIME-Version: 1.0 References: <20230607195143.1473802-1-yosryahmed@google.com> In-Reply-To: From: Hyeonggon Yoo <42.hyeyoo@gmail.com> Date: Wed, 21 Jun 2023 16:03:52 +0900 Message-ID: Subject: Re: [BUG mm-unstable] "kernel BUG at mm/swap.c:393!" on commit b9c91c43412f2e To: Yosry Ahmed Cc: Andrew Morton , Konrad Rzeszutek Wilk , Seth Jennings , Dan Streetman , Vitaly Wool , Johannes Weiner , Nhat Pham , Domenico Cerasuolo , Yu Zhao , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A2369A001E X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: a1c3io7n8k8i1tnmdpyfaak9od9er53k X-HE-Tag: 1687331044-129331 X-HE-Meta: U2FsdGVkX18C4osjUCHmzhTLz92zZhcj9F7rSCSWEMdok/gd4yMtX5my/eWVnfnXXoPDMQ+UyvSL1XDnpv8p8qtQfaPSMZAQ8RbhuZfLKSZyrl/idzepTBDkzov6qlUPNXdowsJ4f7/vA8J7xJIK5Umh2sJcAjSXf0/ovNjwRY05hBbLNb3ruZXalZ30uBEI+5ffWbZXs8E4SHecnbcpKcQfC7K0QYuu1nVYIbBzYCMyQhGQDk/1q/tucSTCiNcUe8oC4sSUwwBmEs3y0S49nPyf4yjVgG7XIemuvS/vX7PGEZY7Hrc2VE1eHhQMpEv89OB941kqLg1BrPGrmm3bWzj6FJIWt8sSTKG8oISylOFUXRLWq80hUlHzCUn9cVqtkHgyGEBM49KY0W6GHhIKSLxC4o4AYXmVPX4Dzm4XNKv1yhQtBB7lGNp7I4xrhkwyekryEAyn/OkQ6nWnnJB4Rya2AHPYTXc/qBkPtYP1yOZoSv0gm8/oadGZlJlcchq26Osgi5GeNYiWY49gXz9/6MdnHeBoNHOctHcNsaOZK7XJ2SSo5oZk8Sit36M/3CrO5dpDdOJ9bgUXXVdbmZrNm8mR9VtxfmOXoHtoJ+VkCTHnnAas4se5y8XxbIVuMT1G6gzUE289Ht2lMCR5Au6TELBRGD3JZ91QNN+xuNSoz4kcFpxY+6a70k6OC6+JU253/G726TxTGqKKDiu25vxaGqqk21wgCb8VoZOOI3ou0baKsJGvalbX/AMZdwpJbf3JZxGtBhKkgr/1E1F2G6XdO6B8Uj744aKdcYOPBCaKC3U+h7OIl81EXmU33ZLAooncSsidgflziGSD4rdFm1tTGF1uiasIuHCzjD4ki4to6Cbcpf8nbcHJbaa9kdwT/HOG+v+hEifuOETAPqvyx3J8i6l7dTJZ3vFqAz7NG9jQPPrZquqIMglZrQkzblKA8zCJDKR9trRIOiO+KPpn0D2 BjMqzw0f 6JeZ5GVkh053SQGPTvzHZ7sdB7Lpr5PTGno2QeBCY5PkMvL5hS1f7bb74/UNn+/9WPTS2qUKGUT/cR9yX26eFd7orPpqcqAnKs/woNAJAVANihKNkOInvxtMAwN390yO8g3JuF+oK+t7WYaGUqqvpIQZtUKt/DEhJA3lWFZEXrTlVffvYcLOxv/9jPYUfuMt4afOl2p8SUKiLKzuYWzJbIZb0EuyATUWgWuwM08vJ1QU9trTSkzsrRyYGLZhCvIckM9phMZfHc8/9uqPADr7oRQuHMcEx45vTaz1eOUB8rCm8pt3JDXQ50DM/0HJb5Vb/ZHiBV/tw+f9bNQvJ+OAOwlkpkQ4QwyoNV/EEQG8IifbyGwtTwY7TC0VQ4auJwN6HHcYwvlMD5VW7gd5UUiK98a+WSZzgKRDqa6XFtfoiwZIFdaUpqBObXNue5jk1dwQZmaubjeBLwaOBYUVW1cN+UX6MIcQJfNuLgHO7if3UlhqRP9d59aPckLwB2VGfrI5KCKD6jznOafXFWWglDq3VMi9+bA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 21, 2023 at 4:01=E2=80=AFPM Hyeonggon Yoo <42.hyeyoo@gmail.com>= wrote: > > On Wed, Jun 07, 2023 at 07:51:43PM +0000, Yosry Ahmed wrote: > > Commit 71024cb4a0bf ("frontswap: remove frontswap_tmem_exclusive_gets") > > removed support for exclusive loads from frontswap as it was not used. > > Bring back exclusive loads support to frontswap by adding an "exclusive= " > > output parameter to frontswap_ops->load. > > > > On the zswap side, add a module parameter to enable/disable exclusive > > loads, and a config option to control the boot default value. > > Refactor zswap entry invalidation in zswap_frontswap_invalidate_page() > > into zswap_invalidate_entry() to reuse it in zswap_frontswap_load() if > > exclusive loads are enabled. > > > > With exclusive loads, we avoid having two copies of the same page in > > memory (compressed & uncompressed) after faulting it in from zswap. On > > the other hand, if the page is to be reclaimed again without being > > dirtied, it will be re-compressed. Compression is not usually slow, and > > a page that was just faulted in is less likely to be reclaimed again > > soon. > > > > Suggested-by: Yu Zhao > > Signed-off-by: Yosry Ahmed > > --- > > > > v1 -> v2: > > - Add a module parameter to control whether exclusive loads are enabled > > or not, the config option now controls the default boot value instead= . > > Replaced frontswap_ops->exclusive_loads by an output parameter to > > frontswap_ops->load() (Johannes Weiner). > > --- > > Hi Yosry, I was testing the latest mm-unstable and encountered a bug. > It was bisectable and this is the first bad commit. Oh, I forgot to mention how I was able to reproduce this: $ stress-ng --bigheap 12 (my box have 24 cores) > > Attached config file and bisect log. > The oops message is available at: > > https://social.kernel.org/media/eace06d71655b3cc76411366573e4a8ce240ad65b= 8fd20977d7c73eec9dc2253.jpg > > (the head commit is b9c91c43412f2e07 "mm: zswap: support exclusive loads"= ) > (it's an image because I tested it on real machine) > > > This is what I have as swap space: > > $ cat /proc/swaps > Filename Type Size U= sed Priority > /var/swap file 134217724 0= -2 > /dev/zram0 partition 8388604 0= 100