From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2100CE7716B for ; Wed, 4 Dec 2024 14:02:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 798DB6B0089; Wed, 4 Dec 2024 09:02:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7479B6B008A; Wed, 4 Dec 2024 09:02:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60EF26B008C; Wed, 4 Dec 2024 09:02:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 44B686B0089 for ; Wed, 4 Dec 2024 09:02:18 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 008CB12104E for ; Wed, 4 Dec 2024 14:02:17 +0000 (UTC) X-FDA: 82857440862.11.E9318D6 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf16.hostedemail.com (Postfix) with ESMTP id 7FC5618003A for ; Wed, 4 Dec 2024 14:02:00 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="b9q/qOzj"; spf=pass (imf16.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733320924; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rzqLa6jGCD8QycjIJPd2Pg08jy/GBFipnIUKcz2Soy8=; b=vC4B06A571OGD425gSioykeoijMC+wZ9vTiPmccipplH+DEXS0hTSqAGNpYb6L+TL5+53+ IS/3lYhw3I+i0razs6NYFS0Vyo9ZcQba+BFGh+BI1XO39ZfMOwbtfBTNurDLtHIsz38tTA l44P2aDrTnex/RUHqD47lOSOj2Wb970= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="b9q/qOzj"; spf=pass (imf16.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733320924; a=rsa-sha256; cv=none; b=P0CHbppXqMD679UwFaE+kIIo3+ofbficYixZSOmIfeeib2zVT2gNlg/v9GgLkgvmniSN2m /AgrohaUToMOuEnNxMhHRElk8wZjegk+UkNEze//dtgz1g8pQ5Nlnk+lvr++6mSF5Zfz1v Sbsh15bgjIjiChHBFWlKmddeDbwsh6s= Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-53de579f775so9674573e87.2 for ; Wed, 04 Dec 2024 06:02:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733320933; x=1733925733; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rzqLa6jGCD8QycjIJPd2Pg08jy/GBFipnIUKcz2Soy8=; b=b9q/qOzjV1OsD/FD/VdnsyOtraYqdh/Z569i1v+TJbJMLHcWyObj4oiMcnGqM8AONd t5UL72JtJ0hEp/2yV8MC8dhbEOMYGh4v4FWRmrGUe93x27KhwWDBFiqWKkO0TXrwdPOt cpkoJZyrB34HuCgPqX2EWAN/tfnTFI2+uXvB1/OQruE6JkN1pP9xhKm5KFIUn0CJg4y3 tqa+CSiHmbhZmzAtI8tlQWqlbBEHA3zlK55oSSawJ6wk5yCHWtZNdMmgSsOGzA6sqGYE 8f+S4pLlKwzkYy7Ful2TIvR8Cr0wTTLuyEoRtXNNSQuQJ4O61Y1EPEXg48ZDRbriU32u zSyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733320933; x=1733925733; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rzqLa6jGCD8QycjIJPd2Pg08jy/GBFipnIUKcz2Soy8=; b=S/JmT1SgORnBSauk83+FxftP7W248fQs/rK0Ol1nKxX2zqzm4qVxrzIY8+ybENtPlw QtXwZCx9jy7dD7q6hV3vebwYxS4SSvuqXsZ3SPxXgzo8yPEQlqhkTwlQIixLW1JKeJ1M 2IFlXaRud+hAvGQu2mlxpxm8K8hkcsFI/9RFCWRBHIgkr2mHZNbrs3UXHZQY9N2DAade 5F9UcRWf9OaVRpBsODzc5iXzMHFAw2SyHPQUO8hcP/d1WG7hnQJ59QmILD+eMGKjVIVj 0RrghfaTJ9sbK06v4KbhNCFTEWU5tsVI6GHTpg9R35+bJ9ZHbKZQW4ONbO+PMJaGsflE MEcg== X-Forwarded-Encrypted: i=1; AJvYcCVc3UiKGjxeq7zLRRgcBcABgs2r/gJ0YRA/JYs+DTnT0QiiJ94C+B6kV2Shcs1op71iJQQfkc8XrA==@kvack.org X-Gm-Message-State: AOJu0YxfGp764CFteIT6g6ayCxsAZTf55hQEvZCXG1A3ZKZAHpm+T4Ew fUMqd47vu/NAQCt335f05LnX4zAP5jmnHOEBxvXdR1fPiGhWWPzVwGocVukMuaHdwCPkSA9+8ME 35eUnM7KsBTYbBIR7kc5BZB0+f1I= X-Gm-Gg: ASbGnctl7ABC42k7B+OvaNlpUNjUSL1NizKoNGjvumhbbAzC6jtRnDSEQOsXPZJNGm+ 0YpQpF0tQ8zdPs/W8qaBVEX/tuqBW8aj8NMXNZ7rb4pBfkZy3N42Hzf6wgltIiZYQ X-Google-Smtp-Source: AGHT+IG5T5Cs8JlNQpX9NGevIU0NaW5AfdtFmwSwovLMNYsQSOMeXR+EDuBUprx2oFfcxsjk0scugsoVpHS5QKOxq5M= X-Received: by 2002:a05:6512:138a:b0:53d:e5c0:b9bf with SMTP id 2adb3069b0e04-53e12a3935cmr5453848e87.52.1733320932363; Wed, 04 Dec 2024 06:02:12 -0800 (PST) MIME-Version: 1.0 References: <20240902072136.578720-1-alexs@kernel.org> <0a10e61b-f0e6-4423-996c-7884c93af65f@gmail.com> <66d8bd3e.170a0220.18832.0206@mx.google.com> <674e1324.170a0220.377d6f.b6ed@mx.google.com> <8f87ec15-9aaf-47bc-9255-5a6ee721552e@gmail.com> In-Reply-To: <8f87ec15-9aaf-47bc-9255-5a6ee721552e@gmail.com> From: Hyeonggon Yoo <42.hyeyoo@gmail.com> Date: Wed, 4 Dec 2024 23:01:59 +0900 Message-ID: Subject: Re: [PATCH v7 00/21] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool To: Alex Shi Cc: Vishal Moola , alexs@kernel.org, Vitaly Wool , Miaohe Lin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, minchan@kernel.org, willy@infradead.org, senozhatsky@chromium.org, david@redhat.com, Yosry Ahmed , nphamcs@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 7FC5618003A X-Rspamd-Server: rspam12 X-Stat-Signature: 4k88j6dzh77d5azw4e583ji8oiuwrj4o X-Rspam-User: X-HE-Tag: 1733320920-670265 X-HE-Meta: U2FsdGVkX1+QHeQFD32mD6bcaFsx6auelS8+eIS9AIEAqLweu9Tnbbe5qxff8LsyeSLkKh0dbRyGO8Tlh5PIuQlDcF6sz8VzUuwC9Tqmr1HMWCuuagZwi+1rCjt1jZR22fBTmCIrP4VxpivbllBEioGJSk7RV7MO8rnKTm3GNBDcaoaSt692QIj65DSf5sC8owR8cRZKv4CH3kmI4eP56Q+GNWhq9TzIFp+g7tTF2SaJ1lBKYMGTBDE0MWyFYEFfI9ItS7HRC/Y8SM+RgM9hCevSrvC5IesxnHJOpngM2DCUjpwJhFe6CCLyCJ2/Y0F/VAO9FXhfDo1JvND+7aBaONhy95kVThTbav+Z5B/vwFWGPBbjaaG3WkojpkZQzJ7+7wrHb0I1jOubQ9SDOv/yaXl4JaydSTFfjZuvOQJzV8k0ht+KBlH9qeKkT56pNcIFvjTDA5pQczOuQ0+bv809rQCqxuQMSEDBAIb+EyJUVNd13kzqGwCdIWcmBF6K85g9suwEYxmCqYRx/0MTrpWgc+OGBcy0xovx/HhvrhHDJoYhDBfhz6aScFshHOHwGI02CiFQwBHImHU+8PoopXfj7VTMKkOBWDOip2xpyXL3mfA+ptLVVV3GJWLj/qGcLVONv/6qhaKFAxgPjd3FkzzvZLGDYrOl9G321T0El5J+z32xdH8e4KTwViUUbd4a0zqy/nCmnxX2pxyylK6qAeV6wSgcYZVec7Cyz/ShVkMUvg/llCJVxfEmD/UJ5O1QrpARc5ZoBmkhuaQvi3G4GHAONtOQxDMTrLYVWoi3OfyScUqKZByyo5A0CZpwfMkRw1yHho4fwqPy7Bhe1oxTsixV2niv2tq0PEaeEQjoyYJGjJIx8lCIW/R2KlGFkPzmq7J2z3D7opiVVcUGRMzLE+frlC7vJCkdykb5HbaZMEssG2NIV66wMg7+bCTa2xS/zAjcUiM8xvmniNywa6WKoZK EHp473Z4 gyWUXWa3MplnU840tb5Te2qpGUqNr9Bvjw26Re3CJLOTWKzN6nBHIo50AcjkA87/3hr0cJ/oNiUMRixx4sUYdAHENN6tebIeqeZAC17jjwaQgk5LWdv0ris0HeVZZ/7t+O4m74iKDtmUBjVixntkJ0iTSxdKoXb/diY3gV4lK8ENKgd8E9avBN+JuOqCH0DH7hJpPYuorCkIOP1I/1dzXtrhh3P4NziF/yqByl0oYRRJVdOMvThbQsc6AAihk1xBIZoBNXKo9rTKzseRayalYpN0xOQWXPCogn20a9Z9eIvtLjtj6/ZvEcRwFgVnB2oLMP2sC8q3y3TIiIKeEgltJk4+s1ZDDBPmg2A6YazUj68wPzqTBCWFFrU/Iyr3epe3tljVmpUU0uF+8KnAsHt9bWqDpeKozkUbIhAwfxp98QFcJ1oJ/OnZHfb7Rctgrskc3xBgxhajq1yRB6YiLcvTiQsjhIn4tZSQWtaiZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.006272, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 3, 2024 at 10:58=E2=80=AFPM Alex Shi wrote: > > > > On 12/3/24 04:05, Vishal Moola wrote: > > On Wed, Sep 04, 2024 at 01:04:11PM -0700, Vishal Moola wrote: > >> On Wed, Sep 04, 2024 at 02:54:14PM +0800, Alex Shi wrote: > >>> > >>> > >>> On 9/2/24 3:21 PM, alexs@kernel.org wrote: > >>>> From: Alex Shi > >>>> > >>> ... > >>> > >>>> > >>>> This patchset abstracts the memory descriptor used in zsmalloc by zs= wap/zram. > >>>> The descriptor still overlays the struct page; nothing has changed > >>>> in that regard. What this patchset accomplishes is the use of folios= in > >>>> to save some code size, and the introduction of a new concept, zpdes= c. > >>>> This patchset is just an initial step; it does not bias the potentia= l > >>>> changes to kmem_alloc or larger zspage modifications. > >>>> > >>> ... > >>>> > >>>> Thanks a lot for comments and suggestion from Yosry, Yoo, Sergey, Wi= lly > >>>> and Vishal! > >>>> > >>> > >>> This patchset could save 6.3% code size, and it's a nice abstract of = zsmalloc > >>> memory usage. > >>> Is there any more comments, or mind to give a reviewed-by? > >> > >> Please CC me on future versions. Most of the zsmalloc conversions seem > >> ok, but I'd hold off on further iterations of the descriptor patches u= ntil > >> the maintainers decide on what/how this descriptor will be used > >> (i.e. our end goals). > > > > I apologize for leaving this in limbo for this long. This patchset is a > > prerequisite to shrinking struct page, so we should get this memdesc in= . > > > > I think it's safe to assume (since we've heard no definitive goal from > > the maintainers) that in our memdesc world we want zsmalloc + zspage to= be > > similar to how it currently looks today. > > > > Would you like to rebase this on the current mm-unstable? I'll re-revie= w > > it in case anything changed (and can then give you my reviewed-by). > Hi, Vishal, > > Thanks a lot for the review and kindness, I will try to do the rebase in = this weekend. For your information, there is a patch series (not merged yet) invalidating the assumption that zsmalloc always allocates order-0 pages [1]. I'm sorry I wasn't able to dedicate more time to this project this year. Thank you for pushing this forward, Alex! [1] https://lore.kernel.org/linux-mm/20241121222521.83458-1-21cnbao@gmail.c= om/ Best, Hyeonggon