From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F04ECDB47E for ; Wed, 18 Oct 2023 06:34:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B6478D0138; Wed, 18 Oct 2023 02:34:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 067C38D0016; Wed, 18 Oct 2023 02:34:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E976B8D0138; Wed, 18 Oct 2023 02:34:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D96248D0016 for ; Wed, 18 Oct 2023 02:34:29 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A7DE9140134 for ; Wed, 18 Oct 2023 06:34:29 +0000 (UTC) X-FDA: 81357618258.14.5FBC470 Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) by imf08.hostedemail.com (Postfix) with ESMTP id B634E160027 for ; Wed, 18 Oct 2023 06:34:26 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jFAN3Q8r; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.222.47 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697610866; a=rsa-sha256; cv=none; b=78i/Q+FRf/x/EaVRQsCuie5Qem8QbEOW1r0H8mir9Afs0L67W9XHKlrZxegT6iywtdqr4z QR3x6ZjrhnT5ABJU5+jFAWwJZbfjAQ1b6PbFMNtbuoD/xmPI/5NZ+2Fpak5rkr8Lo/78Fd yt1kpAlHtGfJVWA6N34gyD409l5fpW4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jFAN3Q8r; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.222.47 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697610866; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AvhtsIpX6Tz25oR+Wmg24DRV09zwdRaSqOygIYnIWik=; b=B16DOvWLdbjHXYPu+6BRWE2vjh7xrYFfnKHzjszs2iCPineotD858oNz5wVP1cNO0YqwV7 To57jQRflCAy9OxVpd03kWuucIqn1J5JmpxxJPGUvUmqJVfl5puX+bhvpikp82eGTrHTNF rlhrh+IHZr+okTwkStGowIj09M72lEA= Received: by mail-ua1-f47.google.com with SMTP id a1e0cc1a2514c-7b5f28da928so2473135241.0 for ; Tue, 17 Oct 2023 23:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697610866; x=1698215666; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AvhtsIpX6Tz25oR+Wmg24DRV09zwdRaSqOygIYnIWik=; b=jFAN3Q8rRNV8MzVwoSPZINpPlXXm//jUWQcv9dvU+Oe3kwt+8XGYboQW6LZZ/4uMPJ +kVwlwwzhDb0PJLhUW2e++adi3vibpuKN2Sqmp1HRsr78PCztSR1Ua4j8hQlkgOcCl3c 98PayJbISxvX4izhH93zGTwqMq6f9ozzQUqoM5L7EuYbnvnAiGZQkjBL6+PoiNBiSx41 vyyN6g1JcIuEbO/O4uxRblc4ZQv7UqTVlWmkXh8B8FMn52uAQ7ufY/xP6wkthtcgFttb BNffP8kgFNeTnjxK+e4nkeWVg82mZtA1VZTjCG2L/YlfE8wbRTbcyrwUAmkYyIt1m2v/ RANQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697610866; x=1698215666; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AvhtsIpX6Tz25oR+Wmg24DRV09zwdRaSqOygIYnIWik=; b=eW73n1bPbdUeuM+wLaEebjRk+qGCwo4C+CyP1H75WUl2VBO0hMe+Qf/xvlS/j/gEUf 38SZbW1BZlZcS9ju91CitN9HAKjKLe8MA1v9VVAHYnGdCUTRnWQup97+5m5WpU5Fcu4O ahZ54b1XgnLmh9UDRvfTMMJwT9UIMo/OgZ6yfYf4H1dhDp4/wlGpRy0dsPy1fWLEwlsz NfIAj4mQMRp/fIqL2AXPn8jNOSxVCFF0ZX0t13MpfmsKZJ2xcPtPMF6PqFYasd7u5UGv W4zvnOj4JjlC4io1/BsaXVhq93QIYMd5As7b463wcUgJzUoIT3T/+4SnfLbn88N0nDrD 579A== X-Gm-Message-State: AOJu0Yw8iS2OQ0zEtfofZ9tYzZe5+jCrbdCooZ1mmTlVOcZZpuOXk4Qo TyirFFyBL0CBGOgD0/MBGefsX+/1VlbD2i8/o/4= X-Google-Smtp-Source: AGHT+IHEiNDU4HCWR3okxDci/owx5eK8w/DH00Sqjzjbs8UDHbs7kygqNjRvzNCdzy+DsWdoqLcl+KQ5LNjtRCq4FX4= X-Received: by 2002:a67:e006:0:b0:457:c52e:deda with SMTP id c6-20020a67e006000000b00457c52ededamr4300092vsl.34.1697610865597; Tue, 17 Oct 2023 23:34:25 -0700 (PDT) MIME-Version: 1.0 References: <20231017154439.3036608-1-chengming.zhou@linux.dev> In-Reply-To: <20231017154439.3036608-1-chengming.zhou@linux.dev> From: Hyeonggon Yoo <42.hyeyoo@gmail.com> Date: Wed, 18 Oct 2023 15:34:14 +0900 Message-ID: Subject: Re: [RFC PATCH 0/5] slub: Delay freezing of CPU partial slabs To: chengming.zhou@linux.dev Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chengming Zhou Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B634E160027 X-Stat-Signature: w1xyecsmqs1nuqka6pf5c5g6cf7p6jbj X-HE-Tag: 1697610866-61512 X-HE-Meta: U2FsdGVkX19YX5bcy/34MeubuY5Wlux1tYWRsgM0o26tt7ABs1hY4eUGupqa34Qjm5JxmskhjayRqTPRqwajn5uqQiBcAaXXyO2ryvCkFCo1k+JL9ohWX1e4kEGs/whroh+xBNLgmyzYY6wtKmOo5jw2sMl6D4zbZb1oCFyin90PhUkcxBjptb0HMQv2ENRWPVU6V5hK1nDeqrENyi4pGBUJilDTUNkHx9EiFjgVeYTMwwxDLTspR1Iqx3CB0Ke91JgmGcp9vntJTr+abaKdOxPXsL5JCdyjW3WCE3Mp5fkvwx2DZF5lMe/2d7u1oTnhzSCB9KPcVvDuaj4LlwgY0hTec3U7UuOwP7UAIzcKRCo7vvru1wAVSlaftFh+xEnKdRZnvAZZD04f7yYyY1g23iv/vDhRfLUBOaDuIruo5xYNg1YFt0lM6kNArC9hq04tkQ4utARK7epAg84Q+ZPbnPiP6XS0RXk97v8nyKUulpDOWjOinNx1kR4shh4Qb/7HASj0NNoFywtRc4Gkuazo4Ha/SJFxzbuU4uOZRLsG4mgbJhwKkwaXaXSmubSdknvLGn9fWpy5u9AxAljscE894Qbk+5Zc7iUW1tv6HemBtOabxL31r5rpc2mmUnZS6QJ8NH/kv+7Wl/PWxDXOU6RtpoJUIZnAFz3m5ysGB3bDTb8cal/gtmEid/IV6nwmEkuN3Q2CUbTyxXbrJdgr4Au+GWuMENdT6r9yV4fTKb5GHqRaH1ZpVE4YVl0KBsiQXGd/nBfzB5IGiFDmbu1unWN+1NSLG+a5XIFusKj4HFHRjyEjdfOpG4t7SCgk8RkQxcKOIcKcA49Tv+V6UMp8hQ/vCegUJt8PYCCvpP+ml3PlGJpMamTh9+Zc57ZU8+0lntDiaZNb8Fflx8CK/Yfghle4Ziw7cB9PRNwWIOWdBSMYTQln40r9yLpsQ1ty8ZVdKQuP/ypYOSmoLDNVK6SnsuG sOLH+NCw /FmdfJuao0m2ia659cYLnKvdLM9SyPj/Xq6yRp8C+S0RmCfeO9qAW62ztHQq7iQVvt//92sj6sls2L+Sjx7Gff4FFIbwPYh9siZ4BasbApgmS25ioFJlBLQvLAIGbaM50JxzKXfEuc5n0Mh7cRw0M5TjoYvHkjYKcnmTA4rvxPCaPbsYn3AgrHqYXL/bS4F8ezLi7mWjngEeNhOqytAsGq72pAX0aqywUyxR4fwMq/1zKnKHaoL7ro4kNBjjuEcmgu5rpV5hbmdR19bMnSBy1FNsIBe6jFAf8NIGlHEJ/k4yBc1f/PP9eK6pHUKiCdKu+0nUYeg6JxCnsCaCt3Jj0fRv1NgXvCxRHikehC+RfacPcV3d01DcB1pZBc5l3o/w6g7Ip2Cy7141ixwb28ldsj8FnBw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 18, 2023 at 12:45=E2=80=AFAM wrote: > 4. Testing > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > We just did some simple testing on a server with 128 CPUs (2 nodes) to > compare performance for now. > > - perf bench sched messaging -g 5 -t -l 100000 > baseline RFC > 7.042s 6.966s > 7.022s 7.045s > 7.054s 6.985s > > - stress-ng --rawpkt 128 --rawpkt-ops 100000000 > baseline RFC > 2.42s 2.15s > 2.45s 2.16s > 2.44s 2.17s > > It shows above there is about 10% improvement on stress-ng rawpkt > testcase, although no much improvement on perf sched bench testcase. > > Thanks for any comment and code review! Hi Chengming, this is the kerneltesting.org test report for your patch seri= es. I applied this series on my slab-experimental tree [1] for testing, and I observed several kernel panics [2] [3] [4] on kernels without CONFIG_SLUB_CPU_PARTIAL. To verify that this series caused kernel panics, I tested before and after applying it on Vlastimil's slab/for-next and yeah, this series was the caus= e. System is deadlocked on memory and the OOM-killer says there is a huge amount of slab memory. So maybe there is a memory leak or it makes slab memory grow unboundedly? [1] https://git.kerneltesting.org/slab-experimental/ [2] https://lava.kerneltesting.org/scheduler/job/127#bottom [3] https://lava.kerneltesting.org/scheduler/job/131#bottom [4] https://lava.kerneltesting.org/scheduler/job/134#bottom > > Chengming Zhou (5): > slub: Introduce on_partial() > slub: Don't manipulate slab list when used by cpu > slub: Optimize deactivate_slab() > slub: Don't freeze slabs for cpu partial > slub: Introduce get_cpu_partial() > > mm/slab.h | 2 +- > mm/slub.c | 257 +++++++++++++++++++++++++++++++----------------------- > 2 files changed, 150 insertions(+), 109 deletions(-) > > -- > 2.40.1 >