From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27BB5CD5BC7 for ; Thu, 5 Sep 2024 13:59:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0D6D6B008A; Thu, 5 Sep 2024 09:59:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A96BD6B0100; Thu, 5 Sep 2024 09:59:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 937976B0101; Thu, 5 Sep 2024 09:59:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6C5966B008A for ; Thu, 5 Sep 2024 09:59:29 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 01ABE1203D7 for ; Thu, 5 Sep 2024 13:59:28 +0000 (UTC) X-FDA: 82530842058.30.EE936EE Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf08.hostedemail.com (Postfix) with ESMTP id 18F1C160015 for ; Thu, 5 Sep 2024 13:59:26 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=h3MTneqs; spf=pass (imf08.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725544671; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vife+4ZTF2oXftiFxvdfKNakPX2GSpX7wpd5U1ID8tg=; b=jcA4qB8/NK8p097mAYrVDTwMkoCM2yLv8QpAtpSL4FL64wyX3uR41hoI4ngN1J2AOKuZpj dUJOz85zNxWD5QVBWg1Jo8gOle2T6+PgekMAiNGmG2r/EDP56Z+9Zs2EuxuY/zBpSmLEsH ipx5ZSdxLWLif2xmiajsqJTP6NT0Us8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725544671; a=rsa-sha256; cv=none; b=SMltHpUR+Y/dF+QuB9AoZ8FO6Tb55R0DRKUqtzb34JR4BvACf4J+mt21dwBzAtoo8W9mD/ zUkyFfdjXU4jBpha1hLX5C1cq0waS+SOwBYLWbjciuAoa6piEWWXlfKfH06i3TwS/byUvx vnTgT5cSiqk/UAed8Ky9pIy20yO7UMQ= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=h3MTneqs; spf=pass (imf08.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.167.52 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5334a8a1b07so945328e87.1 for ; Thu, 05 Sep 2024 06:59:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725544765; x=1726149565; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vife+4ZTF2oXftiFxvdfKNakPX2GSpX7wpd5U1ID8tg=; b=h3MTneqsCESdN8QzG8K6t/a7MDMgq/yXgtVshDjfkuGeagkv7TMmXvBpO3kgiFaGcG /JKT9XM56ZsmgFOMemoJmggjs8/7pJ5rv2zQ1U6p/fILxgCj4BqfDzD8NS3M65vV3j2Z 4SD/PpClpDX4tmjAT/Ic1eG/cLN0ecq12ZygZGDTX9uweOCZDYfceEqCWngCg4zg24U9 2UF3mHeLLaJJPLX44EJ9IDaKG89OtnFm5TMog8LxiKVlhxlq+8JxaM7DqtEo7BFnaZ4j WHC39fW+z2L8bYh5Z2A0+PgBnLNPx5fqsz8RX5HrqgpnyaattEq8/IjbteaY5YpvQOMR J+zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725544765; x=1726149565; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vife+4ZTF2oXftiFxvdfKNakPX2GSpX7wpd5U1ID8tg=; b=WCJzeBL6WNZ35j9Du94XpWpz42h/ZTfUlBfPZjuYVF1lPSc/8yg3KvbZkyrPG/UfZp ILRJ9FMluS/gkjiDEK5U+BsNAUN6xgTegXFHVlGZecrnLA5+H9uu/sKHfxEm7WhiEYPM GCtJm0DOkmjU2xbgj2shv1C87CMz5QaFLU4BqNQWRignXbhZXSiVDAPek/IhL+sLRKwW H5H5xLvuWF12Eoo8c+t4WFVzP6hKgO5Bv441fl7/+lh7o+uhOgFV/gt6CXw1geyy5mGO bE05hrbfD9oL57pXvgQOmXAiyfxgR86V+HT+tnYlcbDNa9bPDDraENiAoIGYWKCbcDvC qD0w== X-Forwarded-Encrypted: i=1; AJvYcCUJZIZ7xHwLc9NJ6MVgvnGVBo4Th5vUTye67MfuEbzDx/Ymjv4OPARQCWhhuZycDQNv5mEtDHTDMQ==@kvack.org X-Gm-Message-State: AOJu0Ywsc4/vYUkyiiTxaQ9zehe9DI7/qzCuXJWw9N7aDff1NAykHQXJ q2bdLQMZD3bunAfYv6uuSzxISCzzkdm9hCAC7XhM8UB7SF7vFwoBGYWT87xPV5aQavdC/NLCOyN yCBR+Qpj0Ho2VmQzaDjOw4RvrXQM= X-Google-Smtp-Source: AGHT+IEPU1QigGvdtM0L8Avx5Fii/b5btBRBdHRMbrQ6kyqy0AFePVOfRAXoHWn9e00knQfqd+lkQ1HAQzvvCB8mi/8= X-Received: by 2002:a05:6512:3c8a:b0:530:aa09:b6bf with SMTP id 2adb3069b0e04-53546b34938mr13958753e87.24.1725544764671; Thu, 05 Sep 2024 06:59:24 -0700 (PDT) MIME-Version: 1.0 References: <20221112114602.1268989-1-liushixin2@huawei.com> <20221112114602.1268989-4-liushixin2@huawei.com> <3780a622-03f2-4cfe-5705-0e9d0be61d57@huawei.com> In-Reply-To: <3780a622-03f2-4cfe-5705-0e9d0be61d57@huawei.com> From: Hyeonggon Yoo <42.hyeyoo@gmail.com> Date: Thu, 5 Sep 2024 22:59:12 +0900 Message-ID: Subject: Re: [PATCH v4 3/3] mm/slub: Fix memory leak of kobj->name in sysfs_slab_add() To: Jinjie Ruan Cc: Liu Shixin , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 18F1C160015 X-Stat-Signature: t43zmbtf6pmajbm9bq76cddjher1bp3p X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725544766-286071 X-HE-Meta: U2FsdGVkX1+QOv3oLi+2ccT8Tdx2XegH+dKQabF8Ui5uFsHgt6rZV3kpFAsG29qHCAKtjNAyxOPP//flGycQ+XX3kOIxQXJNUlHSVmZY+kfpv/kTX+mzzugq/N6VLZHbzKPCotUk0w0km1cdHH5axsIDHsxVVcuv+JGEO2B8RiW4JeBayD9INNI5NXLHy6PMgtnaoWvI/2zTOM7A9M7GzPo6I29BoK3lpa7D/VnuuKv3Ws1/D+s2eHGo35ChnpX/3odj5McAyp1fp3WabKCLFbFN24XlUZfsizqr7s+hJUlNbXTDFCaIkKrQwOvwQw0hRBJm+pFrc8y0m/CUYwdKl1dU/rE43Vtp+XaqWPeyvC5zjfllUWwAHtYoe9K8OBRI4Dq8NIz2C8ilXlu4/YIGu8oUF5rR9LtPbM5N92tOh/JpedzEYlb6aGUa1vIwFau2I/YEmiXnwzIpolbvO/jthVXTQwQWPMHcFdq7UVdv3ns9Imh5wsnsH6pue6F2jtdOy83ZR7mnlGHKaunB/hSQ2dXZRUSDrqtRxnx5CympSVEW6h7+xcK1SBecstT1DRaFmWgugSwWFnuKVH/1QGQvuJdtmFOK6yqhQUSWjlJ82G8TyzKW0Hyxu7eFzde1LTBdgFoxXVvWgw2apQ4Zh0dJ9iS+pXD7oaC7MoB+HDJGZrSeSFX6czwNd2Wu5hkg7U7c8+f1PLbBTPgmp9zaeEfEnCF5az3vdEi+K8woPc0bVQvW2EC2TrjpoT9p49/jFrEaM7SjjOccuqzB9qTFfmrvj7JMNpLOt+SleXpYKMqZwevx/V3MLokndh+LBhGOlQhAFVV+TTIWsIrND/RZSVbDupP1wXvxOSOZEthK/oepTYIazHf7fxjWSYfgBLbDKHT1vE2ZXfV8LThmf6vxBeqB+faoGKsNWOX83x/dBLZpnaWatta7bsthuJPzZ4BTt5ymP8P3gw3H47Y2drKd8aM +idMAFoT bX0bY57dWgr7SvsziksQn1MmM14SAS/emqV1ecuAyRcWQ16Lm4qTk/E86m3KsHI1/K1YPR/Dl0U+jAVUjJc//Vem3IlMNwqAmZBl6Cxv/xAFjkMjT2QW/EAZ6ITE0nTHWFJh8x2RnPrNiZ4a/N9t/xi98EjKpaveOyRx0lqO10idWAgok7V/OuaLbisOQqdANNPjO/VvZxyLB61H4chqd89srPi7vhukIWSRGN3XTcFw3PWowcBGsxjwqqx7qB5PXF02TzMVKYxIUFgtLrpmkK22nys+GqUMH1dMe4mDXVMi3H15XlA94Tu77TJcaQ9HQW3HXuHsKUU4ll8YWLU3SemQ10cpvwbORjqRVm3BW/m1EMFZytR+WXNG40DQZV/OH9Irae4IThQb6wpvICWns+ZYBYo1ijL4f5oTWn0U6mly5n3Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 5, 2024 at 12:41=E2=80=AFPM Jinjie Ruan = wrote: > > > > On 2022/11/12 19:46, Liu Shixin wrote: > > There is a memory leak of kobj->name in sysfs_slab_add(): > > > > unreferenced object 0xffff88817e446440 (size 32): > > comm "insmod", pid 4085, jiffies 4296564501 (age 126.272s) > > hex dump (first 32 bytes): > > 75 62 69 66 73 5f 69 6e 6f 64 65 5f 73 6c 61 62 ubifs_inode_slab > > 00 65 44 7e 81 88 ff ff 00 00 00 00 00 00 00 00 .eD~............ > > backtrace: > > [<000000005b30fbbd>] __kmalloc_node_track_caller+0x4e/0x150 > > [<000000002f70da0c>] kstrdup_const+0x4b/0x80 > > [<00000000c6712c61>] kobject_set_name_vargs+0x2f/0xb0 > > [<00000000b151218e>] kobject_init_and_add+0xb0/0x120 > > [<00000000e56a4cf5>] sysfs_slab_add+0x17d/0x220 > > [<000000009326fd57>] __kmem_cache_create+0x406/0x590 > > [<00000000dde33cff>] kmem_cache_create_usercopy+0x1fc/0x300 > > [<00000000fe90cedb>] kmem_cache_create+0x12/0x20 > > [<000000007a6531c8>] 0xffffffffa02d802d > > [<000000000e3b13c7>] do_one_initcall+0x87/0x2a0 > > [<00000000995ecdcf>] do_init_module+0xdf/0x320 > > [<000000008821941f>] load_module+0x2f98/0x3330 > > [<00000000ef51efa4>] __do_sys_finit_module+0x113/0x1b0 > > [<000000009339fbce>] do_syscall_64+0x35/0x80 > > [<000000006b7f2033>] entry_SYSCALL_64_after_hwframe+0x46/0xb0 > > > Hi=EF=BC=8Cevery one, Hi. > I found the same problem and it solve this problem with the patch, is > there any plan to update the patch and solve it. What kernel version do you use, and when do you encounter it or how do you reproduce it? -- Hyeonggon