From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CB6CE677FF for ; Sat, 2 Nov 2024 14:51:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5D8A6B0085; Sat, 2 Nov 2024 10:51:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DE6566B0088; Sat, 2 Nov 2024 10:51:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C87D96B008A; Sat, 2 Nov 2024 10:51:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A8FE76B0085 for ; Sat, 2 Nov 2024 10:51:27 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 31DAA12036D for ; Sat, 2 Nov 2024 14:51:27 +0000 (UTC) X-FDA: 82741442574.12.167BD40 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by imf12.hostedemail.com (Postfix) with ESMTP id D84D640012 for ; Sat, 2 Nov 2024 14:51:11 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bWOdr6di; spf=pass (imf12.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730558923; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Kpc7VUTC95NO6QqfOpxmM6Nusv8+4AGbHl4MsY9IjIU=; b=7cxH7F42DZHgChcjZtAdjsBah7QTMfPIE4uekt1nZhkDPDTljGqc9M9gE7ccFXuF075g7w QL8mHhUvkomjkyOhsmBCUIVVokLAxurgvJZke3zV+B2ALQGIEjU4rK9eG3POuymrD8b8eC Lsp4kp+1/wT5TMJh6QtO3mIJnNSSZp4= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=bWOdr6di; spf=pass (imf12.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730558923; a=rsa-sha256; cv=none; b=DgdfISQCvF8MlV2Ura7N/fymkZ/fIvci/2jfuhI+7tAZrUJKwZyZJbwaSFbpYV5+wRT/iu bKLUIVXLhhj6+dBB9HIPpetic9KGXvq71qARiNvpfY1kJq0DNbpa40K8UeXiOyLMqWXSrI 2UClV8fpAy+ie6pum2eG+Jms9eruDSE= Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-539f72c913aso4697758e87.1 for ; Sat, 02 Nov 2024 07:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730559083; x=1731163883; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Kpc7VUTC95NO6QqfOpxmM6Nusv8+4AGbHl4MsY9IjIU=; b=bWOdr6diTJcBmxStuld29hfjFrz7vxipAwgAHz5f8uegvuS04e1pKlhdAloFSUlzV6 ulhGJzEVQCULcN1+wbbfw/uWZluS662jiRISCQ/2u7UXtPv74M/VAyy7EOF0HUE9SEVU 6j8RDJhbMXLU4JpWNspyD41YFHzvdsFbBIbHYjK2Ls653fjGAoDNc6pNyVugHOGqOx8F EyDD+CoUDzrgqOUOAdrFevMGbLrLDqXqSLTPJKO+Cy4QxpU5MmU4ZOHGBq4EOfQfIC4X BeevBXGdO8/khSfJcURQFiHVeocDYPhPiqXuxG3C319I8uhjpZEmsinzDGFm6h1+wnDV CEXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730559083; x=1731163883; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Kpc7VUTC95NO6QqfOpxmM6Nusv8+4AGbHl4MsY9IjIU=; b=qVDWf2yMlynXzvp9nSTbSxI3uPJB7YA3y592Xfnpc3ObRBSkkU2y8qEoxXqJLj0tDp loFf3KbHQrWJBgNc/H3ChRpfkAm9a5BYlupaUK587ECjUTr4zlLXIE9KYRyR0q5vrR3J wJW/nmFvgtpbsQWfUcwiFDiCF8ibSjx6liThQKPRe3A+imZ+uPv+Y4edCLWZxUvIKRE1 RyadjGEH56Po/oGd1kVba+3D4UxzvAusZi28j+LSFZpPaGWB3sLWmxLCfoLhQm6oFZxT idffJKcXWDNWG9WDYawK7ZFfqjkbXApF1bdzIuXw776sg51uuDnDQnmYNP9Nq1vSIyVr L71w== X-Forwarded-Encrypted: i=1; AJvYcCWryxxxqvpvYKZtFBWMeMyw8zfrQGN3ea8938hh1ThCJnWSCbyIFwsmqR/JSJmILqY5tDjXyktxkQ==@kvack.org X-Gm-Message-State: AOJu0Yy+v/49NTqrx3EDhmxlUjqfZmtk5YILqDNy06Lr16DUbv/SzROr V2IfCcrEuEOTx4dTsGncrgdUXyVm6CNHHqPmtSjssZVdhg+hvtBTcrDpxoOYvhvp9/4QajIcmHo GSFtb7Hw/6f/8znjkmN4hAdtLTXI= X-Google-Smtp-Source: AGHT+IGx8QbSNEMeIJ2Jdp9N6/kN15KuQf9h2GTybZlPI8n+sLu9HcFM6sBsdn3ypK7o4lfEZfc+tl7OwiVPPLNepGs= X-Received: by 2002:a05:6512:2807:b0:53b:1671:604f with SMTP id 2adb3069b0e04-53b348d878dmr14578105e87.23.1730559083045; Sat, 02 Nov 2024 07:51:23 -0700 (PDT) MIME-Version: 1.0 References: <20241101130845.19100-1-42.hyeyoo@gmail.com> <35f58f1b-6e71-42ce-8619-2ecd810b4510@suse.cz> <195242b4-5471-419a-a350-08fd246973f0@suse.cz> In-Reply-To: From: Hyeonggon Yoo <42.hyeyoo@gmail.com> Date: Sat, 2 Nov 2024 23:51:11 +0900 Message-ID: Subject: Re: [PATCH v1] mm/slab: Allow cache creation to proceed even if sysfs registration fails To: Vlastimil Babka Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , linux-mm@kvack.org, Jinjie Ruan , Liu Shixin , Christian Brauner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D84D640012 X-Stat-Signature: tg1sbhr543hj4few67pqqkxz5nhpm3ka X-Rspam-User: X-HE-Tag: 1730559071-897273 X-HE-Meta: U2FsdGVkX1+djWlHR9ymnfZ4RGjdE/r9fEeecWaJEzAqPJz3JjsEkqUavd8oqEUK/A1PVkEIUEh1NJ4V8gw2cDHNYSFaEhey8quSaoTf0WkbzKlKZk2gQvxNTX0q1IX2L5+tguo4bQn6zkDHELRsb6ABM2Vz0d2JdZNqX3/6c74DXGD+I6WafIUcd4CCepr+7u8RYsT6JVeukbBqV9ZgTkjtRt9nOyA9YFo1ybYRbbxBJZnyYuUobiMiOBABLmiSNtjFPVq29t2DmGbZl5AS4TrhX2OkWwfI3iFO7KvQiS1gedps+0NGLWh82tUzLzQbY2ODCX5GuhDCTcRqwCIiz3RZpoGO45rx9tZDwxVqgaVBS9jbEbXO4gB8gmp1TLbdKono0Un0vxnkT1SqAgG4y3RyCfGLz1NBLJWkeWMkMCwslGx0aKq4Da2QAa2Ud9gYL68Ua9w87H7lr7z4ugR3oO4K7YWB/JR9qvn/OQmjWmOrURXibBdtNMIe63zWbW0alqC9dEGnOgZL3lmL4C0pdFMGO9isSCH5SKfL+x6IyJfCekQcgRLiIVEvvoUl3Dh+7m19vrt+trepes/PrbVYzn0hdBOGqw6zdE+WLNpR5u/aUKpTtBB+H5CHGNGl9eTARxt5jgqJ0qfWYQa9klbOEBoDe5r3v57R3OcATG8JeA44nC+ATMSztGlVao3kwhkZNGR+OfgRnFH58DoJ4DSJBAJ8rq23otOxE7abeBe/Rc4PK03BbyshsZsyxcYglClVnLlJh0Ce5j7pQzklLoShtvjfdWhlon0LSkTu9lskum7XkyVqOaFXWhHo+HrnTWu5xp4KI2L1vw+NDprkDyUHvdKZcux3kvgf+TAcaPFE4CLaTkOQ4HM4lMSsPEwAHQBCHSDY5t/+AutWCHer3gcO1/L7lJKjqOJ+j91kYmgWOktK6cjKtI2MCpxoNyRAgqduhGNcvxVtdwsg8McYKOK VDcgy30a SDnUSrJGQ7DYspMKNbN5sz43INzhxNoCNPOa8sFQibPCPyIZdGS7pKuJVGRqreyc1hjV9cE0i+YpPHeuh2u5k/PhjjG6nPYmoreR/iZxfC3m82IClClB1ciEqUWkE+1xDp1edD3+/qWkG56nDwrlXsd+oBDnPZOsA+eSAUlp8K/4TM6EaRGnT8t5KblAoZlQ6t1b0k4CxlrCG19thpA92Ry6CgCto5/9r+fXqHHD6jHiSOBvWM7/OVjQ1i+tEHDds9YOBMswO2+Um9/0a+SdlYhP2a5Lw5JNcsksXnlQgaclxeGW8iNlzagDx2PBuYcqgVgwdQitDMzCK8hhYZMUcsE5c6Rxl+8CDaQ3Yj1SAI4BA2luT85uUWi5Z0g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Nov 2, 2024 at 7:16=E2=80=AFPM Hyeonggon Yoo <42.hyeyoo@gmail.com> = wrote: > > On Sat, Nov 2, 2024 at 7:07=E2=80=AFPM Hyeonggon Yoo <42.hyeyoo@gmail.com= > wrote: > > > > On Sat, Nov 2, 2024 at 5:50=E2=80=AFPM Vlastimil Babka = wrote: > > > > > > On 11/2/24 8:18 AM, Hyeonggon Yoo wrote: > > > >> > > > >> Also here, and simplified to "if (sysfs_slab_add(s)) ... " to avoi= d dealing > > > >> with err. > > > > > > > > Oh no. err is initialized to -EINVAL, so that will not work as inte= nded. > > > > It is causing the following list corruption. > > > > > > Ooops, right, thanks a lot. Wrongly assumed that a test boot in > > > virtme-ng would catch silly mistakes like that. Looks like all caches > > > were created with SLAB_STATE < FULL. > > > > > > Fixed by setting err =3D 0 before trying sysfs add. > > > > Thanks! > > > > Hmm... by the way, why doesn't SLUB update 'err' in the event of an err= or in > > init_cache_random_seq(), init_kmem_cache_nodes(), or alloc_kmem_cache_c= pus()? > > I may be missing something, but it doesn't seem to handle these errors > > properly to me... > > Oh, it seems like a recent change fc0eac57d08c ("slab: pull kmem_cache_op= en() > into do_kmem_cache_create()") incorrectly pulled kmem_cache_open()? > > Cc-ing Christian Brauner. Apologies for the oversight; it slipped my mind. It was actually correct after all. :(