From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBCB9D5E15E for ; Fri, 8 Nov 2024 11:13:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1578A6B0082; Fri, 8 Nov 2024 06:13:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1075D6B0083; Fri, 8 Nov 2024 06:13:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F106A6B0085; Fri, 8 Nov 2024 06:13:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CCBB56B0082 for ; Fri, 8 Nov 2024 06:13:37 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 693FC1A0B9B for ; Fri, 8 Nov 2024 11:13:37 +0000 (UTC) X-FDA: 82762665426.03.A7343FA Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf22.hostedemail.com (Postfix) with ESMTP id D8B35C0007 for ; Fri, 8 Nov 2024 11:12:49 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WbFYrhL8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731064244; a=rsa-sha256; cv=none; b=hdf3nM5n9RL1RnOHLGzOM3aWUZi7iMxGng/ERqJgtCcZTqrB0Of5UUW0PtjrRWLH68/xvx A+tlxQjIQD86attChnjMIPhw2SG/AIbSkI+0mXNiOdVgekVYlXsjU1ScKQHkugxTWnQTKH OmHCclj6uZQ9HbrpuqqMtcR+RrNYR9c= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WbFYrhL8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731064244; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vIsavrzOSM4X09h3CcVAQHrpawDz6KtkdvOy2jq7hvM=; b=lU7jWSS4pBg6EF12/UK9gukZo8WIO4A+N0/m/bIbPg5ximQXyaC8XZgl7X0V8GMEz6vEIC ToTLc4kRsM3R8MxpXNCUiXBW+ATU2dlkCCmpjaJkIyELN+FZlveC86yqXiQQiXqPOfZofl WcJzEG+KEx2+GIfl2ASEtVV95O36jpc= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-539e63c8678so2204538e87.0 for ; Fri, 08 Nov 2024 03:13:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731064414; x=1731669214; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vIsavrzOSM4X09h3CcVAQHrpawDz6KtkdvOy2jq7hvM=; b=WbFYrhL8CbyW4K8g0mBbe3Vvu5aM5jJm80AXK4pqKrGPiWi2S7pFqNQKIvYZ+iejX8 lHqa/NWBZYpI+nnjB481eOzqnpwXXGB0gXHC2Cw81PibxzrZLHxIjYaogHrZyG1i3+/5 pM47AHInxhg8kxs7E0qm17Vv56ePGunjpNqSWgDqc+6QpMWJg7zxFvraFP7Kxq80z+b6 1AoJfj5jm1R8WFSoFh2u4+9TTs9Z1nxFCZcNjooLvcq0aPegeaEb0HhDK02evrgp00WP SRIG7U2d29ZM7I/7x/4Sb/LYyo41FM/8fkSsE5cPr5HaUiLEi9jMJ7OSwgcCdcmf84Js F0Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731064414; x=1731669214; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vIsavrzOSM4X09h3CcVAQHrpawDz6KtkdvOy2jq7hvM=; b=nU1qHSZXXyGDd/jceYXQ9AXeQmEuDroA23AlTz8FaS2rgxOpE0Cxf3qqJh96qeVReI Jh3AZzPhkdr9HIjvm28vhTqfZppAopKYQk+nBPXdOdeC+7MVOb+W7BWy8+PAqrsNVxsb CJRhJwAi4tmozgMnnnzWrSG/AM7BMOAZxo0TjCWx1eVncvdJJS5xtbHNakYFalCcaXkK tEAw7eZ6BB5ygEdp2Io2E8hMRvOgiuOzgbXSv2fsdyH6uHIy+jQEDTPnaCRynktrIiMx CH8a/cdsE5fxhKY5BrxwpcrtsZvvRiuxEI9HpT8njWwKFhFefrt/AQR3ZkKujD31wxcB CiPQ== X-Forwarded-Encrypted: i=1; AJvYcCVutEPhWcKaVaHbqeV66KvLgQTzRR4VQiawD0xzJa6FzBVHEWBk2wawRn7ZU9z6x8ToUJ2J/BEXiw==@kvack.org X-Gm-Message-State: AOJu0YwKqresa2/E26Hys0nu4OgNC1yAhXTXF+k3zxmmZtB/++QMVxNK nx2wPV+kxamgB7v3ztqg/WR69nLmTzG4kUC2knbCTmD7HyH3ssuJhef/PwDHr7sZIElpI9Uvw/6 CcaiCQnT0K/4OkJAx9uPd7H21ecY= X-Google-Smtp-Source: AGHT+IHbVO3SHCJUHoOfL9vsbeQeaoud5VvmUU5eZCLCB1lxldtz7zSzwGqPPgPJzPCfgLlcl3JuLlvqKx8e8virIEs= X-Received: by 2002:a05:6512:2311:b0:533:43e2:6ac4 with SMTP id 2adb3069b0e04-53d86302e9fmr1312808e87.49.1731064413461; Fri, 08 Nov 2024 03:13:33 -0800 (PST) MIME-Version: 1.0 References: <9c3fecc3-19dc-42d4-6c89-4a48e9ad19cc@redhat.com> <5a1e67c3-481e-4c6e-8507-5a8ea0bd9f28@suse.cz> <27ba7473-9255-2407-8e4e-e5c3cafc25c4@redhat.com> <58fce0d4-9074-3d98-5a1b-970371f0c23c@redhat.com> In-Reply-To: From: Hyeonggon Yoo <42.hyeyoo@gmail.com> Date: Fri, 8 Nov 2024 20:13:20 +0900 Message-ID: Subject: Re: slab warning: kmem_cache of name 'dm_bufio_buffer' already exists To: Vlastimil Babka Cc: Mikulas Patocka , Pedro Falcato , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , zkabelac@redhat.com, Roman Gushchin , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 1fc6ep8578sbjdgckc34tmrw1cbignon X-Rspamd-Queue-Id: D8B35C0007 X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1731064369-855238 X-HE-Meta: U2FsdGVkX1/5RKQc3xsA8AEWuEwdNyme+jIK8Dl9h19BqszDs8aSzX3NbO4eli6J0WPSSOKZ1fKkmsB2kdB5Eh/jjCyS4O+55Xn4kt73NecCuqHFTbFXTYf8HXghqDhGEFm3Y8Dq1/uONe3cj9lDThP1xLXx4WwQ7ReHmrmg+DH7NVitJM91d9cVDy0G6HQDSw++AX/5zNVK1EdZGL0mgPpfsXlX3p+zVRQpw+Akor6JDTiX7cuKIrCBjydGmqTmhQQ0egxOVVlpN2dmcDJzsLIP9/Bo1PkvFQ08b6lFX1trC/M73WyYaab4NmHgtdx5qKAL7+HLDmH7fZuYEElgnJYWGDVfDOMegzOT1zYJgkDLSPs5tr/ibF+gAFhiVR/qDoSXgKYninaUnwpr41yc2d8/xbn0au3AXBUraD8mmgmH5uOty5wAAOaJnsyrBIN9bfP1+Jq537TyLmEm2tUCKdBrMD/nm2QzqWDy+/1zhCnTYzyYUUTY3XffQZjRUfdE/icNFfWeaIZ84I6J617y3F2kYDu0hPyYPaMUhnEGnJs/8nE8vjVGP72KYo6pE6iu6qyW37yJ16+3UU7oJj3y84fN8YA+E41Rw2ad290Yj46xWguMfvkvDLZk/vHYjZeU9uuCpxaDSfX592j8ouEEMeT2Bm/jg5ZG18gDIEUqhemggfz6EcJigJW6ua0+ySjHQQZhawzpgV9CdtCczpg8AON04ULHzR592+X7en5Hba+zzLiRnavG344+vlVA5duSmPL3A2wmis2k+8vvVo5dqI/RE++U+59gAFerIYyGxIznBFJOkJOC2SOcECdC7AsZVSRsW3BPCkZGw+btszx3aRTRiz4y2SdT02UQIfM5x3inoBiWKl+VZ/xhmyKHcqqx0g2b2O4Jb4/nX7547+VukdDjYJ0z8ZC4OPEe61TScivyTETgkstiwx0AQEsJTZ+hUuhyUarzPa2n9kih0t+ 0rrDkpo9 4begGDO1m/KHA84x/IhUZk/11n3V7Hr/pLYICPS0BaKSoLLaUHePj0WLFnbpD3KxlMQCOvvBKJLf3dtc1l4clEL7aHFfs8u9W19lKqsCfQU5YI8FLW7ZsGug9uoqB3bxzMeJbogxqoFTm2SvGa7nvSj5aDGako13WbRBIuwHLf+I6lSXVk+MXCuSQy0Tf6lt0vEhrGHB5puc11YB7fUE7wdz9KWM8/BreKftQiyfEdOFEs9tmFtxMhw8uQXe72TuXdk+xowmmtBx9j2kUX2EE2LwVkNrSHlqQbbQTA0nDFX/htfoula39lbqPtUjfg4KbKq2/Gfw/fWlbTg48lftJ4wosAEHdGlQkx68IUyXpn1sn9sYDUD/oawo8ymDIFEKmp9oITcaJCXvMkaxVRR7l6POZS/f5HXxr8gI6ZeiQzAQPkaRGLU8O7dL3nNdmt7paih6eraMp1oViiSf1xgb2PlXu/g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000085, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 8, 2024 at 6:56=E2=80=AFPM Vlastimil Babka wro= te: > > On 11/6/24 22:22, Mikulas Patocka wrote: > > > > > > On Wed, 6 Nov 2024, Vlastimil Babka wrote: > > > >> On 11/6/24 13:05, Mikulas Patocka wrote: > >> > > >> > > >> > On Wed, 6 Nov 2024, Vlastimil Babka wrote: > >> > > >> >> On 11/6/24 12:19, Mikulas Patocka wrote: > >> >> > Hi > >> >> > >> >> Hi, > >> >> > >> >> > The commit 4c39529663b93165953ecf9b1a9ea817358dcd06 ("slab: Warn = on > >> >> > duplicate cache names when DEBUG_VM=3Dy") is causing large number= of > >> >> > warnings about "dm_bufio_buffer", "dm_bufio_buffer-%u" (and other= ) device > >> >> > mapper caches. > >> >> > >> >> Hmm wonder why nobody run into this before. We thought the code tha= t would > >> >> cause the warning would be all fixed before introducing it, but we = missed > >> >> some, sorry. > >> >> > >> >> > I'd like to ask - how to properly fix it? > >> >> > > >> >> > We create a "dm_bufio_buffer" or "dm_bufio_buffer-%u" cache with = every dm > >> >> > bufio client. It used to work (and the duplicate caches are merge= d), but > >> >> > >> >> Note the merging can be disabled so then it's really several caches= with > >> >> exactly same name in /proc/slabinfo and inability to create their > >> >> sysfs/debugfs directories. > >> > > >> > Would it be sensible to allow merging caches with the same name and = same > >> > attributes and only warn if there are caches with the same name and > >> > different attributes? > >> > >> We might consider that. > > > > That would be good - so that users don't have to write their own slab > > cache merge logic. > > So Pedro, wanna do that? Or Hyeonggon maybe? :) IIUC it would be a special slab merging logic if the names and attributes match, even if slab merging is disabled. Right?