From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 010EFEB64DA for ; Thu, 20 Jul 2023 13:47:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B8EF28010C; Thu, 20 Jul 2023 09:47:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 267FA28004C; Thu, 20 Jul 2023 09:47:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12FED28010C; Thu, 20 Jul 2023 09:47:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 03CD028004C for ; Thu, 20 Jul 2023 09:47:07 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BF8DD12015B for ; Thu, 20 Jul 2023 13:47:06 +0000 (UTC) X-FDA: 81032116452.20.63BE5A0 Received: from mail-vk1-f181.google.com (mail-vk1-f181.google.com [209.85.221.181]) by imf25.hostedemail.com (Postfix) with ESMTP id E557DA0018 for ; Thu, 20 Jul 2023 13:47:04 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=k8hzU5f3; spf=pass (imf25.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.221.181 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689860824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y/KzGUPV+gRIoFyLtOO+EoChD6058pkzNkr89rkXrzY=; b=um425JCxuiWCFsr1ZXsoh7bM+0Schi1egecHZ2vCWbMpnMQSBNyvlJG8c3x6M9B2uZGyVU uaPShRWYCpTIZYQuaHx/apKQ/ZP8ZVTpCajBCqmZbMq04C7EjEmZVmCYFyqrAgvHBoNqZR YPIHtWGYQVzitLfpBlR5n/XcVv9a1xA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689860824; a=rsa-sha256; cv=none; b=0Iw5bQj1Vz3uKDCm/v5u55AdhHafi7uhdtkUUa6K97ecMTMpRddXXa9vAIrF+3x8ZHU86B 9qMGKXWI057/nbjf/HPmmGz9gLsDAEGX2yT+dijeuXfLh3amFoRN+2A42Ic4doF8LGm0By 6D6Kbz9Na/AmgaD0lJ8/czQr5BJy3TA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=k8hzU5f3; spf=pass (imf25.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.221.181 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-vk1-f181.google.com with SMTP id 71dfb90a1353d-4814299c981so363933e0c.0 for ; Thu, 20 Jul 2023 06:47:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689860824; x=1690465624; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Y/KzGUPV+gRIoFyLtOO+EoChD6058pkzNkr89rkXrzY=; b=k8hzU5f32OK+nRBlMQj62JtuATPqhubzrc5L2RELADpAANLjkncROzrP2NuRTibSxc Tb8rGJMCn15CjbKw5c5laQhuiFupJr4qYdRM+1qzOWTQwR17hOywEcQTv7qzZpv5Kgtq Kw82IUcxsCJ5VpJfABxVUulbQiSfzUpckoo5wYAL4sfBluPf6QtZiRJPE4N4YLeaDO4B UPlW1LXsggBaZkAc/vETtXP4VKbIYqN5lSmNEjhRJkDOoNHGjk9YGD69gYwxZs3vopNR Jq/BvLp1MbQ0uFolMFAt3soHoA5qAu8SbzRvF8fdAMj62uppFHspA/bUimeXYjutQ+te aI0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689860824; x=1690465624; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y/KzGUPV+gRIoFyLtOO+EoChD6058pkzNkr89rkXrzY=; b=PPivDe/jqHcFoyqgrDjl3TINMDC35HK/ZHPmgukfSxGZ6mcJTXHSRixVLP9Z5XduAt 6M9OYawhuZgD4nSbUVlINFywEfV9cCabxJKqQX0l52kFHgqENKnCY5Jr/nrUrRzH2YLA PzVPphFIMaSgzaiC0ucDjci1HqkGI0E9I0B055gzXhPYCN60LT/r1GnANZvsTk/BS6Wr lkK6/pt02BySLXlAeMvxym2DexrC8DiebNY5plFve6w1RWDmHutAZyC1XpkDHactDVW5 PAV9+HWbvsI2m0HFX1RlmmXu18YrBJWxsgKhLRcNCEjb6gbgPS0htQCMzwH42FiHaJj9 vPMg== X-Gm-Message-State: ABy/qLaFXYz8jlTHtfxA+JfHH+NBZn1+DgL5RdXltgAyiCS2jIJzhUMi 56T512A+woBLtqSedfna51YiMGanmHw3HWM9+hA= X-Google-Smtp-Source: APBJJlGpznh68/APdZ9brOuv7vnzzwzJfPIpxpcjgys5irqfGmvSReUPuIi7ZQ8yi1+M2560n/TLl4FN5ZvPHeg5QDI= X-Received: by 2002:a1f:5cd7:0:b0:483:9adf:af19 with SMTP id q206-20020a1f5cd7000000b004839adfaf19mr6230502vkb.2.1689860823787; Thu, 20 Jul 2023 06:47:03 -0700 (PDT) MIME-Version: 1.0 References: <20230628095740.589893-1-jaypatel@linux.ibm.com> <202307172140.3b34825a-oliver.sang@intel.com> In-Reply-To: From: Hyeonggon Yoo <42.hyeyoo@gmail.com> Date: Thu, 20 Jul 2023 22:46:51 +0900 Message-ID: Subject: Re: [PATCH] [RFC PATCH v2]mm/slub: Optimize slub memory usage To: Oliver Sang Cc: Jay Patel , oe-lkp@lists.linux.dev, lkp@intel.com, linux-mm@kvack.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, aneesh.kumar@linux.ibm.com, tsahu@linux.ibm.com, piyushs@linux.ibm.com Content-Type: multipart/mixed; boundary="0000000000001f3de90600eb622a" X-Rspamd-Queue-Id: E557DA0018 X-Rspam-User: X-Stat-Signature: tac91akbes373uny7xe8aqnpp5cuw9qg X-Rspamd-Server: rspam03 X-HE-Tag: 1689860824-358234 X-HE-Meta: U2FsdGVkX1/AgOdql1PX6+cBAFgfQPY8ZaJOmwEE0PtrvRBXGpv+GfSLrvTKArz2CP8hr06cmLuIaDdCkF4uc/UdIuTkAic4HL39Pfzbriaw5O59rZl/XSrgMGu4yorKCqeHB7B5ltkhOMLxPN+M/oODKflr/JqH2llrd0En9/XG+tASAU1SnFXPAYbgxN5FbkxVkK2R0eJHZRiEdyo+UN+qC7GuZ4t5AeORJowewMWGkCDpYKV+f5JfMNv1ed3xjw3wEQTFXMccz+e/JCF9iE07L//FKme6b4lEYacKJsVVOMSeY3HOPncRGQ/eidFMlq7SRQK2FByG6L0zU4Doq2F053E7tJuDu6LlZ6HagPitHwujDQQfd5UWstYcAYe3o/7xwHX47dI629w0f/6KA/VyXAyEpoISQQKNMKJIK2b6oyvyyGNgYLtaar5pdvfkfVUW0CeXVgX287zzwQZxWdKJlxkMWcAjwBhYaYg7cubZIJr//Y4d1UlDt2fo+/g2sYhIJ8uJGjDzOpZMDYf0CPkF+tZ3ByTIM6ZzmqJf0kEMIp0eEqaoGaozqhvsK9Dt/lFHZTyQVEIpl8AAFPIIBnjpNf1eIuryaW1quGCGYJotU0lG/k6UIM2Es7FOTbjNCw8aj8ieXXilaYw47EjJKfQtqv5MW3d9dmTA2+0yPqi6PGeJ5fR0/GI0lHT+BR+UsUQhbjnmyE98U2PHear9vT1YbXz6+rgKz5d7lW+XwtGNAE2563UGjgmEgtMM2RYELrZ8WADgnrC4MkzDqr7GqE6P43eInsgV/KrV5TROG+ifDL41Lk1YBnnThG/gQYVLaLI7Ybyf0919GO2TJcbwCdbcY/tqE5m0wJf697eXuEONudeftxd1OCMSxYTrkYybHGq+Vl3R2o3HsBkmFcQ5liKBxXqdpAor0xBOvJK+GKFaIfArfPS/6UjPcfi58EWeh7OQNQt285+bzrC8nGV RT57R0+v iJUiJrWmnShQaqUuxhZKwIrXI6MoOuDVIMlXHkYIwWclhb0B6ah20hitqEtLndocsiRJBWcYt7j1v8E4LYVe2ak9GOIArfDA5xTuBSqLBRUu9o9apGyOjKcJ0JaLj4Iyf58N13YXD2DUWbchVpBRIWMc63Q2tibNDQ3/9k4azH1W9GYcoWeZOPRoK14iyDNEV10w7CFqvy5BvMQcLhc+P7/JSLQMGyH/BDlYOqburJIeu3LxKlHxJHm+cZv0TEdbvA8w2Nt6bHr4VhVgfdSvvpCu+AVcmdc4f+vj5aIve6x4sRZDSHwxdraGpohQr/mrRCVznjZJM1hwevEEGCf5GY+Z1OiXZlCvTYfaiUsKLHopBVqXUGkEgykzPmHBlm8Zlva0uqpM+SY6ku3h6W5M2bleYl3REi3YYmpW2ooSjr4iurzUh9TfP6snjqg50QuS+fweewugx1Q96xjWuIyS6MS87H1nYWteNytDm0Ch5Ubz8mC6PwPDThiJNP9V2xJOB45n2YvGNd/Nmhhd2AT8FcXOyOusaHS2+LbgSKrT3w0MKzzGpPYzZ9QrF+tUgxBQho4/pn01VvkkTU/jak40XsEeO3WDPmvJBxZ4QQYu15qFTn9pMx4p1b+wZ2wV5CZswBHEVc6USYSQiXqEEpWcakdfG9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --0000000000001f3de90600eb622a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jul 20, 2023 at 9:59=E2=80=AFPM Hyeonggon Yoo <42.hyeyoo@gmail.com>= wrote: > On Thu, Jul 20, 2023 at 12:01=E2=80=AFPM Oliver Sang wrote: > > > > commit: > > > > 7bc162d5cc ("Merge branches 'slab/for-6.5/prandom', 'slab/for-6.5= /slab_no_merge' and 'slab/for-6.5/slab-deprecate' into slab/for-next") > > > > a0fd217e6d ("mm/slub: Optimize slub memory usage") > > > > > > > > 7bc162d5cc4de5c3 a0fd217e6d6fbd23e91f8796787 > > > > ---------------- --------------------------- > > > > %stddev %change %stddev > > > > \ | \ > > > > 222503 =C4=85 86% +108.7% 464342 =C4=85 58% numa-meminf= o.node1.Active > > > > 222459 =C4=85 86% +108.7% 464294 =C4=85 58% numa-meminf= o.node1.Active(anon) > > > > 55573 =C4=85 85% +108.0% 115619 =C4=85 58% numa-vmstat= .node1.nr_active_anon > > > > 55573 =C4=85 85% +108.0% 115618 =C4=85 58% numa-vmstat= .node1.nr_zone_active_anon > > > > > > I'm quite baffled while reading this. > > > How did changing slab order calculation double the number of active a= non pages? > > > I doubt two experiments were performed on the same settings. > > > > let me introduce our test process. > > > > we make sure the tests upon commit and its parent have exact same envir= onment > > except the kernel difference, and we also make sure the config to build= the > > commit and its parent are identical. > > > > we run tests for one commit at least 6 times to make sure the data is s= table. > > > > such like for this case, we rebuild the commit and its parent's kernel,= the > > config is attached FYI. Oh I missed the attachments. I need more time to look more into that, but could you please test this patch (attached)? > 0.00 -100.0% 0.00 numa-numastat.node0.interleave= _hit > 646925 =C2=B1 26% +25.4% 811509 =C2=B1 29% numa-numastat.node0= .local_node > 693386 =C2=B1 20% +30.4% 904091 =C2=B1 27% numa-numastat.node= 0.numa_hit > 46461 =C2=B1 81% +102.6% 94126 =C2=B1 31% numa-numastat.node0.= other_node > 0.00 -100.0% 0.00 numa-numastat.node1.interleave_= hit > 1571252 =C2=B1 18% -14.3% 1346549 =C2=B1 13% numa-numastat.node= 1.local_node > 1663884 =C2=B1 16% -16.3% 1393406 =C2=B1 13% numa-numastat.node1= .numa_hit > 92593 =C2=B1 39% -49.5% 46769 =C2=B1 61% numa-numastat.node= 1.other_node After skimming the attachments - started thinking that it is undesirable to allocate high order slabs from remote nodes. --0000000000001f3de90600eb622a Content-Type: text/x-patch; charset="US-ASCII"; name="0001-mm-slub-do-not-allocate-from-remote-node-to-allocate.patch" Content-Disposition: attachment; filename="0001-mm-slub-do-not-allocate-from-remote-node-to-allocate.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lkb70bdj0 RnJvbSBkNjg4MjcwMjc0ZmViZjQxMTVjOWMyODcxMmQ4ZmYwOGNhMmJlZTFhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIeWVvbmdnb24gWW9vIDw0Mi5oeWV5b29AZ21haWwuY29tPgpE YXRlOiBUaHUsIDIwIEp1bCAyMDIzIDIyOjI5OjE2ICswOTAwClN1YmplY3Q6IFtQQVRDSF0gbW0v c2x1YjogZG8gbm90IGFsbG9jYXRlIGZyb20gcmVtb3RlIG5vZGUgdG8gYWxsb2NhdGUgaGlnaAog b3JkZXIgc2xhYgoKU2lnbmVkLW9mZi1ieTogSHllb25nZ29uIFlvbyA8NDIuaHlleW9vQGdtYWls LmNvbT4KLS0tCiBtbS9zbHViLmMgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24o KyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9tbS9zbHViLmMgYi9tbS9zbHViLmMKaW5k ZXggZjc5NDAwNDgxMzhjLi4xZjI1ODg4ZDlhNDEgMTAwNjQ0Ci0tLSBhL21tL3NsdWIuYworKysg Yi9tbS9zbHViLmMKQEAgLTIwMTIsNyArMjAxMiw3IEBAIHN0YXRpYyBzdHJ1Y3Qgc2xhYiAqYWxs b2NhdGVfc2xhYihzdHJ1Y3Qga21lbV9jYWNoZSAqcywgZ2ZwX3QgZmxhZ3MsIGludCBub2RlKQog CSAqLwogCWFsbG9jX2dmcCA9IChmbGFncyB8IF9fR0ZQX05PV0FSTiB8IF9fR0ZQX05PUkVUUlkp ICYgfl9fR0ZQX05PRkFJTDsKIAlpZiAoKGFsbG9jX2dmcCAmIF9fR0ZQX0RJUkVDVF9SRUNMQUlN KSAmJiBvb19vcmRlcihvbykgPiBvb19vcmRlcihzLT5taW4pKQotCQlhbGxvY19nZnAgPSAoYWxs b2NfZ2ZwIHwgX19HRlBfTk9NRU1BTExPQykgJiB+X19HRlBfUkVDTEFJTTsKKwkJYWxsb2NfZ2Zw ID0gKChhbGxvY19nZnAgfCBfX0dGUF9USElTTk9ERSB8IF9fR0ZQX05PTUVNQUxMT0MpICYgfl9f R0ZQX1JFQ0xBSU0pOwogCiAJc2xhYiA9IGFsbG9jX3NsYWJfcGFnZShhbGxvY19nZnAsIG5vZGUs IG9vKTsKIAlpZiAodW5saWtlbHkoIXNsYWIpKSB7Ci0tIAoyLjQxLjAKCg== --0000000000001f3de90600eb622a--