From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5034EC43334 for ; Thu, 30 Jun 2022 14:56:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7987F8E0002; Thu, 30 Jun 2022 10:56:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 746808E0001; Thu, 30 Jun 2022 10:56:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 635258E0002; Thu, 30 Jun 2022 10:56:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 53A108E0001 for ; Thu, 30 Jun 2022 10:56:23 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 134E835545 for ; Thu, 30 Jun 2022 14:56:23 +0000 (UTC) X-FDA: 79635203046.23.7F825B1 Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by imf31.hostedemail.com (Postfix) with ESMTP id 9A2D62003A for ; Thu, 30 Jun 2022 14:56:22 +0000 (UTC) Received: by mail-lj1-f176.google.com with SMTP id by38so23424701ljb.10 for ; Thu, 30 Jun 2022 07:56:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ipNBTkHp2jS0+JttebnQfFLWG27OJJNBttsPzJH3qb0=; b=pgF8MbXGCCzbjeNDnKq+15lZDcZpjlPbZ133zcnyP2hhvSfUAm6yVILAKDi0XiiMcI yCFUl0kRtXWtS3przUPtG5c3sWlxKkM63L5r3UEA0VKoNsXCjfTR/HULCXz8K4OkMvnd tJFt94a2qUqPLZ5CpF60K5NrAp+5bTlP/gZkh8ub4itlVXmihRdUYhnTtvY8AGiQdbY/ lF0XeNS2A/mxvuwTNT/2zZcfYVZiZiuYeYFRczsjPquKw/KMMjYZiiD3sI1pFg+Wi68M RKRtDhM93zoHtABy8UsTOs32gguu+E/BaH8wy/56KtZBpYBFfdQ3LEyM6U52wT+lHLIp r3pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ipNBTkHp2jS0+JttebnQfFLWG27OJJNBttsPzJH3qb0=; b=0HDjbfIqAE5xrgj9O5QyJItlmubI3JF2lVo06qT8wpvO3S/x3XbZ4PU+a0SDVL8jmZ vTjLe870AyyZydD/dnXK/lr0Wa/PathhkoEHCUpYzPj6+ollu5YqjL25htO7pGCulPPu fbUG3ZDJ9meaVngTTtWRD6o12jnnJ4qQUy96WSZvmUemUd+5IExnydCHAvCeFvvqn0WI D59ow/MhfJVTMAmhDR8WdPPo+Bb8iV7yH6QdFQ+wGm9Xaf4feP8/1WIM85ZJA5TEBfdM nTAp1B76NHUd6hdUQ0RHUMH4NCZ7+vdj89LdXF0sDB+VuoVKOQ4ECCkcdtiQA2WSuci2 +02g== X-Gm-Message-State: AJIora8/yM+Cn4oZgLtG+JCiliUo4+tz0ljhKsS/8psAL8Wta/etq4G9 ksifeB1ladGhHSMDE7qZWwUX1JaZqw7yuIC2FCI= X-Google-Smtp-Source: AGRyM1vxz4+4rQNp1pA9fie+azvy7uthbp37IA/SFg0MMtMDSSosZP+hMp47O1t6HsCrfg9y0DOhPh2xDOKHRWHXWCw= X-Received: by 2002:a2e:804b:0:b0:25a:7502:6bd3 with SMTP id p11-20020a2e804b000000b0025a75026bd3mr5428568ljg.455.1656600980868; Thu, 30 Jun 2022 07:56:20 -0700 (PDT) MIME-Version: 1.0 References: <20220630014715.73330-1-feng.tang@intel.com> In-Reply-To: From: Hyeonggon Yoo <42.hyeyoo@gmail.com> Date: Thu, 30 Jun 2022 23:55:59 +0900 Message-ID: Subject: Re: [RFC PATCH] mm/slub: enable debugging memory wasting of kmalloc To: Feng Tang Cc: Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Linux Memory Management List , LKML , Dave Hansen Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656600982; a=rsa-sha256; cv=none; b=6FTyognomi/g1dptVaywJYPx7BXrM9sauZ2iKK8z7lDGul3oHEHCxJIrdO6akmA+W4SNvK 6fgAcOkOUFqNxqe36eZOl/xisV1R+FJBlOAWi/XtA8byAxnZbW4b/TPInnPdTanc6wrx9n slbAJWkSOHcj0eebIEk4Q2NNl0ylQzE= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pgF8MbXG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf31.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656600982; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ipNBTkHp2jS0+JttebnQfFLWG27OJJNBttsPzJH3qb0=; b=rk3oyNLUvioPvZXjOuQrRHUCZUxQZFo44PMGhGGlYOJFBXLz/I405GiUqoQBiExAhY4rnW Vbb6ss03jA9817oaJOCI+UrC2U/ysWh4BJ8m7sm/vVsya/3og3MBgb4mzFm5p/nY9+yzbe +BecYF2+1xtRSHd6Dw1/QDSiZTKmd7I= X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9A2D62003A Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=pgF8MbXG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf31.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com X-Rspam-User: X-Stat-Signature: ihihzxnhxfkjxtzdibrhcnergu84cnad X-HE-Tag: 1656600982-307065 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 30, 2022 at 11:38 PM Hyeonggon Yoo <42.hyeyoo@gmail.com> wrote: [...] > > @@ -5138,11 +5146,12 @@ static int add_location(struct loc_track *t, struct kmem_cache *s, > > if (pos == end) > > break; > > > > - caddr = t->loc[pos].addr; > > - chandle = t->loc[pos].handle; > > - if ((track->addr == caddr) && (handle == chandle)) { > > + l = &t->loc[pos]; > > + caddr = l->addr; > > + chandle = l->handle; > > + if ((track->addr == caddr) && (handle == chandle) && > > + (track->waste == l->waste)) { > > > > - l = &t->loc[pos]; > > l->count++; > > if (track->when) { > > l->sum_time += age; > > @@ -5190,6 +5199,7 @@ static int add_location(struct loc_track *t, struct kmem_cache *s, > > l->min_pid = track->pid; > > l->max_pid = track->pid; > > l->handle = handle; > > + l->waste = track->waste; > > I think this may be fooled when there are different wastes values > from same caller (i.e. when a kmalloc_track_caller() is used.) > because the array is sorted by caller address, but not sorted by waste. > > And writing this I noticed that it already can be fooled now :) > It's also not sorted by handle. I misread the code. it's not fooled now. the array is also sorted by handle. But will be fooled after this patch. > -- > Thanks, > Hyeonggon