From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC9CAC32792 for ; Tue, 23 Aug 2022 08:38:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4AAE96B0075; Tue, 23 Aug 2022 04:38:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 45A258D0002; Tue, 23 Aug 2022 04:38:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 321FF6B007B; Tue, 23 Aug 2022 04:38:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 242956B0075 for ; Tue, 23 Aug 2022 04:38:04 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C73F3C1462 for ; Tue, 23 Aug 2022 08:38:03 +0000 (UTC) X-FDA: 79830204846.05.6690A7F Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) by imf18.hostedemail.com (Postfix) with ESMTP id 73E971C000F for ; Tue, 23 Aug 2022 08:38:03 +0000 (UTC) Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-335624d1e26so361032087b3.4 for ; Tue, 23 Aug 2022 01:38:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=y2+gfSM2pVPpDUIFDptSeizvM7Y4XC7yjqvLtiCZN3I=; b=IHlPVquiuZ906a77Ewu9nBq5xEoT22M9O+IkdFA/5OREtwtoXe/FJVKv9yNBqjKrcF 06DqztKqt0GY1oqa0NmpJpf13Lk36/LWlK3kt5OSrEfhUp7z1povhqQmlbr4fEvNhXwS QeJO/bNa4TCrVQy4VbzMMOtLVOXpsJz25LfzBe5V6JG0oY/mTEzkD1qcykJCtjcVtBP3 wyxgVQLDl/BhPn2UA0Hu3t+eP/pSWHouLIm4kfJxOHLysWKgrqpK1oZ8cCOq3U04czCN pVV0H8KvkALznMgqxvqab5t9uDV+wWBUnn+q+JLkKMTC7EaII35I4PdaTBKIFkdaTxqV 7OHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=y2+gfSM2pVPpDUIFDptSeizvM7Y4XC7yjqvLtiCZN3I=; b=LwPh+bH8XZQTaqdFNT/rjea1S7Ii2f4YWZD0YrqEQdqp7WHQzFhaw6KOQ3u9rSVpra zS8gc4ktLsqg2Fv1np15QybJM88i3Rsk9GDOYsMqgXwhT6DL1bFI8KmNvHJ5O3xl7RDj /VUK/WkQOGZagS/t+SyIAcLvIbuxBAlV482rie8vFlPV8VCktU8y73ZsrP0MansWXz/D UEbqjncxuRvjRcc7rTsN5eMlzfciisK1NVTV0uVX3wzuxjUwrHABeyHoMDHPDqvzGw26 QCTkigD3cVrZbZ/IlmmG1HvIgNCd2+er0F2IwFSy4sA528J5p/Yf3iAuyZfhUWk5RCAZ 7khA== X-Gm-Message-State: ACgBeo1MQcGaI3aNHOAFUoImf7NJg6srBZaJtlRKtDtxENzjRo0bhMD7 E5jAIpmDelSfheC+Y2feTicoeUVpRt75UrALSSM= X-Google-Smtp-Source: AA6agR5kGbjVmGG2C7E8Qj7w6pmadVoVwDHdD9GogfriKvIyHwsz0ilIgqyAykJHqtKT30QMomIeQCvN01/XrXc1ipk= X-Received: by 2002:a81:7c2:0:b0:335:90cb:1962 with SMTP id 185-20020a8107c2000000b0033590cb1962mr24531628ywh.173.1661243882670; Tue, 23 Aug 2022 01:38:02 -0700 (PDT) MIME-Version: 1.0 References: <20220823075241.209009-1-ye.xingchen@zte.com.cn> In-Reply-To: <20220823075241.209009-1-ye.xingchen@zte.com.cn> From: Hyeonggon Yoo <42.hyeyoo@gmail.com> Date: Tue, 23 Aug 2022 17:37:50 +0900 Message-ID: Subject: Re: [PATCH linux-next] mm/slab_common: Remove the unneeded result variable To: cgel.zte@gmail.com Cc: cl@linux.com, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ye xingchen , Zeal Robot Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661243883; a=rsa-sha256; cv=none; b=mlQT5veKeFCilG96/KZRLQfvxYasmOitBliXgrktZORhhDrCYiZWnuLbDa00dDrsmkDRZD 9ux0xL03tntrw422hHlZ1R+ToMJbaFzhUbPmm8Klvuv5O6JTrTYEoaYmSbS4wRrRdXvbMO S0cdRwqo0OkugXU8fRltv+EiF2rSJ/g= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IHlPVqui; spf=pass (imf18.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.128.181 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661243883; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y2+gfSM2pVPpDUIFDptSeizvM7Y4XC7yjqvLtiCZN3I=; b=Y0g0D5BaxEaSOMU/nybc46hcojhUHBTAycnNPS77m8QWCtf60zcgQIeP+8iRoE22/WVnRH 8Hm9ZfWmKzPdFiSIpzp8bOoMm9iUjndpRoggppW+DHbw7aIKjUk6l+JIpokH7Vr7ZpJ6+o iLbrMSuNQkP+97kmPgCL1Vpc5iOEFPI= X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 73E971C000F Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IHlPVqui; spf=pass (imf18.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.128.181 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: 55fgq8wu96dwg5phuoe883pqtipupphk X-Rspam-User: X-HE-Tag: 1661243883-217287 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 23, 2022 at 4:52 PM wrote: > > From: ye xingchen > > Return the value from __kmem_cache_shrink() directly instead of storing it > in another redundant variable. > > Reported-by: Zeal Robot > Signed-off-by: ye xingchen > --- > mm/slab_common.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 17996649cfe3..0dfa3cfb6be5 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -495,13 +495,9 @@ EXPORT_SYMBOL(kmem_cache_destroy); > */ > int kmem_cache_shrink(struct kmem_cache *cachep) > { > - int ret; > - > - > kasan_cache_shrink(cachep); > - ret = __kmem_cache_shrink(cachep); > > - return ret; > + return __kmem_cache_shrink(cachep); > } > EXPORT_SYMBOL(kmem_cache_shrink); > Acked-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > -- > 2.25.1