From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C69BEC02197 for ; Sat, 14 Sep 2024 13:22:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C0EA6B0083; Sat, 14 Sep 2024 09:22:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 370606B0088; Sat, 14 Sep 2024 09:22:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25F0D6B0089; Sat, 14 Sep 2024 09:22:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 091676B0083 for ; Sat, 14 Sep 2024 09:22:51 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8836142007 for ; Sat, 14 Sep 2024 13:22:50 +0000 (UTC) X-FDA: 82563408900.08.9A9879E Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by imf20.hostedemail.com (Postfix) with ESMTP id A78731C000F for ; Sat, 14 Sep 2024 13:22:48 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="lD/QUFyv"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726320049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3+sUBUYlwVuWfbjGxbMazluFnfi9XsaxNKbywpciuJQ=; b=UmMCHP8hogLujv6AluzphYrNdBjGG9i/34e3ib21mUxChOzpLTU7dLNY70YlDxLlQ1Isjs jPfpjsj6T/OK5UHSiYmLjTMO8h8/JZNKTpUR+SicUky+i0O2itzxRM14gVXoq7VTrGmq5V 6OHCK2+z1QAAYk4+/f3u4dz80zWAh/c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726320049; a=rsa-sha256; cv=none; b=WB3gICaYfYVVvTRiKxDHPA8IIGeHykk++HTvXAXTVz5VqMKA8bM2DAbE6bv3ek1+Wn3HIN /FyxUhSoqfK55sSDQs3AwJQxWd0P33cS/phDZYxkcXRNVLO+Gd0JNU0aMIxdMD83XiY0h1 Eph7i+yUgtJXvRdDkg/pH0r/je2ezs4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="lD/QUFyv"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.208.176 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2f759b87f83so34370171fa.2 for ; Sat, 14 Sep 2024 06:22:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726320167; x=1726924967; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3+sUBUYlwVuWfbjGxbMazluFnfi9XsaxNKbywpciuJQ=; b=lD/QUFyvxTG2Ju+CKBbZBvoUUsXlLdeBfMwS6P4igbX/BhCwH+sgkZZIRjv7mmpxe4 AwureY9YRE+1WR188t3dCzrZ3dRL8DFeRvaeuiUOxaNG7YkNc9jy19pgE+wtsXiJR60n 84PVM1oe3/I2preUAETPERVI6btTx/3GXX8fVk6v0KE2nKJTTuMGnGFw985ERsTlckZ9 t6c6amBh2bQumaFH3VhT4ry/lbL0pwXKzggYQMF2ZUJQZoAkT5LWNL6WeP2ZTJA+Uahj GVPxH0cviMeSC6Xu9+I/7LDw/xmFy7gVSY+M/uphoEVlEwBtM7LPVz9qc2+yt7dGJ9Z+ xKXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726320167; x=1726924967; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3+sUBUYlwVuWfbjGxbMazluFnfi9XsaxNKbywpciuJQ=; b=TMPfEKQQ5l2PwOFsTypPtHAbtJI33zLx3FzFCbTKKsZ8xUY3bMs5K4jI0uSNqkAjOf 7Ticb6teDClc5Kw3B7PguYs6gBXUljIlzDUuFYjpY6vx8oV+l0wSqEkRN8os5CDtbeFb vdzCpBtVlrewUoTX1ff10ozCOAM7jWF/CHuBKOEevjD/AjAB48IwISKsU8tzZsAmdD3W e9Ryz1l8Yop49W2ZSqbDXnvn0p8dqSxJ2JeZwDgVMkVTk4zAgVBq0EQw+sOt2NICeUFl NLffct2I8W4seNRa4DNtTZq8FppxgzTG+G4tWlWpNLIr29AOoUMLxwpuIrdfgaZd1EMr EzMg== X-Forwarded-Encrypted: i=1; AJvYcCUyCXC3MzWMb8ENYDJGTnwqv/jr6m0fUjRGuwddQjbWYRaV/rfaR5o+GSl17xr+BzZ4y+xc3CzwdA==@kvack.org X-Gm-Message-State: AOJu0Yw0woEwsVRvuNsP11D1QqXCUu0fXgDPnDUhDRVlQcDwuV7zz5GQ NS2RTp3vUBZH3sP+61Biaxf+QIjrasO5TddKsNhK0v6pM3nsD4kL591b+fTmQkhwHqw/QLx43CG xp4ghDtm+WrCsJOgiIoRznilLc7c= X-Google-Smtp-Source: AGHT+IFsMiEbYRkmw/e1WA8TtKvsYa9E2dRTvJEZZePEj8T9ZqQxp5BKMRiahuZVXtqqQ0C7dt3mfLAK5T5gwu3a9cg= X-Received: by 2002:a05:6512:3d17:b0:536:5364:bc7 with SMTP id 2adb3069b0e04-53678fec5f7mr5021336e87.60.1726320166228; Sat, 14 Sep 2024 06:22:46 -0700 (PDT) MIME-Version: 1.0 References: <20240807-b4-slab-kfree_rcu-destroy-v2-0-ea79102f428c@suse.cz> <20240807-b4-slab-kfree_rcu-destroy-v2-7-ea79102f428c@suse.cz> In-Reply-To: <20240807-b4-slab-kfree_rcu-destroy-v2-7-ea79102f428c@suse.cz> From: Hyeonggon Yoo <42.hyeyoo@gmail.com> Date: Sat, 14 Sep 2024 22:22:33 +0900 Message-ID: Subject: Re: [PATCH v2 7/7] kunit, slub: add test_kfree_rcu() and test_leak_destroy() To: Vlastimil Babka Cc: "Paul E. McKenney" , Joel Fernandes , Josh Triplett , Boqun Feng , Christoph Lameter , David Rientjes , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Julia Lawall , Jakub Kicinski , "Jason A. Donenfeld" , "Uladzislau Rezki (Sony)" , Andrew Morton , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org, Alexander Potapenko , Marco Elver , Dmitry Vyukov , kasan-dev@googlegroups.com, Jann Horn , Mateusz Guzik Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A78731C000F X-Stat-Signature: jr36g7iykfrnnp5sf6ct795dyxz99has X-Rspam-User: X-HE-Tag: 1726320168-396601 X-HE-Meta: U2FsdGVkX1+jADyZQ1kN5k2Gu8wVpxZ0ACVhT4lnP+Wd2TaI7ZOHqN4x60ddBfdE3LLa5w1iozsftO/ZxkHWmWHvMy6y+1BgqhnzbWu/LXs78tlgFqYiwJzOP0M19XgSdSbi8QcZkIi6lPsJD09ZHWjvyB4aF+sORR7GADjqaku14qXBxmD1atxjCFsIfTRTWzlGz1+Guc8oxT+punVnndt0ZISVstaa89iu4VLC1r9kLD9zbKXjy2CXU8+QSKQB2MJr7B9I5ifC8zz9qYZHkyr5uCJGD6rnf5h+EDy8tyZ1AExzB+PyRFqQKo58fS52BF0cv4sxqUsSW31a0OwM9zpjz83WNFZLyn/7cECN4oIJs0Gu21cbnGfWsQBtuh7AZDOgH9fZ15DR3zvSi0lqdwvor60zqolRn14Lo4Zk0ccm15HvaNqb3Q9C8Jpy/sVF/TzQ3+6ZLbHqPeR4AVYQcjbzLw8IPADS8+ExZMOZW9TRxL4FaZ8iU8ffM9Te07UpMI+PUcR/i8/uZGwnxvcDEvHab0H+ys/49EYjBcwhiHApQTlr77QC96zHm4VVx67BmMG5M+hvsfbrdTmCw3CYEx3uy+U9Vzmub9i3Ftirf9j8DR+m60qr9Z+FtlcL1TUJM3pvuwdN7mmS1KrBHQnMNgksnPjnBmCafXZRgcuiQaVrj6K6LMRPvstcxZRxUZfVbRG5mUJBW7FaWHRASOgWPT0JYnT5X9GW6thfUpb/e5csros/CicFswxfr9sgPMtaKgYm0B81c/IHRpsBalkRiQ3pXHQgMj47EahySEppIgc/uSCymlumcGVq2PdP04YqfN9DIr8gGUIoTX2s5p2vXXELAUr8PJdUNm1rQSdR0kocjnEb7ieAWbTI1uxYfOJQjtv33c6T0M2B8L/DTS3lxey2jFfVqKTuVyYWjvjgnVyf4JZUv15oO+ZSCG+D1ExjjcEa3hTIN7mLiCxeHP/ q6vK6U/h F4IFCikfyTbmb518cuZYe+hriGDmRoZW+6WwACSyHugcFxfn0C5IIQxCSxmqthAClSjj+IqO6SI3JlgbtO8bub+O+C7FxYy/+as9EyqmOgaYfneksP7n5l51tgUWBt/BJrDUPgy0lXWCSHHEPeL3p3jKEqL90tHDkDiO51HP/Txw51wj8UcpJYo0av9C18t0eL8b5lylIsHgaqG0lfO93dZPepT8H2XywX783fFTMMIM+TwyP/kjGSt9oCf9vsTBqFcliivG6vtba7nsapwZ6pPNeaVI5NHZ1XwVlFuWlsRMOhe/p3Ac5wwNmLYNT0mbiDFsvmfHLki+qztTjZElZFZwVjDahsZmyRn0qp5E9U71oOA86tmYESpgZnn54e2Il2WY5tQcsx9+spfo7T0/Jy6ABcdxXJtDp6cuyOUkF4JpSXjGPq2PIaiqe+gwFidOUG6MJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 7, 2024 at 7:31=E2=80=AFPM Vlastimil Babka wro= te: > > Add a test that will create cache, allocate one object, kfree_rcu() it > and attempt to destroy it. As long as the usage of kvfree_rcu_barrier() > in kmem_cache_destroy() works correctly, there should be no warnings in > dmesg and the test should pass. > > Additionally add a test_leak_destroy() test that leaks an object on > purpose and verifies that kmem_cache_destroy() catches it. > > Signed-off-by: Vlastimil Babka > --- > lib/slub_kunit.c | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > Hi Vlastimil, I think we might need to suppress the WARN() due to the active objects in kmem_cache_destroy() when it's called from slub_kunit. With this change, the warning below will be printed every time slub_kunit is loaded, which made me wonder if there's a bug (for a while). Actually, SLUB calls pr_err() is called by __kmem_cache_shutdown() if there are any active objects during destruction, and the error message is suppressed by slub_kunit. However, kmem_cache_destroy() still calls WARN() regardless if there is any error during shutdown. [ 147.546531] Object 0x00000000c09342ca @offset=3D640 [ 147.546542] ------------[ cut here ]------------ [ 147.546544] kmem_cache_destroy TestSlub_kfree_rcu: Slab cache still has objects when called from test_leak_destroy+0x74/0x108 [slub_kunit] [ 147.546579] WARNING: CPU: 5 PID: 39703 at mm/slab_common.c:507 kmem_cache_destroy+0x174/0x188 [ 147.546587] Modules linked in: slub_kunit uinput snd_seq_dummy snd_hrtimer rfkill nf_conntrack_netbios_ns nf_conntrack_broadcast nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct sunrpc nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 ip_set nf_tables nfnetlink qrtr binfmt_misc vfat fat snd_hda_codec_generic snd_hda_intel snd_intel_dspcfg snd_hda_codec uvcvideo snd_hda_core uvc snd_hwdep videobuf2_vmalloc snd_seq videobuf2_memops snd_seq_device videobuf2_v4l2 snd_pcm videobuf2_common snd_timer snd videodev mc soundcore virtio_balloon acpi_tad joydev loop zram virtio_gpu ahci_platform libahci_platform virtio_dma_buf crct10dif_ce polyval_ce polyval_generic ghash_ce sha3_ce virtio_net sha512_ce net_failover sha512_arm64 failover virtio_mmio ip6_tables ip_tables fuse [ 147.546646] CPU: 5 UID: 0 PID: 39703 Comm: kunit_try_catch Tainted: G N 6.11.0-rc7-next-20240912 #2 [ 147.546649] Tainted: [N]=3DTEST [ 147.546650] Hardware name: Parallels International GmbH. Parallels ARM Virtual Machine/Parallels ARM Virtual Platform, BIOS 20.0.0 (55653) Thu, 05 Sep 202 [ 147.546652] pstate: 61400005 (nZCv daif +PAN -UAO -TCO +DIT -SSBS BTYPE= =3D--) [ 147.546655] pc : kmem_cache_destroy+0x174/0x188 [ 147.546657] lr : kmem_cache_destroy+0x174/0x188 [ 147.546659] sp : ffff80008aba3d60 [ 147.546660] x29: ffff80008aba3d60 x28: 0000000000000000 x27: 00000000000= 00000 [ 147.546662] x26: 0000000000000000 x25: 0000000000000000 x24: ffff800094a= 2b438 [ 147.546665] x23: ffff80008089b750 x22: 0000000000000001 x21: f9cc80007c1= 782f4 [ 147.546666] x20: ffff800082f9d088 x19: ffff0000c2308b00 x18: 00000000fff= ffffd [ 147.546668] x17: 0000000046d4ed9c x16: 00000000ae1ad4db x15: ffff80008ab= a3430 [ 147.546670] x14: 0000000000000001 x13: ffff80008aba3657 x12: ffff800082f= 0f060 [ 147.546679] x11: 0000000000000001 x10: 0000000000000001 x9 : ffff8000801= 652c8 [ 147.546682] x8 : c0000000ffffdfff x7 : ffff800082e5ee68 x6 : 00000000000= affa8 [ 147.546684] x5 : ffff00031fc70448 x4 : 0000000000000000 x3 : ffff80029d6= b7000 [ 147.546686] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff00011f1= c8000 [ 147.546688] Call trace: [ 147.546689] kmem_cache_destroy+0x174/0x188 [ 147.546692] test_leak_destroy+0x74/0x108 [slub_kunit] [ 147.546693] kunit_try_run_case+0x74/0x170 [ 147.546697] kunit_generic_run_threadfn_adapter+0x30/0x60 [ 147.546699] kthread+0xf4/0x108 [ 147.546705] ret_from_fork+0x10/0x20 [ 147.546710] ---[ end trace 0000000000000000 ]---