From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DADE2C54FB9 for ; Tue, 21 Nov 2023 08:23:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5C1A26B046D; Tue, 21 Nov 2023 03:23:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 570526B0475; Tue, 21 Nov 2023 03:23:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 438306B0477; Tue, 21 Nov 2023 03:23:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 312CE6B046D for ; Tue, 21 Nov 2023 03:23:31 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F1D31140A21 for ; Tue, 21 Nov 2023 08:23:30 +0000 (UTC) X-FDA: 81481272180.22.F3E950F Received: from mail-vs1-f42.google.com (mail-vs1-f42.google.com [209.85.217.42]) by imf19.hostedemail.com (Postfix) with ESMTP id 434C81A0012 for ; Tue, 21 Nov 2023 08:23:29 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Y4+kcN1i; spf=pass (imf19.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.217.42 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700555009; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VTTlQmptyhl28YwEosbclj7OWg+yV7E5QNOLel4gX6s=; b=CK1d4wjHmoOL6bPip8tptOJ2GhubY9ISIHtstW3Amilundre9NqGcGWV43iyf0WNnT6W9W GQoeIHlZvRmdyMPSVrhCQyuczH/WOmPR3nsyQD3J3gom84+k2giXngT5JsBAUL4IvKZXQB 1e77m5qBUJzlSHxf+AZ7Kp1Q1W84e2Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700555009; a=rsa-sha256; cv=none; b=h5ghw4ZC+eqLf6nZ4F8w0VrTW873rb+j2TQ0fF3oFFWILWajeluWqgTFF0ajfhrCh7sQow pTqkLQorkdT9iyhOajOifUS1avORheXhYzEcxkPmkNZFzokd2Vsfuf4mQ/KBFnuE9bQ+Cx q8lGBkKf/I0ugtge4KiLjAJHhnyfE9k= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Y4+kcN1i; spf=pass (imf19.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.217.42 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-vs1-f42.google.com with SMTP id ada2fe7eead31-4629fac5a43so591468137.1 for ; Tue, 21 Nov 2023 00:23:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700555008; x=1701159808; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VTTlQmptyhl28YwEosbclj7OWg+yV7E5QNOLel4gX6s=; b=Y4+kcN1iB//UyIKqhipQBXW/cIjZHLhPDq9uEHsI4A3s3UVe9sjG4McYmlJgU1MdY7 mHXUwtqU6BEZ7uli2IqWJXtTnnm54MCYI9+EY83byJm1v+tjNyU6eDegLhdK7/4gTFfF MGSliErMkrH4pw3JgIxRqcuRht5iZGQyZIENaKd9Tm8ZeLtUpJCU8W0rMlQkpGRdgzye AifuGXSiIozDXd5PRzEKaWfqLFZzpzNa0PUTbnd1/m0S1B0aJJqk70UPtC7HVlH+t/hV ir8CYthFAwppA/ylGmNpuaWPQeDUtyTlVs4pPt3dlFjvP7z8ygnALNl0KSCS68iVB0DG 33Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700555008; x=1701159808; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VTTlQmptyhl28YwEosbclj7OWg+yV7E5QNOLel4gX6s=; b=Rkt6QlEi/fbe6Njok2MO91hdeSPKHHGvV39Z568mFARGHb58nT5ps3t31658qqxISF 4hb+c96OLTln28GRzJvpfyw4r1cDUghd6f64lLFGqQg9z+zkp7o5g8E4UaZVtAjzwrOk 1rjqPj01jfhKHbUVYDFRpABeYBTWPksYs37Vqq47/OZx36CPlUgrhZVAxItNELeX5nWL I5wE5KGyYPkhWotcf3zaqnXXrEM6Yb2uN0qsXuuu+cmRNUeUTtpVmYxdt7GCspvbew5e bdvHWjq08XEQY19fssyvWA5CU4Vpzmtxb30aelCtvYalLnG9A6b4IqziztbRdQN2hmV5 6oFw== X-Gm-Message-State: AOJu0YyCHOAReRbDqotuyfjI2igmi2fyhpCmRwvpSm9BdpTfo0EdsoNt 87f37xfd9EyUtzGqkXw/5a2SPFx/SXyme/k10mI= X-Google-Smtp-Source: AGHT+IGwoESgCljT9hI9a75uzFfG37Ho+LK4Kg8xt7bZRLz8mCB39XUmvj78Wr1gcUkuJvu0WD01EZ6+itnbfBvZNTg= X-Received: by 2002:a67:fbcc:0:b0:45d:a89f:e1f4 with SMTP id o12-20020a67fbcc000000b0045da89fe1f4mr4547806vsr.9.1700555008189; Tue, 21 Nov 2023 00:23:28 -0800 (PST) MIME-Version: 1.0 References: <20231120-slab-remove-slab-v2-0-9c9c70177183@suse.cz> <20231120-slab-remove-slab-v2-3-9c9c70177183@suse.cz> In-Reply-To: <20231120-slab-remove-slab-v2-3-9c9c70177183@suse.cz> From: Hyeonggon Yoo <42.hyeyoo@gmail.com> Date: Tue, 21 Nov 2023 17:23:17 +0900 Message-ID: Subject: Re: [PATCH v2 03/21] KASAN: remove code paths guarded by CONFIG_SLAB To: Vlastimil Babka Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Roman Gushchin , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , Kees Cook , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 434C81A0012 X-Rspam-User: X-Stat-Signature: o6c3a5ixdcdj98j1934zycafifftatmc X-Rspamd-Server: rspam03 X-HE-Tag: 1700555009-652520 X-HE-Meta: U2FsdGVkX199KpeQFD/SsmZsbbMUhC2oLfqqWQBpE9WxteOORsJpNJbL40M90Cv+RD/2unpvIRu10pVEffjiaP1QoGdB+uXo4hD0hwJcqpvPE7/hyc4mvCscYEADICJZZv/LbmeVQ86fvTaGKTbQPmpI4GU6SwsafEorxksWa998CkjeFJYyDzPCHZOxJ/NCdWtY8gH7cTBJQkyJ/V4ejS2BCoFLWiWIBkhcxs55QznmIRI7uzpL8GhG7WkLKVsZT6OvjxjIw5E1wtxQ8z7EsW57zUKZ0GoDD8GY6CShwPZioOwrci9039Lc7qPNUZMg0AMvvJUFWhSbvZphIZXVnAeQYk8Gbmfg8swoxjybgjYjG9FgeUuqBp+fsJeFmpszLJ0qWoQL8lGVF59VbWi45+zKC1QxgBH3DGhW6moL3nvv67yVsQa+6u/BwSIViW0bzVjK8TM7D7mswVPLxBTa0iNhbgLlzDYxgeLd5+3J4DloEB8UgTglRFiRRUjvBj2Vha8rB8gqtFyIHllbgxR61obI8HaRoA4SFibSNe8ecDPHembuuXuU62+HeOz0BKrSZoT3ddLtWF9dNypiilkm9k9HyN6IqjgEPjFhl3K12euQ6vifFojPQgdEfyuQjNxg3glmXbtL7WqOBFr642O5PQPqrY5/feFafp1jfYnbZdC36453ufB4liTL5+zkos1qh5AseuBzwPeucGHZ7UzoBRNJMNbLgU9zOlUv/+Wv+zy62UUKa0I3Ty3g0DuaYXylgXGJh10aXv2Qr3i14hjIyN0668rT4FyWBEtSCnwhySgDJTfqIV9F5bKlG6EiJDPjYnIHQpfB0//dm2vBqFw37EBu4YKwBTsPuZ2FrJCbUiGOh2RRsZuSbXWL+7FcqK0cKjZO9y8O2Lsn8oDAkm/X4f/GGX6NHjYaUs2SFQy6FaIXeu6vnr4nof6KaDu3BJNaoVJb8PrrByWaZGF/HRb iB8kW9+M M/yqeaxDspYF8Szvf1sR/laMw86XM8bZ05VGh7kzE8ogShNwGXPI4KC2VYsYdEPfIC0CrCpTF6SBYvxFwe7JMjBdbVtNPASt4lnUx7j4cM8K8NYW/sAYKtLh5bIVBkVknKL2oIkF2ZnRJ3HSleKaD9eHKbwlLaMKGufFHocsxelIWylzQ3GzyxJ08fiWxw1tZHhM0L+CduY/QL0cPeQWhFxaoqSL/GysERYk7YrPXI3xDUbU+TKPhY3ItHPonnWv4WusNWLJHCUqA3w1nx5prnZloyWmn5BI/L8v6oDtI2HD4pjk0zwdr2FnHjF6BrUGs1aZ1SUjgNiURaj6EaNiy9DKSS57uu898UiPu4YCDTrmldL9+ymd26wGoVG25RrlT6FDqD/bU7g5ZJlMALSzVNq3JdFbCl359QIcXWT/0B0hobFhCnPnuvFPpCLtUYLOaCMd8eBaQ0dyIcKUGKSng3r5+OFsYpBUBnrjw+2T6iYbi8cWnvSzLvKZOekAZi+KucflaHMh7HGcTgxT024MuJ6VhXBNZoyx70izZHJOZ4BU1DCLPEQRaZ+srPtJBYJI3kVwkhBIxy0raks3UKrBuPtQflG0F/766YT6omz5is3cyAi/jbUd6e0z1tZVa3bkyocdLQMk3PAtvxjE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 21, 2023 at 3:34=E2=80=AFAM Vlastimil Babka wr= ote: > > With SLAB removed and SLUB the only remaining allocator, we can clean up > some code that was depending on the choice. > > Reviewed-by: Kees Cook > Reviewed-by: Marco Elver > Signed-off-by: Vlastimil Babka > --- [...] > diff --git a/mm/kasan/quarantine.c b/mm/kasan/quarantine.c > index ca4529156735..138c57b836f2 100644 > --- a/mm/kasan/quarantine.c > +++ b/mm/kasan/quarantine.c > @@ -144,10 +144,6 @@ static void qlink_free(struct qlist_node *qlink, str= uct kmem_cache *cache) > { > void *object =3D qlink_to_object(qlink, cache); > struct kasan_free_meta *meta =3D kasan_get_free_meta(cache, objec= t); > - unsigned long flags; > - > - if (IS_ENABLED(CONFIG_SLAB)) > - local_irq_save(flags); > > /* > * If init_on_free is enabled and KASAN's free metadata is stored= in > @@ -166,9 +162,6 @@ static void qlink_free(struct qlist_node *qlink, stru= ct kmem_cache *cache) > *(u8 *)kasan_mem_to_shadow(object) =3D KASAN_SLAB_FREE; > > ___cache_free(cache, object, _THIS_IP_); > - > - if (IS_ENABLED(CONFIG_SLAB)) > - local_irq_restore(flags); > } FYI there's a slight conflict (easy to resolve, though) when I tried to merge this on top of linux-next, due to a recent change in KASAN: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/= ?id=3D0e8b630f3053f0ff84b7c3ab8ff98a7393863824 Thanks, Hyeonggon