From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84D7BC4167B for ; Wed, 6 Dec 2023 00:08:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6B386B0074; Tue, 5 Dec 2023 19:08:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D1B756B0075; Tue, 5 Dec 2023 19:08:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE2DA6B0078; Tue, 5 Dec 2023 19:08:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AF2326B0074 for ; Tue, 5 Dec 2023 19:08:29 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 80762802F3 for ; Wed, 6 Dec 2023 00:08:29 +0000 (UTC) X-FDA: 81534456738.21.511DA58 Received: from mail-vk1-f182.google.com (mail-vk1-f182.google.com [209.85.221.182]) by imf27.hostedemail.com (Postfix) with ESMTP id B988A4002B for ; Wed, 6 Dec 2023 00:08:27 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ddzUqh2Y; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.221.182 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701821307; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mZmoOpShnlOr1bQVRrl+GknWd+PtQJEUK3TXoeEYCts=; b=EAhIZNwcHdFsnJcJGglyJn72HyHYbl1eKIlePaLRnufFFzsVDNquq1SWfWfc66ofC1XJjW ZNwUwFGSd8riOZqIMsh9Hfvjatn+Q3s3nZtRyUu8zeCzGT1pDAkAzkcCvcF/QwOED5DVmc 42at/7GL5wTVrQECAGSO9GqedRyKIWg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ddzUqh2Y; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.221.182 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701821307; a=rsa-sha256; cv=none; b=fwxLfjmga9nGrZXrWAbKD7vGjypMg7yQwGl4tNWzGpvVirA2KWjqHlKI3e6oZx5QiB40OI ACOH9pc5uGqbTysXmLhyMDg5np6+0PeDP/Ka20j4+bddIqIPrmN4yXso2a5zIWqJmEnAFB 2ro7Sz74OiKo59B1G432r2fvfZ8HYzQ= Received: by mail-vk1-f182.google.com with SMTP id 71dfb90a1353d-4b2c0ba26f1so217730e0c.0 for ; Tue, 05 Dec 2023 16:08:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701821307; x=1702426107; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mZmoOpShnlOr1bQVRrl+GknWd+PtQJEUK3TXoeEYCts=; b=ddzUqh2YzFf7Y6K9+RSmyV1OlD/JUb8u2z3gFNw+LS2XMInKsgApDqV4w4ew61crQH uOqk/0/qJv0GBvyjo4m90mJATRBuqAVwk5UHW2kQlc13jb9ybQRSDbDBQCixroriRLip o6nFsyvjVjSYKvIayZmUSXoHOLbpAc+p0UYIq8lahBK84tNix105ShdszsxaUmY4hZqv k6plL3NOvACQi8K399ZqpQz0rKXMHVDRY9TkZpZgkNZKRkrsKrBJom9F4zzCMiJU3Ur1 RrCj8BwoFCmJ+Z46vR0tmFOgTIKc8i0OguS6cQD4B3y0T2dsNemkm4yhsLbfnZ0J/eB/ gEzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701821307; x=1702426107; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mZmoOpShnlOr1bQVRrl+GknWd+PtQJEUK3TXoeEYCts=; b=RKSgl0sHtng1EbF6saI50oz3Rt10zNt1aGrwszQavefz3ANBNC7YNlXYoal0ysvEcx 6PVcCq4Jz/Gz37qOnC/QXi0vH9DO6G32VH2Nlsy1wvSwllovHiicnZMTch/JJEXLCTdv yP9tmWVETD2wEDTaSQLd6XEzgfV0DMYHhIQRmsgPhuEIapELzNIkTdKP1BHgwRihrWx0 cVxHPjwfz2xee7CL2uTrsdt3yYt/Xhk7QS2pdPv5daGfKoZcunaiktqpVPpSrsn4+Jyf 7VQYb4WZhQnrcO6wOCLboTtjD0/zrSKKA9s6w8sa1lcM8n09+1VDtVtUizIZSIm8ScpE z7oQ== X-Gm-Message-State: AOJu0Yx3bBVJu8NgV4MxgnNxRosAD59feqcjyZEMJUxwzyTTz5pyL9/e LN4VB8lv1+ziFMWqvDPCkg5MGMwFTRXmGEeT9zw= X-Google-Smtp-Source: AGHT+IHe47styOpdF2IwNLQKmxh275Vb5ERuMYIfHI30HlMr+3ER7uJ9XJJ7Bag/XCKqrpbPzhICRkVEtagiFq7m0LE= X-Received: by 2002:a05:6122:3187:b0:49d:20fb:c899 with SMTP id ch7-20020a056122318700b0049d20fbc899mr2686639vkb.4.1701821306644; Tue, 05 Dec 2023 16:08:26 -0800 (PST) MIME-Version: 1.0 References: <20231120-slab-remove-slab-v2-0-9c9c70177183@suse.cz> <20231120-slab-remove-slab-v2-2-9c9c70177183@suse.cz> <93a8a67c-9cb7-0d36-6b14-ce15a30bea3f@suse.cz> In-Reply-To: <93a8a67c-9cb7-0d36-6b14-ce15a30bea3f@suse.cz> From: Hyeonggon Yoo <42.hyeyoo@gmail.com> Date: Wed, 6 Dec 2023 09:08:16 +0900 Message-ID: Subject: Re: [PATCH v2 02/21] mm/slab: remove CONFIG_SLAB from all Kconfig and Makefile To: Vlastimil Babka Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Roman Gushchin , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , Kees Cook , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: B988A4002B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ks5qkybya45wypkcacu1yia1uxfw8bhc X-HE-Tag: 1701821307-128365 X-HE-Meta: U2FsdGVkX1+wn7BKN3N8ALUtGM/9zDyEUog366qOzyxjvfHhfEwFuDMoJgCMdaZjuI8MHxrzmy1A+4hyN018DrmbupDbkW3iJGwAtv1nMOAyxg4L1amtx95UqyXkIjqdbE+hArq08ix1+VBcZiPKALcBOdxW1xeu8dk7/a2J1FqWogckfpLrVyxAp66n4Pb2BmL/kkX/jR4TqLcVNDMmEg3QZcX9BRyOJHJyacBtm98JAcR30n2p9ZB8KNMBW5lwfd2EAjJy9/gSt7XYicCZsW3y/Hpq6tMJcRZ21FsZ2tE3WffiZ1Uq9imMAhfMkxXtlykeZggwPTo62I6HYDOxBPF3PFAjE5bx+sLfbyJ13Xyc86JVn6w/wSYf4mrAmaExTpH4f5sMTnJb5bW+ieeE4Spb7uf3yYN0t3zMAWNsr/Fl0ZRfHXGRTmKThlIaigQV3XeB115rj5umZbqGPFkAbsq/xc6xyk8MFZncNVgrbeJ5P2qZrsyH3iqBAcoqbRvC2euAoq27a4ivLNnXpQNmufiC40V940aq1sQmsayQiYTNl+MEHHTMKc0YnvNmjsByCBv22q62t1X/DbUj142uQUZJ97o8GJnOKq9c2G2j7FpVqX2OeRqgy9McKpf5cZfZHk/hMw75VdABmtc/k2+H/FrQnK/A1vxdemJnlidZBBaMxg24SGPfdlcHxyj5KaMxkUGujenLNt/JfzGwAsA5Do2eXIVc0H4Iy+Pl9/OO3Lfk0poPhRYrv9Tuz6SHKOCvdYYqyMMN7FVaPPSGU79GHLi+MenxmHBPnaNuJBdizGXFSr07WJ3KX9JavcSuZ3eIo30nX/zhqQrzXoNuHGDjjG5hKKClmbFAjDVYsUQUEZ+aWEoGa4J+6YWRS8o9jMt5Ah+tZIyadj7/UOlt1BhSUVpAPsc9RnEYIyHhobOV3LBIm7NWO3BIVcMVj46g0Ov31gOvxXOgIcUCqCXnutW 1ym+dmom utPSPx+43g7ZJhEzh2Lr6hMQpPBEh4a503OKKObmPjUK7xbA7nHvwxCvxYc4kHgs9dH7oNpbJHnt2ChCucRc3w3gS2IZs8TUIdA34vL2DrQ1IGEUaJGqernGYGjm3wd8ldGZTMeFHaadpZT/ASkctmOJHRVGkyFTTfmNqnBKYsdTH9i+QL/5UdV8bg1mjme8zMU2yNJWJn00xHMK23aa4fiay60s+QfaCaDIGbQSd8uCDyKUFwgNoQUJc0GVX0KZhI5+AgOMkn1xXS/sthzN/ZOF7E+2tTJDGsTuQUOr3LCEQIzT6F8xaJLJgyYvqe0RNi4Nytr9FFrPK3ffZKkSZFHIv12XwcGyibvdUHJ4tiWni3x6egXVD1BBqw9myUAz4fGvId9EG889tOdm8nhhc7w6G0l1Swqcto3bYZqmKEcF+JMrwnrgQn2IXxHJZDrSVeSh8u8jAq1bS66heLSvSZml9nbSZ02+7jqviVbz7/FAlQT1j679WbDV2mYoeIm6VQP4nfcXfA3J5jd1OYU7GLQvPLg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 5, 2023 at 7:14=E2=80=AFPM Vlastimil Babka wro= te: > > On 12/5/23 05:15, Hyeonggon Yoo wrote: > > On Mon, Nov 20, 2023 at 07:34:13PM +0100, Vlastimil Babka wrote: > > > > Looks good to me, > > Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > Thanks. > > > Nit: > > > > - Some arch configs enables DEBUG_SLAB > > - Some documentations refers to {DEBUG_,}SLAB config (i.e. "enable > > DEBUG_SLAB for debugging", or "use SLUB instead of SLAB for reducing OS > > jitter", ... etc) > > - fs/orangefs/orangefs-kernel.h uses #if (defined CONFIG_DEBUG_SLAB) > > > > $ git grep DEBUG_SLAB arch/ > > arch/arm/configs/ep93xx_defconfig:CONFIG_DEBUG_SLAB=3Dy > > arch/arm/configs/tegra_defconfig:CONFIG_DEBUG_SLAB=3Dy > > arch/microblaze/configs/mmu_defconfig:CONFIG_DEBUG_SLAB=3Dy > > > > $ git grep SLAB Documentation/ > > > > [... some unrelated lines removed ...] > > Yep, I've wrote in the cover letter that to keep the series reasonable an= d > limit Ccing other subsystems on some patches, not everything is cleaned u= p > thoroughly Ah, I see, Okay. > and is left for further work (some already started coming in > from others) that can be submitted to relevant subsystems. I'll focus more on correctness rather than doing further work while reviewi= ng. > > Documentation/admin-guide/cgroup-v1/cpusets.rst:PFA_SPREAD_SLAB, and ap= propriately marked slab caches will allocate > > Documentation/admin-guide/cgroup-v1/memory.rst: pages allocated by the= SLAB or SLUB allocator are tracked. A copy > > Documentation/admin-guide/kernel-per-CPU-kthreads.rst: CONFIG_= SLAB=3Dy, thus avoiding the slab allocator's periodic > > Documentation/admin-guide/mm/pagemap.rst: The page is managed by the = SLAB/SLUB kernel memory allocator. > > Documentation/dev-tools/kasan.rst:For slab, both software KASAN modes s= upport SLUB and SLAB allocators, while > > Documentation/dev-tools/kfence.rst:of the sample interval, the next all= ocation through the main allocator (SLAB or > > Documentation/mm/slub.rst:The basic philosophy of SLUB is very differen= t from SLAB. SLAB > > Documentation/mm/slub.rst: Sorry SLAB legacy issue= s) > > Documentation/process/4.Coding.rst: - DEBUG_SLAB can find a variety of = memory allocation and use errors; it > > Documentation/process/submit-checklist.rst: ``CONFIG_DEBUG_SLAB``, `= `CONFIG_DEBUG_PAGEALLOC``, ``CONFIG_DEBUG_MUTEXES``, > > Documentation/scsi/ChangeLog.lpfc: CONFIG_DEBUG_SLAB set). > > Documentation/translations/it_IT/process/4.Coding.rst: - DEBUG_SLAB pu= =C3=B2 trovare svariati errori di uso e di allocazione di memoria; > > Documentation/translations/it_IT/process/submit-checklist.rst: ``CON= FIG_DEBUG_SLAB``, ``CONFIG_DEBUG_PAGEALLOC``, ``CONFIG_DEBUG_MUTEXES``, > > Documentation/translations/ja_JP/SubmitChecklist:12: CONFIG_PREEMPT, CO= NFIG_DEBUG_PREEMPT, CONFIG_DEBUG_SLAB, > > Documentation/translations/zh_CN/dev-tools/kasan.rst:=E5=AF=B9=E4=BA=8E= slab=EF=BC=8C=E4=B8=A4=E7=A7=8D=E8=BD=AF=E4=BB=B6KASAN=E6=A8=A1=E5=BC=8F=E9= =83=BD=E6=94=AF=E6=8C=81SLUB=E5=92=8CSLAB=E5=88=86=E9=85=8D=E5=99=A8=EF=BC= =8C=E8=80=8C=E5=9F=BA=E4=BA=8E=E7=A1=AC=E4=BB=B6=E6=A0=87=E7=AD=BE=E7=9A=84 > > Documentation/translations/zh_CN/process/4.Coding.rst: - DEBUG_SLAB =E5= =8F=AF=E4=BB=A5=E5=8F=91=E7=8E=B0=E5=90=84=E7=A7=8D=E5=86=85=E5=AD=98=E5=88= =86=E9=85=8D=E5=92=8C=E4=BD=BF=E7=94=A8=E9=94=99=E8=AF=AF=EF=BC=9B=E5=AE=83= =E5=BA=94=E8=AF=A5=E7=94=A8=E4=BA=8E=E5=A4=A7=E5=A4=9A=E6=95=B0=E5=BC=80=E5= =8F=91=E5=86=85=E6=A0=B8=E3=80=82 > > Documentation/translations/zh_CN/process/submit-checklist.rst: ``CON= FIG_DEBUG_SLAB``, ``CONFIG_DEBUG_PAGEALLOC``, ``CONFIG_DEBUG_MUTEXES``, > > Documentation/translations/zh_TW/dev-tools/kasan.rst:=E5=B0=8D=E6=96=BC= slab=EF=BC=8C=E5=85=A9=E7=A8=AE=E8=BB=9F=E4=BB=B6KASAN=E6=A8=A1=E5=BC=8F=E9= =83=BD=E6=94=AF=E6=8C=81SLUB=E5=92=8CSLAB=E5=88=86=E9=85=8D=E5=99=A8=EF=BC= =8C=E8=80=8C=E5=9F=BA=E6=96=BC=E7=A1=AC=E4=BB=B6=E6=A8=99=E7=B1=A4=E7=9A=84 > > Documentation/translations/zh_TW/process/4.Coding.rst: - DEBUG_SLAB =E5= =8F=AF=E4=BB=A5=E7=99=BC=E7=8F=BE=E5=90=84=E7=A8=AE=E5=85=A7=E5=AD=98=E5=88= =86=E9=85=8D=E5=92=8C=E4=BD=BF=E7=94=A8=E9=8C=AF=E8=AA=A4=EF=BC=9B=E5=AE=83= =E6=87=89=E8=A9=B2=E7=94=A8=E6=96=BC=E5=A4=A7=E5=A4=9A=E6=95=B8=E9=96=8B=E7= =99=BC=E5=85=A7=E6=A0=B8=E3=80=82 > > Documentation/translations/zh_TW/process/submit-checklist.rst: ``CON= FIG_DEBUG_SLAB``, ``CONFIG_DEBUG_PAGEALLOC``, ``CONFIG_DEBUG_MUTEXES``, > > > > -- > > Hyeonggon >