From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB8CBC072A2 for ; Wed, 22 Nov 2023 05:59:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBECC6B055C; Wed, 22 Nov 2023 00:59:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E6EC06B055E; Wed, 22 Nov 2023 00:59:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0F4C6B0560; Wed, 22 Nov 2023 00:59:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C1AFB6B055C for ; Wed, 22 Nov 2023 00:59:51 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 8D9741A0153 for ; Wed, 22 Nov 2023 05:59:51 +0000 (UTC) X-FDA: 81484538982.16.0AC4A8F Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com [209.85.222.53]) by imf10.hostedemail.com (Postfix) with ESMTP id B16D4C000C for ; Wed, 22 Nov 2023 05:59:48 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=K8xUi0Pa; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.222.53 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700632788; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GRblTu4ml6hVfmv/M7Om0SzMbiMU6JrjrAw45Kacwyg=; b=wjvKTnXkT2GDbLTC0m5Ggg2JggQG3JZe/vCXZo+8skv0akaUdpcrsXQodlO3vJGltL7RKM 0U9stkz3gE5YkZW/DoPQi14QHkNfihbEvdWKNxJFCkra7ZzMJzj+VDhtcZakZez43xIgVc 2x3mBXZa0lgLgv/1vge14kr1ev74zxM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=K8xUi0Pa; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.222.53 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700632788; a=rsa-sha256; cv=none; b=ofH+pF08g3/I4+/ft3WTS2PAvceVYfSQSICnOdgOjF7jhM7pWl3b+JmSzRX2jbb3pbZqo9 YMdpWCbTRMqV//hRmq3Qs/UDOkjtxbwoA0udBcxrzl811x8gdMXuS/+GIXHpNGHZWQQ5Od vaqYTMoh5ZouX0hBXnNH4QsfgI9pri4= Received: by mail-ua1-f53.google.com with SMTP id a1e0cc1a2514c-7c43d42e2ceso36469241.3 for ; Tue, 21 Nov 2023 21:59:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700632788; x=1701237588; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GRblTu4ml6hVfmv/M7Om0SzMbiMU6JrjrAw45Kacwyg=; b=K8xUi0PaHPFCwhUYCYcK0uY6Bc4xqSi9bc5/CvsbSgVIC2jeP1PJic+PnKnAI/mFC4 lvupAanRWNuKorD1PKJwosFfow7pLTTlMpvqi/8TzMs6YxSLK3AOjErfDD33VXasoe70 RZi26WjZDToqxVRapXFR3Ie2x1sZJ0SKx1QXvoxjTjuQXtACe1SVBXlSyAODF8/XJ5Dc yDjZSJhoW/pCEftHrCc8t2bSxOM7Ey8eyVZHCMEOGjDOJKaIZzITFNThMM5izVs3G3SD zK4PdEFJ4IOKFxUprv2uTe/w6CW+IL9hwDA/3ovg+rAtxHTIooSikQ8921/3Vi7uZ2Tt aD6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700632788; x=1701237588; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GRblTu4ml6hVfmv/M7Om0SzMbiMU6JrjrAw45Kacwyg=; b=RSjr2V2tJasRlU3kckTGQkgGKF1GEPFAkNDlzsGZtys4uyzEhp1pR82tQbtsFFXHsd vELPUCCZ2j+Wox+0Nm4+6H/CLSlPHAiKYF0bMBVbdFm+b6IlaTyF5cwv1q4onQ03Uwe2 iL0/2L0yYceaLVC989gTziLb09JzDqfec0uE1RIB9N1JamsBsCesjeApsky7xUN82+/g buqDRRbEQtup4M7TX4eQx9Y7VHiuJEq2ww01qhSegQddcjpIBIKl5m4RML3btoMniUFt Szcdq5Xy5sFWRb2omzPZ8JK/xICwK+cfWQgzYy6gKFUcWOnT6VBhBHBdMLWAAMHuSADf 10zA== X-Gm-Message-State: AOJu0Yw5GpYibUnJz48E3KH/ALMo5C4SGcfHKw1/LfJ9KMj/CYDsTy75 hkuOxzUUcqc1Ud5Za5xC1Ow8d3DtG/NwX2Zhd6k= X-Google-Smtp-Source: AGHT+IHFKQeeC2S+TQAawEjhySClwPyCEXpsw360upok0riC3QEOTrEExQQd9eciMhcRR6UorZiBsMcAlJE6UPvvS7U= X-Received: by 2002:a67:ebd8:0:b0:462:71c3:99aa with SMTP id y24-20020a67ebd8000000b0046271c399aamr1271437vso.19.1700632787592; Tue, 21 Nov 2023 21:59:47 -0800 (PST) MIME-Version: 1.0 References: <20231120091214.150502-1-sxwjean@me.com> <20231120091214.150502-3-sxwjean@me.com> In-Reply-To: From: Hyeonggon Yoo <42.hyeyoo@gmail.com> Date: Wed, 22 Nov 2023 14:59:36 +0900 Message-ID: Subject: Re: [PATCH 2/4] mm/slab: remove slab_nomrege and slab_merge To: "Song, Xiongwei" Cc: "sxwjean@me.com" , "cl@linux.com" , "penberg@kernel.org" , "rientjes@google.com" , "iamjoonsoo.kim@lge.com" , "vbabka@suse.cz" , "roman.gushchin@linux.dev" , "corbet@lwn.net" , "linux-mm@kvack.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: cr63cff7t7netw1ryfr9uxs4awdpa5fs X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B16D4C000C X-HE-Tag: 1700632788-258406 X-HE-Meta: U2FsdGVkX19RwlvmLiIazBDMVMguLETyWZBqI8BLKbBxELcfiy4T/FKLoQl54WpW8sMkDs9IIe9xRChsQACBS1cMuAthIcetcVLKgESWy/CdLO5RjyelXBSEL7P3YXcbyU5FeEEPVYYkqfAEGMEfL9+qV/DEYY8OrCNikYbq/p3cGYBH2+ggUQdQskWu/t+CbVEPKiBsGT9KiYatYq13j0O9vRAg1ZEOiYJpUfmOnm7KyKBlgmouWrXC6GsxYztZVISR5r29pLkGYbJVaZzFDnbQ5UCxzRjdlqsnuL9AP16LNpVgEWoxlJU03KfczhdfyZyifP79Me1Li2V9UebJ5gz6Tv8qZvxvNR8luk25w7eyzYcNt5JZTVlGld4bkzQrXw+4Lqi8hDU/HD3yA+NqRR+/kVxI8VeTouBaJEm+n4p1D3W03LWuC6gctC3AS0jAml1/s/VrKT2k2GYUBermCRJCbgcMUIaXeD0+Iox9I/851XeYjYGGlGINPTLu9XgVR3sQapVL15D5rib8aOu8MqsuhO9NkA9YuDs/M8Fxlg3myULrkQ9/uhgmuKruEhuE8u6Q+CVFyzYb3TyaRfXqqqIcezZtcwK/oqHcSp6JyvUdH95JoSMcCog/G8pvydYagZiuA+KYNTWDdJI63G8VVwucXFh+C5OSOoVbygkFhgCFyBVgdY2KSer12+W7waquANMmpX5mPjod/o7MOkXgIJuGL2UqslgFv16bY4DJnSONJu+ND7Pyc66b6dZLRRtLWzhUkm93f2Ptpnhj+n5N5ZN3zID4pfHVNz/H9N6JS3AqDbfT2XI3+4M3VTyLCe9XrKXm58ITB2Xt7ioI2aNImbg0bSB8MyVuSc8t+AjrMikW2AZDl7bv0B95/qLQJwSiCIKSBPqRvUe6KdwEHO4J0vYUVLmEKwiHSUuXiFK+z6AIneI+8nyAF2Zz48i+CpOrXezrTrQJgBZgYD4jBPe YDxPp+P0 Io2JCdGfCHpGa7694I11rrjsWgGDW4AdbwkE0hLAVtGKXcRWYlsEv4XpOtjzjWTX+ZzFVGuEpgh6PtK67vWOt+l68NlVXmKaiMQnU5UFxDc2IrS7Nh+I2PVU0b4eZgXp9WqlfA1gVIWKlAOk3nvf7gSD6r/XQQT26nT+2nhcGbo17vbFO1k3H+kLUCJ+PTHVJ88u0tjOieL3WZtkWXV/HbXmI6P9z9ZM4VSgqFFprsmHjegHUV69TFxXMKb7dSXhTwBJSsjciEaxf5r/KyK0/3mmgJhyIvDpOT+Imt9xk/7aUEEn5nfr0HjTcbivNOdqp9gOmw53MZysUH66aITzoOjmJ8deQ/JwQfbDvaRcLBTsoOpkKGSiQTOuMwVgHjv458bwUl26tYya6xG0qhzbm4ef8Zbl3aQF0Xhec5v3kFIy3AV1yXjvdeb0V/0rkWYA8I0blkEEQqXmcsO8BT2yCiLqczEWP/vGZzRvggypb4wyt74AEOrTZbxIyG+iOvXGb2VqAk6B1f5b4IHokbE8eBKs1K947tgrz0srS5UlLHtSKbx0DfCX2T8JUNXKWfke/cEI4+pbtMzi6Wc90WE5LhA0m/nQ7mWCTBq9ftbrI1Y2u9lHjPNL2vetURvri6/EO1k1qDPgI/EM7qNrLtPfKtnq4g+15qkCKTe5cAgDMLvTX02ii6WJjsBYWp7Yfs9jxNVl2f15odkh9eS63fp79hvOeENYFJ4nvMscyUe9WcMmbE+kl9epFwYBk762R953bIyzpWwXcKurzet9T81y5ywOl0+fpfqqX3XdVE9qfJQdkF9jjnB9u2KK+18LWqbaMcqjLw9b1XJQLg4SKcM+AmRwpsmYhh8VMZtbL/Dvc4q8B/nZz5hgypPtQCQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 22, 2023 at 2:27=E2=80=AFPM Song, Xiongwei wrote: > > Hi Hyeonggon, > > > -----Original Message----- > > From: owner-linux-mm@kvack.org On Behalf Of = Hyeonggon > > Yoo > > Sent: Tuesday, November 21, 2023 4:44 PM > > To: sxwjean@me.com > > Cc: cl@linux.com; penberg@kernel.org; rientjes@google.com; iamjoonsoo.k= im@lge.com; > > vbabka@suse.cz; roman.gushchin@linux.dev; corbet@lwn.net; linux-mm@kvac= k.org; linux- > > doc@vger.kernel.org; linux-kernel@vger.kernel.org > > Subject: Re: [PATCH 2/4] mm/slab: remove slab_nomrege and slab_merge > > > > CAUTION: This email comes from a non Wind River email account! > > Do not click links or open attachments unless you recognize the sender = and know the > > content is safe. > > > > On Mon, Nov 20, 2023 at 6:12=E2=80=AFPM wrote: > > > > > > From: Xiongwei Song > > > > > > Since slab allocatoer has already been removed, so we should also rem= ove > > > the related parameters. And change the global flag from slab_nomerge > > > to slub_nomerge. > > > > No, kernel parameters should be changed only in a backward-compatible > > way (if possible) > > > > Before slab merging was supported in SLAB, only SLUB supported it. > > After commit 423c929cbbec ("mm/slab_common: commonize slab merge logic"= ), using > > slab_[no]merge parameters for CONFIG_SLUB builds became legal. > > > > I think what the documentation says is "slab_[no]merge enables or > > disables slab merging > > and slub_[no]merge remain supported only for backward compatibility" > > Yes. But slab allocator will not exist anymore. Is slab_[no]merge still p= roper? > Will the term "slab/SLAB" still be used in the future? Well, why break existing users for no strong reason? The reason why commit 423c929c did not drop slub_[no]merge after commonizat= ion is to support existing users and avoid breaking what worked before. Removing slab_max_order made sense because SLAB has gone and it didn't have any effect on SLUB, but slab_[no]merge are not the case. Also, technically SLUB is an implementation of the slab allocator concept, so IMHO it is not an improper name. and (let's say) even if it is improper, I'm not sure if changing everything would be worth it: $ git grep 'slab' mm | wc -l 2365 -- Thanks! Hyeonggon