From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D022BE677F5 for ; Sat, 2 Nov 2024 10:17:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 379306B008A; Sat, 2 Nov 2024 06:17:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 329826B008C; Sat, 2 Nov 2024 06:17:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F17C6B0092; Sat, 2 Nov 2024 06:17:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 008016B008A for ; Sat, 2 Nov 2024 06:17:00 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A814E1A14B1 for ; Sat, 2 Nov 2024 10:17:00 +0000 (UTC) X-FDA: 82740750330.01.45CA1E1 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf30.hostedemail.com (Postfix) with ESMTP id 77D4380019 for ; Sat, 2 Nov 2024 10:16:03 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kJBI01zR; spf=pass (imf30.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730542536; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BkEU9mTQ6tXFuNuzFU1ghCpVVrAA88JTqUi5IjkRQKM=; b=cXq5C1ssJQ/OTMARxFfvvoUR3oL5ROvI0unAmcafH3l8qrS+tIbDK16yspQesjHCxGCugg oNzqdiNwrEb3bfdUFUjj0mFNI/czfnUwsAr1R5b0QNjn8Ox5+mLjUW9H5l/sFTsWA5fLXs +77Y7YDZt/eRwBznpNU4xpuJoUN2zEA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730542536; a=rsa-sha256; cv=none; b=EtsM2GcYS+tXNixlwO6kJo9ImBNaQnLk/1og4sQFMvJBRuzg6Ew7gs3yqclEN3N5E8qUmH fq6OceXa9A2UgVxX5AP+NWhVgnC66GgvFq5m4pLOw83qBmU5jiihV1w4tDV1Yobil5Qap6 jnRv2Bm7LmkMSNdDnAb7U4/KSmW0m20= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=kJBI01zR; spf=pass (imf30.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2fb58980711so24712601fa.0 for ; Sat, 02 Nov 2024 03:16:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730542617; x=1731147417; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BkEU9mTQ6tXFuNuzFU1ghCpVVrAA88JTqUi5IjkRQKM=; b=kJBI01zR/HM+BvYj9/tAlBzEM+cnH+jezjGbeGq3O+4B6EWjji/LcN59/u85HB8NdM 8m+mG8/ePE1FIMqiGv69mz7XXm8SIYMRtsGCoIrcEhq+0dRDgLCnkpREBeYMWMl/XUmj Pzn+7uplTVKAvHfFsIeHABv5Lc7F8FiQrlrTk7QYI+OT49pC6DPunDoSyipVzTD500pK 5rZQ3CUFMFMQFa1v7gRFS63nycAw3lCeFVQudI+4nkMNI2qw3Bqo46pL1b84KWR5hwtW ryeqhD1aJy4VwJaYJc7p2g1D9V+sWD/Cx5kA8t6MXK3jxHN0regE6JfN/hO650IhmBxy EdSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730542617; x=1731147417; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BkEU9mTQ6tXFuNuzFU1ghCpVVrAA88JTqUi5IjkRQKM=; b=EgP1Nt3H6LhcqBA+2WBFlyhNIeRByjl7xkG5y9gj0PuAKovupkfmFGM84R2FQIjP8q D1LIlZ9IlEJYBeta6KzzkqnKOEWUUyOwnXH9mxzAB3dXXGDKz7XU9gz5Du5rea5KryPN oIx9IeAVJ7xV43c41eNqIRUidJDdjIHj621ZRCLyIgV3a4Js/pFhZIodC3X/DKf6X0JD u2I3GcwPcL0szDeO91DArqMr+sz/YcodrX3/TbRf2QUxuCw6QoBuDyXHMwug+V9Oqkcc XvyRxsc6kQVhvB58b8CGC0iIJy+A2sYcfNbKp5KLrtzq3XYkpwkEaWPECvhfgq1KHjEw p0qA== X-Forwarded-Encrypted: i=1; AJvYcCXi48INd5Kh+1WoDU+xAqrGWPPDMlva4F6MDsthauvsrQFwvAyva+Y4/ScHEHNDfbOkHX+Imq02rg==@kvack.org X-Gm-Message-State: AOJu0YzSLkMx4M6kn1EN7v8iLiktuuRIF/+lo7n1vbwiC1ZHBIWUPRNm 5LyWGtDnaeyBY4BR4/eLqm96+s0tLd2SFBIBF/wCid01HuS+m2dd/IbMYhe9tty8HA0TjPB+HhM gKP0FcBYoxTbZxlseiqieQl+BSsY= X-Google-Smtp-Source: AGHT+IG7b759m9HTGKnYeTTS9XGYvl0vAWG70QplV7/CGskWcGhS88Zw92tUpeJw+YGJhGmQltz5XlN6jlUTevTDAys= X-Received: by 2002:a2e:5109:0:b0:2fb:4428:e0fa with SMTP id 38308e7fff4ca-2fcbe04f435mr96626301fa.36.1730542616619; Sat, 02 Nov 2024 03:16:56 -0700 (PDT) MIME-Version: 1.0 References: <20241101130845.19100-1-42.hyeyoo@gmail.com> <35f58f1b-6e71-42ce-8619-2ecd810b4510@suse.cz> <195242b4-5471-419a-a350-08fd246973f0@suse.cz> In-Reply-To: From: Hyeonggon Yoo <42.hyeyoo@gmail.com> Date: Sat, 2 Nov 2024 19:16:44 +0900 Message-ID: Subject: Re: [PATCH v1] mm/slab: Allow cache creation to proceed even if sysfs registration fails To: Vlastimil Babka Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , linux-mm@kvack.org, Jinjie Ruan , Liu Shixin , Christian Brauner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam10 X-Stat-Signature: 76kkhmmo1x1nabg73d8x54xaykrqe6wq X-Rspamd-Queue-Id: 77D4380019 X-Rspam-User: X-HE-Tag: 1730542563-103515 X-HE-Meta: U2FsdGVkX18P3fEq5aQQ0SLLTOtfRbLhsdZqtIi5PA7NVblWMDoxpmLHVRXpf90msH+xKuuNfXMk0JUe9TfPjtqyKmW2x4GqJ4jLKXwGsF/24vFZ43ynec2dQDjgzF+hkrg4+1DZjyD1V3AhNK3axkafUstPZD7/sWzP57aSvg/zeeCKTJhRSN4Gi9Zkf24xR8k22FWOUdc9CG3IhbTUFYVIIIbBb8t/alaWulby5c5jlZSHlwGpihRInwWHIPMJdZcHDCixz8qubu29fSM5x0ENNaY8lHM75fgbO+MTbSnzB3czwzLgd3w1R6O50IP1XFCls+opyf8Up7p1fRsGmRxyJYmtNxeltFyPg9TDr02dv+lKwN3ztSIsCNJpeJE71h/RppMKrzJ2dZscEsbzX/C0uNjRfw0X/dhpeCYI6DNkcuOQdTC1zaCi4l+2CeSiBwvu5kSaNpO3io9z8vqTVR0fqj7YcHbO+Gi1cPG/EdwU9i4/j918jx7EQbz8hGqI1ROHBD5avj51Fcp3sfU2y9aS+r5TQsTMqE7ybAyKgPzJRxXAi5QvU+/tHUyu3Nhms3Kvnqbhe0qHokSgOZo6sEIS+fiS5QxcFHiN1do+dW4f58Tdb28IrQdiKV6aI96R5M2TkPsvHvYm1ZxWq/o7bjTycOfzbUGO2lD/dVgiMW9LUx9aWbuFb5TKElk8pdKe5cpKXkekkm5gTbn+30P0cE6jYgmKRlDSI4SEgRHGZOYBSRbZ0Y7xyJeA76lKJFETxVeOBjELwWsaOjxhV3vKRKEUr5luE8zu2ekSzKcXTsMtcgmxI7C6QjolHMri59lrfDMWoa8KDLsYsV5TE7F58+btIX1NwoD4c35/Oz/dFj9M+2LE+CU6e7gOYOgJQXM2Nh6AXocqdQM6J4c8CjRdxaWkSjGMLiumxSFapEw2QqYiSTK+WwVX2w5dI7EkvuUAENKB304GiH5uTy3LnA3 fN4IPhNH UZwGVvSpnT2aKXYma+19CX/LMF+wdfuxtU/Zznjk1jdL5ArDzY7Agwcp9K/Ao9S6mOVuyHSfBxv0rkB7Hr4zuxLP/pong3bVGqp4T4LChBcP97Gh1Ja0czoLqFz6ubCmM6hTn/F2RzCMtTBUfPMN+++5/dCwwKx/i81bwo1zLyEN6y5D8cgjnj37PgNLm1zRjFsnKkbw4wzNWD045KMUZfsCu0OewXOjSrJXbyGcsiyP9hUCbhmQUUdQD69c8wmIPxrdtEACyDAdoiWJe+KnYbNy/NH5E3l5X0vFf+3JZz67bFgZzA8HtLZ9A884l/mYBSVhI1kqEjpd1Qpj+s+nMk1u8Rl+0qY6BdN3YFKg2+9mkX/GHSCiKJVezfg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Nov 2, 2024 at 7:07=E2=80=AFPM Hyeonggon Yoo <42.hyeyoo@gmail.com> = wrote: > > On Sat, Nov 2, 2024 at 5:50=E2=80=AFPM Vlastimil Babka w= rote: > > > > On 11/2/24 8:18 AM, Hyeonggon Yoo wrote: > > >> > > >> Also here, and simplified to "if (sysfs_slab_add(s)) ... " to avoid = dealing > > >> with err. > > > > > > Oh no. err is initialized to -EINVAL, so that will not work as intend= ed. > > > It is causing the following list corruption. > > > > Ooops, right, thanks a lot. Wrongly assumed that a test boot in > > virtme-ng would catch silly mistakes like that. Looks like all caches > > were created with SLAB_STATE < FULL. > > > > Fixed by setting err =3D 0 before trying sysfs add. > > Thanks! > > Hmm... by the way, why doesn't SLUB update 'err' in the event of an error= in > init_cache_random_seq(), init_kmem_cache_nodes(), or alloc_kmem_cache_cpu= s()? > I may be missing something, but it doesn't seem to handle these errors > properly to me... Oh, it seems like a recent change fc0eac57d08c ("slab: pull kmem_cache_open= () into do_kmem_cache_create()") incorrectly pulled kmem_cache_open()? Cc-ing Christian Brauner.