From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FABAC433EF for ; Wed, 10 Nov 2021 15:18:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0658D61107 for ; Wed, 10 Nov 2021 15:18:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0658D61107 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=auristor.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 90C036B0071; Wed, 10 Nov 2021 10:18:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BDC46B0072; Wed, 10 Nov 2021 10:18:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D1C96B0073; Wed, 10 Nov 2021 10:18:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0234.hostedemail.com [216.40.44.234]) by kanga.kvack.org (Postfix) with ESMTP id 7109F6B0071 for ; Wed, 10 Nov 2021 10:18:50 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 32A61824CA08 for ; Wed, 10 Nov 2021 15:18:50 +0000 (UTC) X-FDA: 78793378020.07.5BE21E3 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf18.hostedemail.com (Postfix) with ESMTP id E83E740020A0 for ; Wed, 10 Nov 2021 15:18:48 +0000 (UTC) Received: by mail-ed1-f50.google.com with SMTP id ee33so11906910edb.8 for ; Wed, 10 Nov 2021 07:18:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mO3hph1YkCApcCuLSKx4NqEPJzPi9cWVsNMhXuQPk3w=; b=He7e9JDFnW7U4XWtbSmWPINTwqu0D1x9ohz2i+l11IGqONhLTQpUsJfeoCF65Fxcgw Q0XAwT0+lYNX1d9mopAcWrlLo/RaBY+a4toJlZStfXoBqAeemSwHmjCma613x21N7foi qRLNOfkLd8QOJIuXlKFh2kkpsdy4fGmK1ywfAEc0sJDTEyFq0xHQ7o7buq+U6jl5Rfxw i+NRKxTB4/7nuZeewkaW1T7+Pdr0/xqLPD4s2ObdEqi8Mac0De/HUqgQvmnb1RqmlGQQ BFwhvC4g45ue8zPntoEx6YH4Ol8o5Kzu/haS+NfZR4PlGbXdKp+S8J3rAObSCjsioGxn 0YqA== X-Gm-Message-State: AOAM531ctd+hl2/vdxJ6zi3Z9FzbTQlE2T3XhxOd1RfeITY0wR1lKoEF v4XVoXPf50peOrf8SEoBOhIfikeQL0vKKpTY X-Google-Smtp-Source: ABdhPJyJc/710xO6McjPXxEfZPe3s11dmQX+s7lHMDTQqZQS/UUmkzxPYptYamGV82qUga7gCkE+sw== X-Received: by 2002:a17:906:2ed5:: with SMTP id s21mr459381eji.30.1636557525435; Wed, 10 Nov 2021 07:18:45 -0800 (PST) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com. [209.85.221.51]) by smtp.gmail.com with ESMTPSA id di4sm25476ejc.11.2021.11.10.07.18.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Nov 2021 07:18:44 -0800 (PST) Received: by mail-wr1-f51.google.com with SMTP id s13so4659268wrb.3 for ; Wed, 10 Nov 2021 07:18:44 -0800 (PST) X-Received: by 2002:a05:6000:4b:: with SMTP id k11mr627335wrx.86.1636557523979; Wed, 10 Nov 2021 07:18:43 -0800 (PST) MIME-Version: 1.0 References: <163649323416.309189.4637503793406396694.stgit@warthog.procyon.org.uk> In-Reply-To: <163649323416.309189.4637503793406396694.stgit@warthog.procyon.org.uk> From: Marc Dionne Date: Wed, 10 Nov 2021 11:18:32 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 0/5] netfs, 9p, afs, ceph: Support folios, at least partially To: David Howells Cc: "Matthew Wilcox (Oracle)" , kafs-testing@auristor.com, Ilya Dryomov , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, ceph-devel@vger.kernel.org, Jeff Layton , Dominique Martinet , v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, linux-mm@kvack.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E83E740020A0 X-Stat-Signature: yepozsat9irrqgaxn7ojj9fcwah5m8u4 Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf18.hostedemail.com: domain of marc.c.dionne@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=marc.c.dionne@gmail.com X-HE-Tag: 1636557528-62030 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 9, 2021 at 5:28 PM David Howells wrote: > > > Here's a set of patches to convert netfs, 9p and afs to use folios and to > provide sufficient conversion for ceph that it can continue to use the > netfs library. Jeff Layton is working on fully converting ceph. > > This has been rebased on to the 9p merge in Linus's tree[5] so that it has > access to both the 9p conversion to fscache and folios. > > Changes > ======= > ver #4: > - Detached and sent the afs symlink split patch separately. > - Handed the 9p netfslibisation patch off to Dominique Martinet. > - Added a patch to foliate page_endio(). > - Fixed a bug in afs_redirty_page() whereby it didn't set the next page > index in the loop and returned too early. > - Simplified a check in v9fs_vfs_write_folio_locked()[4]. > - Undid a change to afs_symlink_readpage()[4]. > - Used offset_in_folio() in afs_write_end()[4]. > - Rebased on 9p-folio merge upstream[5]. > > ver #3: > - Rebased on upstream as folios have been pulled. > - Imported a patch to convert 9p to netfslib from my > fscache-remove-old-api branch[3]. > - Foliated netfslib. > > ver #2: > - Reorder the patches to put both non-folio afs patches to the front. > - Use page_offset() rather than manual calculation[1]. > - Fix folio_inode() to directly access the inode[2]. > > David > > Link: https://lore.kernel.org/r/YST/0e92OdSH0zjg@casper.infradead.org/ [1] > Link: https://lore.kernel.org/r/YST8OcVNy02Rivbm@casper.infradead.org/ [2] > Link: https://lore.kernel.org/r/163551653404.1877519.12363794970541005441.stgit@warthog.procyon.org.uk/ [3] > Link: https://lore.kernel.org/r/YYKa3bfQZxK5/wDN@casper.infradead.org/ [4] > Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f89ce84bc33330607a782e47a8b19406ed109b15 [5] > Link: https://lore.kernel.org/r/2408234.1628687271@warthog.procyon.org.uk/ # v0 > Link: https://lore.kernel.org/r/162981147473.1901565.1455657509200944265.stgit@warthog.procyon.org.uk/ # v1 > Link: https://lore.kernel.org/r/163005740700.2472992.12365214290752300378.stgit@warthog.procyon.org.uk/ # v2 > Link: https://lore.kernel.org/r/163584174921.4023316.8927114426959755223.stgit@warthog.procyon.org.uk>/ # v3 > --- > David Howells (5): > folio: Add a function to change the private data attached to a folio > folio: Add a function to get the host inode for a folio > folio: Add replacements for page_endio() > netfs, 9p, afs, ceph: Use folios > afs: Use folios in directory handling > > > fs/9p/vfs_addr.c | 83 +++++---- > fs/9p/vfs_file.c | 20 +-- > fs/afs/dir.c | 229 ++++++++++-------------- > fs/afs/dir_edit.c | 154 ++++++++-------- > fs/afs/file.c | 68 ++++---- > fs/afs/internal.h | 46 ++--- > fs/afs/write.c | 347 ++++++++++++++++++------------------- > fs/ceph/addr.c | 80 +++++---- > fs/netfs/read_helper.c | 165 +++++++++--------- > include/linux/netfs.h | 12 +- > include/linux/pagemap.h | 23 ++- > include/trace/events/afs.h | 21 +-- > mm/filemap.c | 64 ++++--- > mm/page-writeback.c | 2 +- > 14 files changed, 666 insertions(+), 648 deletions(-) > > > > Tested-by: Jeff Layton > Tested-by: Dominique Martinet > Tested-by: kafs-testing@auristor.com The updated series passed our automated test suite, which is mostly targeted afs testing, but with a framework that also relies on 9p. So you can reapply: Tested-by: kafs-testing@auristor.com Marc