From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1344C433EF for ; Tue, 19 Oct 2021 13:37:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3C29560EE9 for ; Tue, 19 Oct 2021 13:37:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3C29560EE9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=auristor.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C7B986B006C; Tue, 19 Oct 2021 09:37:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C2B516B0071; Tue, 19 Oct 2021 09:37:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4155900002; Tue, 19 Oct 2021 09:37:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id A39C76B006C for ; Tue, 19 Oct 2021 09:37:24 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 5359A182C153A for ; Tue, 19 Oct 2021 13:37:24 +0000 (UTC) X-FDA: 78713288808.08.7893AA8 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf13.hostedemail.com (Postfix) with ESMTP id 0649E10403D2 for ; Tue, 19 Oct 2021 13:37:20 +0000 (UTC) Received: by mail-ed1-f50.google.com with SMTP id 5so12609012edw.7 for ; Tue, 19 Oct 2021 06:37:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l2fMMxDDiXx3vgfR9XbtY8zVEKvNNXiKJ69kmRp4vQM=; b=QmSRJQujuPcNqYagrlsIDHtzQyaJLPQ5rxfm8rkl3KlHScPBByTdOp7Zp+jpRwYPJf BrXLe0kXnlJhZ3uc8T0bhVuaf0OPbvqaKQLtYn9AF+4lUzjxEWsyA/oOwXvHnu5BJpeP qJzuzWVqruAeKYCvy2RUqU6PY1Go+68nJTQZEGrfGI+9aZ7hoy3fvvUWrpSYsAl+OTyG apJjR1VutCVYlutYJ8ZYuq4ujTUg5PaTBt297ODYKaSTA6spSg3ZRO4YIoR4ZZ3ILSZH 2k1t7IPeVsumMaOP6p9GiIY60u489X3scuQY3KH55YWo7TRD6oVJJ78bTQteyteLydqA GQNA== X-Gm-Message-State: AOAM530w1izz9EBspYeZir+dqJW0Dsf642M8Pa6Gv3LDMcVBJCI4SLDn eBc+ojv/QHabxAqsLc/u/NEzOByfYKgfAYru X-Google-Smtp-Source: ABdhPJy/b2GZBd6aPt37wF/gYHXHPIUHyfMz7bu0RysPYxZhVnwkpdk5RCs7VoMZY0VDYuuVAW3qGQ== X-Received: by 2002:a05:6402:84d:: with SMTP id b13mr54878368edz.110.1634650597718; Tue, 19 Oct 2021 06:36:37 -0700 (PDT) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com. [209.85.128.46]) by smtp.gmail.com with ESMTPSA id rv25sm10251167ejb.21.2021.10.19.06.36.37 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Oct 2021 06:36:37 -0700 (PDT) Received: by mail-wm1-f46.google.com with SMTP id a140-20020a1c7f92000000b0030d8315b593so2714457wmd.5 for ; Tue, 19 Oct 2021 06:36:37 -0700 (PDT) X-Received: by 2002:a1c:a443:: with SMTP id n64mr6116840wme.32.1634650175559; Tue, 19 Oct 2021 06:29:35 -0700 (PDT) MIME-Version: 1.0 References: <163456861570.2614702.14754548462706508617.stgit@warthog.procyon.org.uk> In-Reply-To: <163456861570.2614702.14754548462706508617.stgit@warthog.procyon.org.uk> From: Marc Dionne Date: Tue, 19 Oct 2021 10:29:24 -0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [Linux-cachefs] [PATCH 00/67] fscache: Rewrite index API and management system To: David Howells Cc: linux-cachefs@redhat.com, Latchesar Ionkov , Dominique Martinet , linux-mm@kvack.org, linux-afs@lists.infradead.org, Shyam Prasad N , linux-cifs@vger.kernel.org, Matthew Wilcox , Trond Myklebust , v9fs-developer@lists.sourceforge.net, Ilya Dryomov , Kent Overstreet , Alexander Viro , ceph-devel@vger.kernel.org, Trond Myklebust , linux-nfs@vger.kernel.org, Jeff Layton , Linux Kernel Mailing List , Steve French , linux-fsdevel@vger.kernel.org, Omar Sandoval , Linus Torvalds , Anna Schumaker Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 0649E10403D2 X-Stat-Signature: bstc4dm618taadm5p5zq88tk7gj8igr7 Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of marc.c.dionne@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=marc.c.dionne@gmail.com X-HE-Tag: 1634650640-53231 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 18, 2021 at 11:50 AM David Howells wrote: > > > Here's a set of patches that rewrites and simplifies the fscache index API > to remove the complex operation scheduling and object state machine in > favour of something much smaller and simpler. It is built on top of the > set of patches that removes the old API[1]. Testing this series in our afs test framework, saw the oops pasted below. cachefiles_begin_operation+0x2d maps to cachefiles/io.c:565, where object is probably NULL (object->file is at offset 0x28). Marc === BUG: kernel NULL pointer dereference, address: 0000000000000028 #PF: supervisor read access in kernel mode #PF: error_code(0x0000) - not-present page PGD 0 P4D 0 Oops: 0000 [#1] SMP NOPTI CPU: 5 PID: 16607 Comm: ar Tainted: G E 5.15.0-rc5.kafs_testing+ #37 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-2.fc34 04/01/2014 RIP: 0010:cachefiles_begin_operation+0x2d/0x80 [cachefiles] Code: 00 00 55 53 48 83 ec 08 48 8b 47 08 48 83 7f 10 00 48 8b 68 20 74 0c b8 01 00 00 00 48 83 c4 08 5b 5d c3 48 c7 07 a0 12 1b a0 <48> 8b 45 28 48 89 fb 48 85 c0 74 20 48 8d 7d 04 89 74 24 04 e8 3a RSP: 0018:ffffc90000d33b48 EFLAGS: 00010246 RAX: ffff888014991420 RBX: ffff888100ae9cf0 RCX: 0000000000000000 RDX: 0000000000000001 RSI: 0000000000000000 RDI: ffff888100ae9cf0 RBP: 0000000000000000 R08: 00000000000006b8 R09: ffff88810e98e000 R10: 0000000000000000 R11: 0000000000000000 R12: ffff888014991434 R13: 0000000000000002 R14: ffff888014991420 R15: 0000000000000002 FS: 00007f72d0486b80(0000) GS:ffff888139940000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000000000028 CR3: 000000007bac8004 CR4: 0000000000770ee0 PKRU: 55555554 Call Trace: fscache_begin_operation.part.0+0x1e3/0x210 [fscache] netfs_write_begin+0x3fb/0x800 [netfs] ? __fscache_use_cookie+0x120/0x200 [fscache] afs_write_begin+0x58/0x2c0 [kafs] ? __vfs_getxattr+0x2a/0x70 generic_perform_write+0xb1/0x1b0 ? file_update_time+0xcf/0x120 __generic_file_write_iter+0x14c/0x1d0 generic_file_write_iter+0x5d/0xb0 afs_file_write+0x73/0xa0 [kafs] new_sync_write+0x105/0x180 vfs_write+0x1cb/0x260 ksys_write+0x4f/0xc0 do_syscall_64+0x35/0x80 entry_SYSCALL_64_after_hwframe+0x44/0xae RIP: 0033:0x7f72d059a7a7 Code: 0d 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb b7 0f 1f 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 51 c3 48 83 ec 28 48 89 54 24 18 48 89 74 24 RSP: 002b:00007fffc31942b8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 0000000000000008 RCX: 00007f72d059a7a7 RDX: 0000000000000008 RSI: 000055fe42367730 RDI: 0000000000000003 RBP: 000055fe42367730 R08: 0000000000000000 R09: 00007f72d066ca00 R10: 000000000000007c R11: 0000000000000246 R12: 0000000000000008