From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0961C46CD2 for ; Tue, 9 Jan 2024 17:11:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 288266B0085; Tue, 9 Jan 2024 12:11:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 237D16B0088; Tue, 9 Jan 2024 12:11:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 100B46B008C; Tue, 9 Jan 2024 12:11:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 000CB6B0085 for ; Tue, 9 Jan 2024 12:11:57 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5FA46160953 for ; Tue, 9 Jan 2024 17:11:56 +0000 (UTC) X-FDA: 81660415032.09.5D996BD Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf25.hostedemail.com (Postfix) with ESMTP id 5BB4DA0014 for ; Tue, 9 Jan 2024 17:11:54 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of marc.c.dionne@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=marc.c.dionne@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704820314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=74pgZ+nMyMyCi7Q0sf1ChPH+6TyfRgWiK4L8xKykjS8=; b=CdQnoO19NPDfWQa6wmqCua3St9CnKBejXMor1nUeJ6TVikSvDzL0GaLMO/+xJXKVz0DEyJ 3aRr0zvilA+AdH88IzFhQuDvq5+UCKMdiJ5EfriEu/QKe+C3cmermdqXG/XFkUbfYsVRGx ptcb/cjQDcLsk0X7cGb/uqCdmvpIxPs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704820314; a=rsa-sha256; cv=none; b=OihPqh9Z3ETiMOOFFt/306bZ+8Vk/cK5tZKfD16YuLJJMZqMsE7CylgTgf3yr9uvgzKGwS 1vKRbH41EMcuysqseOXPD/FrTcl3zN91RFghsP/m5slb3hMJCj5amelzTDVReAJYdK81Ve SUcfdyMsIKZHMEf8OtoRDiwHvixcz7g= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of marc.c.dionne@gmail.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=marc.c.dionne@gmail.com; dmarc=none Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2cd17a979bcso35531731fa.0 for ; Tue, 09 Jan 2024 09:11:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704820312; x=1705425112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=74pgZ+nMyMyCi7Q0sf1ChPH+6TyfRgWiK4L8xKykjS8=; b=otbUxOyGdt6dMLqwmxWQ4PKdkwigXd9Mlu5Xcw5P4n1tpyjn0qku092DMInN9JXhHu gtz5vGzH0Tzvqbi0/+myjO9RLb7uJ1WMefCVLAaWB6Kl2yDSIStSGrIkRAFBQbNOU0BR sitljEaI6pjsLCBBkBp904nr4TQ+E299kSHKMz8Xt4Lk/pJl78FWAnYOfc6Wg85U9tCW BUUmruJ8jq5IOoIzk9thWcPdQjsrhrIRPUhymNL1PGk0koXGHZktqHx9PzQ560RBtHlK H2IWARtJ+OIo0BGHaukNtpfvzIvS8/bC4hkUX6DsDzq86M4YU3uGYGvygxrwzyt3GVhf BNZw== X-Gm-Message-State: AOJu0YwCbh8yupdnJrRrce2wSGrjUbT7TOau6cKwZ5x70ud5KN04I9Im axFGp6VJAQK3O08Te9BpRLeRo8tWeldc0/8O X-Google-Smtp-Source: AGHT+IEyd91+yP6FWno/8ndtgcGZAofd1wL+ti/RXAGzJCDDs1kaVPuNmDTBbAIvOzE+MuWxQn64yA== X-Received: by 2002:a05:651c:3de:b0:2cc:5945:4e22 with SMTP id f30-20020a05651c03de00b002cc59454e22mr1077835ljp.85.1704820311755; Tue, 09 Jan 2024 09:11:51 -0800 (PST) Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com. [209.85.208.48]) by smtp.gmail.com with ESMTPSA id i25-20020aa7c719000000b005571c7e4934sm1135745edq.93.2024.01.09.09.11.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jan 2024 09:11:51 -0800 (PST) Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-553ba2f0c8fso3672651a12.1 for ; Tue, 09 Jan 2024 09:11:51 -0800 (PST) X-Received: by 2002:a17:907:1c19:b0:a27:5397:74ed with SMTP id nc25-20020a1709071c1900b00a27539774edmr523050ejc.175.1704820311478; Tue, 09 Jan 2024 09:11:51 -0800 (PST) MIME-Version: 1.0 References: <20240109112029.1572463-1-dhowells@redhat.com> In-Reply-To: <20240109112029.1572463-1-dhowells@redhat.com> From: Marc Dionne Date: Tue, 9 Jan 2024 13:11:39 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/6] netfs, cachefiles: More additional patches To: David Howells Cc: Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet , Steve French , Matthew Wilcox , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5BB4DA0014 X-Rspam-User: X-Stat-Signature: e3nifz8563a5ze6jzitcmzdfpax35jpb X-Rspamd-Server: rspam03 X-HE-Tag: 1704820314-898735 X-HE-Meta: U2FsdGVkX19b5wzd2WCI4sbOhZrMb62nZsC/dVPJ13aprnrpDEPfnP3zKspAOyZLpHdpPclQBIiMRWTrhJCR571NavT1WKEbFjJ3H/dbPk7zyv86hhFUErAcYlndsGFxJ918gTITlMdt8WPD53g7XsnqQkDXS1S3jvcz2PG+fjl3hXr+jxNa23JCVopO4A7UarekrguyaDAeL6SA8bxpSksESbBqLFkBIT8MddLhleN/d4xWP6bhiTDevonUd3AwGT66O280yNqB6wiFis4G6ZqqqsZEwwaYhzmR49O3As582JpJj883Vviix/1NRBngvVBdUAODYKid7baSm4DHEmFSrNSnP7/XqAns2ul18qsIJMmnG+peO/c6lWJ0e/J5IDbegnKdLxvczf54AJ0+HhoHo2PrHWq5H4unB2R0T59CZaQ2/oZXdDhTGVhu2tGkbK1zovfIXXX1RUFhHVBLZqph28LelamRSlYBSaB4kZSHquLRXHgPWQVJo1fos6FcCsEiyY3NahljttWLxOcL6beKH+V1lBdKovkDaLII42GGtezREk1zjhT1rD3rEhq3HE9AJS+x27jxWv6OvZ6rTCE3KMkWsL8KY0rpsEc3Mcf8nJcEmhZxHQopoSe75gYw4NRCioXPgoPoYgNNLrTTAtdDcvsWVBrB0+r0892bLbFkVptZoQeWnj/WJXrnxEdVLyG6yiEMpPJ8Z9cjaZaJdc5mdWy+QLoIxIcw50s/vMycQ7vnNjL0x+tP/pLzyMhLJX2/909QEaw+ZJvDoXKc3H6QzqVMLo8HOtelw2rKYR51Xn0GJp2+oA55auTnK2Y3aPOuZQ2jsQpBAsBguM1WoPASWXxUBt3YN3fnfQWDnvQoJKPOs1fcZIgp6LI1O9tJEPVKBxJONgwCGwzzi4N1ePJV0b9cM8RPYqCJm6BHOb3/KtSb6pOMrbvLEivIfI3xbvoHcF730FQIDOSnfHo 2OGROHiB kAx0nHh7HD0Sy/BHDbM5C6z85fJRu/7pHHNKsyZF3THRwg1zE6Xjur4+erUzZq0ZLWN3kEeTUtrf/xjCAnxCWOAhJRKIBLQic03kKx4JZlQd4vIPoj/VFPeHRkuSm+rogpzITC0j1/szeeUXUblRe7nVMpsxUZ77YBmH5nkCUN/c7a18P+A08ysVLT+5HtdR/FZZ9pgZaO9Mxj5VNL1JJWaH93Lcn+QfEyWi1Ve8IZ2Zgjz8+s+axNTFuzDLd1i/5CgqT/MomY0GzHqB+3XV/dVB9I7eEsRT4eMqdj/Otj3aP7rPJq3CRLRcTWpVDejG6UZd2f0IGqfnaT/kiDUepZAcW/vOPCR2e3UmUIjCkoS88MpbotxGSFG5YmDp0xtCO/xndWsb0FfiHYo6117mKCJFGyYNU4UfRngiPdc1dHim3x1U1OQlMutfSZWaFRDe1f/ejsUke70kRRCjIZbI3bF/qrZSXQmL3fcx/pp5SsE80SbxojyLb4dRmvZU/Vkwq9gqmu8gtIwtRxcPFHBgjD7svESaORJyh6GG/kcqSnzlomfnL+RtMoLKMMkhRi6mIFUh2XInYmPfmA5DtPwNA69gyqA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 9, 2024 at 7:20=E2=80=AFAM David Howells = wrote: > > Hi Christian, Jeff, Gao, > > Here are some additional patches for my netfs-lib tree: > > (1) Mark netfs_unbuffered_write_iter_locked() static as it's only used i= n > the file in which it is defined. > > (2) Display a counter for DIO writes in /proc/fs/netfs/stats. > > (3) Fix the interaction between write-streaming (dirty data in > non-uptodate pages) and the culling of a cache file trying to write > that to the cache. > > (4) Fix the loop that unmarks folios after writing to the cache. The > xarray iterator only advances the index by 1, so if we unmarked a > multipage folio and that got split before we advance to the next > folio, we see a repeat of a fragment of the folio. > > (5) Fix a mixup with signed/unsigned offsets when prepping for writing t= o > the cache that leads to missing error detection. > > (6) Fix a wrong ifdef hiding a wait. > > David > > The netfslib postings: > Link: https://lore.kernel.org/r/20231013160423.2218093-1-dhowells@redhat.= com/ # v1 > Link: https://lore.kernel.org/r/20231117211544.1740466-1-dhowells@redhat.= com/ # v2 > Link: https://lore.kernel.org/r/20231207212206.1379128-1-dhowells@redhat.= com/ # v3 > Link: https://lore.kernel.org/r/20231213152350.431591-1-dhowells@redhat.c= om/ # v4 > Link: https://lore.kernel.org/r/20231221132400.1601991-1-dhowells@redhat.= com/ # v5 > Link: https://lore.kernel.org/r/20240103145935.384404-1-dhowells@redhat.c= om/ # added patches > > David Howells (6): > netfs: Mark netfs_unbuffered_write_iter_locked() static > netfs: Count DIO writes > netfs: Fix interaction between write-streaming and cachefiles culling > netfs: Fix the loop that unmarks folios after writing to the cache > cachefiles: Fix signed/unsigned mixup > netfs: Fix wrong #ifdef hiding wait > > fs/cachefiles/io.c | 18 +++++++++--------- > fs/netfs/buffered_write.c | 27 ++++++++++++++++++++++----- > fs/netfs/direct_write.c | 5 +++-- > fs/netfs/fscache_stats.c | 9 ++++++--- > fs/netfs/internal.h | 8 ++------ > fs/netfs/io.c | 2 +- > fs/netfs/stats.c | 13 +++++++++---- > include/linux/fscache-cache.h | 3 +++ > include/linux/netfs.h | 1 + > 9 files changed, 56 insertions(+), 30 deletions(-) > > -- > You received this message because you are subscribed to the Google Groups= "linux-cachefs@redhat.com" group. > To unsubscribe from this group and stop receiving emails from it, send an= email to linux-cachefs+unsubscribe@redhat.com. This passes our kafs tests where a few of the issues fixed here had been se= en. I made the framework use 9p and no related issues were seen there either. Tested-by: Marc Dionne Marc