From: Nicolas Palix <nicolas.palix@imag.fr>
To: Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
linux-mm@kvack.org
Subject: Handling of GFP_WAIT in the slub and slab allocators
Date: Mon, 10 Jun 2013 16:09:15 +0200 [thread overview]
Message-ID: <CAAxaTiNXV_RitbBKxCwV_rV44d1cLhfEbLs3ngtEGQUnZ2zk_g@mail.gmail.com> (raw)
Hi,
In the SLUB allocator, the GFP_WAIT mask bit is used
in allocate_slab to decide if local_irq_enable must be called.
This test is done again later to decide if local_irq_disable
must be called.
I notice that in the SLAB allocator, local_irq_save and
local_irq_restore are called in slab_alloc_node and slab_alloc without
checking the GFP_WAIT bit of the flags parameter.
Am I missing something or is there something to be fixed in the SLAB allocator ?
As I understand the code so far, this could change the state of the irqs
during the execution of start_kernel (init/main.c) for instance.
Could someone give me enlightenment about those points ?
Regards,
--
Nicolas Palix
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2013-06-10 14:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 14:09 Nicolas Palix [this message]
2013-06-10 15:18 ` Christoph Lameter
2013-06-10 21:27 ` Nicolas Palix
2013-06-10 23:39 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAxaTiNXV_RitbBKxCwV_rV44d1cLhfEbLs3ngtEGQUnZ2zk_g@mail.gmail.com \
--to=nicolas.palix@imag.fr \
--cc=cl@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox