Re: [PATCH] mm: zswap: use ATOMIC_LONG_INIT to initialize zswap_stored_pages

[sun k <sunk67188@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1777 bytes --]

Very helpful! Thanks for the tips!

On Wed, Feb 26, 2025, 11:39 PM David Hildenbrand <david@redhat.com> wrote:

> On 26.02.25 16:32, Sun YangKai wrote:
>
> Something for the future: if you send a v2, indicate that in the patch
> subject ("[PATCH v2]") and ideally, describe the change since v1 under
> the "---", and don't send it as reply to the original patch.
>
>
> > This is currently the only atomic_long_t variable initialized by
> > ATOMIC_INIT macro found in the kernel by using
> > `grep -r atomic_long_t | grep ATOMIC_INIT`
> >
> > This was introduced in 6e1fa555ec77, in which we modified
>
> the correct way to reference to commits ids even in text is the format
> you use below.
>
> But here it's sufficient to not be repetitive and simply say
>
> "We changed the type of zswap_stored_pages to be an atomic_long_t, but
> didn't change the initialization."
>
> Acked-by: David Hildenbrand <david@redhat.com>
>
> > the type of zswap_stored_pages to atomic_long_t,
> > but didn't change the initialization.
> >
> > Fixes: 6e1fa555ec77 ("mm: zswap: modify zswap_stored_pages to be
> atomic_long_t")
> > Signed-off-by: Sun YangKai <sunk67188@gmail.com>
> > ---
> >   mm/zswap.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/mm/zswap.c b/mm/zswap.c
> > index ac9d299e7d0c..23365e76a3ce 100644
> > --- a/mm/zswap.c
> > +++ b/mm/zswap.c
> > @@ -43,7 +43,7 @@
> >   * statistics
> >   **********************************/
> >   /* The number of compressed pages currently stored in zswap */
> > -atomic_long_t zswap_stored_pages = ATOMIC_INIT(0);
> > +atomic_long_t zswap_stored_pages = ATOMIC_LONG_INIT(0);
> >
> >   /*
> >    * The statistics below are not protected from concurrent access for
>
>
> --
> Cheers,
>
> David / dhildenb
>
>

[-- Attachment #2: Type: text/html, Size: 2517 bytes --]