From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A53CCF9C6F for ; Mon, 23 Sep 2024 20:21:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9AC2D6B0085; Mon, 23 Sep 2024 16:21:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95B8E6B0088; Mon, 23 Sep 2024 16:21:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 822F96B0089; Mon, 23 Sep 2024 16:21:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 611A66B0085 for ; Mon, 23 Sep 2024 16:21:04 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 09FD0121582 for ; Mon, 23 Sep 2024 20:21:04 +0000 (UTC) X-FDA: 82597122048.30.8242F8A Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf02.hostedemail.com (Postfix) with ESMTP id 039AF8000F for ; Mon, 23 Sep 2024 20:21:00 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DFDd0Fgk; spf=pass (imf02.hostedemail.com: domain of chantr4@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=chantr4@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727122743; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NleUZATndt1acwKzBa7y/6tS+SaA3XdbIXpdmDlWmuM=; b=MRUaVYKvqFxhhdC9ppLQq/2f8XM29j/CXDrz5isqhfQzeJjP5cTcTt9Mx8ocKyHQNTQs3G dH7S+J5XF0T2Irph9h9u3CTnGPCluXpgh7dYJgtNgdxRcblNdtzroFrIqPtx0LHxUrSEXP 50JaWsUuKd13BQVBrLTVNP1EEdnF0xI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727122743; a=rsa-sha256; cv=none; b=myzONXHt7/4CTI+RkiQpHx9ErflyOvDRfFQjU4/adtTh/ea4VZUv5a06cj/8e5RXLmg2ot n1uhBZRa8Mzw0bBlEhCHcgHfTEyc3JaGsjl9ravuM9H0T+n/ACDlBH3vBKgfZLvA5tmbEN q83fyhRL2TCEasykMQemZswDGYDP61s= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DFDd0Fgk; spf=pass (imf02.hostedemail.com: domain of chantr4@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=chantr4@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-5356ab89665so5636887e87.1 for ; Mon, 23 Sep 2024 13:21:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727122859; x=1727727659; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NleUZATndt1acwKzBa7y/6tS+SaA3XdbIXpdmDlWmuM=; b=DFDd0FgkEfFt2MKio4alGod3F5v6lMmOZ9H2yEPr/iwbxNBGDHKPeboNlje+R5YjCY n8Xv0baLhLtSrY+fZvfiydBXUDrAVnmopu497f9AjGYURk4XBipAtpaJ0oCDrk81Cpy6 JVB0Yfzy6N4ofvRrIVR/SSMLzsQJF3LLsGrj/0warVpZbRROAlc8dJ0vB8vbY6h+k1aF 3BazTuQbrB8pEvPsjMMXHN2gFs/SqOf4SQsqpigycB4RfSQnnJooG2UvxicT1AGedjnL Y+OCNJU52K8dEQlkTzWg6XdAL3C24ikfuw9PJi+lsskCWeFStl+LbZI6YlJWvxy0Eqza cQ7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727122859; x=1727727659; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NleUZATndt1acwKzBa7y/6tS+SaA3XdbIXpdmDlWmuM=; b=Z79u4q7K3W7JkdK1Ko7N1dCnELIjNVtqbVVRS0iA9LeoxCzuc+Rsesbhex/lhBjb2C mzGJx/hdIvpf+q505bK8O6ZTTkAHGBDnwvHtPlG5ZTjJBVqzc9ebuZpVKNZfHsiSub6D kW3ENGmrPc3NbetdzJ71tya78mswN2PoU9DDZb5IHH7VofKinTKjerVecOMU49r/5iQY VoZUiZeIhSKYWNRxSs6kxcurt8mn8VZIcy+vAd39ChzVNXQa8iy4SJPYdZdOevRoC3rl 0nPpvy5wvdtxtA/3FZx+PktBtNObxngorMD//grtLibIAYw6CNz8AQ/HGHnGrCG1eTR4 3xXg== X-Forwarded-Encrypted: i=1; AJvYcCVdBjVVHFkGcZQyNKEBA0W1oreZgHpNIqCLZ2iE0iAR6hJ+vijVRJFwcYI+Lnd2BP+EnZXggdLpyQ==@kvack.org X-Gm-Message-State: AOJu0Yz6xmIQnmxnnQ5NMSJOOZFv223v+i+bKdgVuBmaYkWk3QtXSXEN DKxgR4LM5clZa4K0hCJfDUXiuldMvOYLuTlv6L8rJlO6vI20pxjow8Pv7w6O7q7rhV+NUm+vcpg sX54HoUhYxCxowvhoUIrxy2/t+Vk= X-Google-Smtp-Source: AGHT+IFe6pzcf17Wh1gjew0V8YTIVeE9hLlPHLiePqr1rh/borgYiDBhQWNwMIzi8TlRjg6PaEMoWqREOxcDUAURZmM= X-Received: by 2002:a05:6512:6c3:b0:535:63a3:c7d1 with SMTP id 2adb3069b0e04-536ad3b7f23mr6933488e87.48.1727122858742; Mon, 23 Sep 2024 13:20:58 -0700 (PDT) MIME-Version: 1.0 References: <20240814203850.2240469-20-dhowells@redhat.com> <20240923183432.1876750-1-chantr4@gmail.com> <912766.1727120313@warthog.procyon.org.uk> In-Reply-To: <912766.1727120313@warthog.procyon.org.uk> From: Manu Bretelle Date: Mon, 23 Sep 2024 13:20:47 -0700 Message-ID: Subject: Re: [PATCH v2 19/25] netfs: Speed up buffered reading To: David Howells Cc: asmadeus@codewreck.org, ceph-devel@vger.kernel.org, christian@brauner.io, ericvh@kernel.org, hsiangkao@linux.alibaba.com, idryomov@gmail.com, jlayton@kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, marc.dionne@auristor.com, netdev@vger.kernel.org, netfs@lists.linux.dev, pc@manguebit.com, smfrench@gmail.com, sprasad@microsoft.com, tom@talpey.com, v9fs@lists.linux.dev, willy@infradead.org, eddyz87@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 039AF8000F X-Stat-Signature: f7cgrgq4e3f7wjix56ir1pgrtofmswud X-HE-Tag: 1727122860-789401 X-HE-Meta: U2FsdGVkX1/QftfiE+eWj442/QbS+aUKoqQyR1wOk04liCFHxafqziXF8XUbXOnAo71Qi9d1VGOhez7RTASKHU/NyoY3PrWaPZQ4tg4DLoEEAlAqlwCFNApr9kqTgC/o/tKTI6b2PeK1XUx+AD29cF9lkcTF2gGWKdK0dNrqwVIveQX4McBTHWlYhsGSnoz88+RgWA4ykFvO/H5M9M9bpwAPX+cHWGoRISM07c8jB9vb99mB8nsYLsYn2xSA0UuUQOBWH97jZs/mkf2BZWj5fAA+caDgZBeNpoNA+KG2JFzLuc7FkPLow/105wLou0U+AoXw04RefrWHZcFRd12/uk/9V/XJLrmWems0J1o5r7vWMXouxeSkix/7S5Adal6GWYgxxLlNtL85UF+zBMJTPvOp4a2YuQivadHx+/XeWcBvawdbiFTL13PHeMbmruCpVOUdL4Pa90KEFwi6jEIHaDT55P15xNY/WgjpTtKitF84OKsY2xupU9ZifgpLoQfdZRCm0LDF0m/CUw8dpob5jbHoZAg0iJSwkmSVesH223FuPKq25k6gBaOb9/iosN9LTFsffmGFnyvJcdbqX4xpQXMIOdn5QsHX9jLkh2cCE5D4tZIPtHCKwNesc7avuhVGu3BcTkz86fh6pSBQaDDRR6BQY2YflsXZ7gXCLRRY+dOvQiCUm/XYPBAkjAFoG89/bQ+KWe0REGkbiS4i72d/RslkgA/96UZ/m861O4KD5Ll9GJ/u2/mFiiiizXBmfb88/KNXmlirr60pT8p7mMxDQwqMnBr5YwhIPc5WClBZIuJZ/9/J8mjVaG+dCb9X/iHkkop77nsW1oFy3gfWwgo/i9ZkqcAmLN088FEN0SwRZuGVbaCSQXpyZCZK+PcfevkhVWSgWIfUrW0lJHsLBEM+STV43DXqZ/YV/1gen2syI0/mOf8FFq+nOYoLPIZJ4ww2AB4/wXWEQjPyo74L9Gq 6h8VqDD/ JYEFlEpTcWEMZwVZYHDceRWHvm2uuf4iBSkPcp510SVDK8AF+MfQp7kgT2x6bDjJb33LgZcKbubchHpTQvUTu/Z5sOzxh7D9mctLc3Ff7MuHV/yoKVzmpRyDyyGTl7E7EXMsyS+wR1M8gnWMQBL2R2eDWdpyXQwwwWzjOthAKRwpU/zgJKw1PXIqw0EWcGz0Tnkv8OGVAJIC43YT32zGt4vRdtwooaldfog6bI/3RObxR1iKdSJ+0X0GhgsMwTEMfZM7Gzz+g0nWBBbA34Q6L1XJPl2E/1iXkjB2VTDQPFWikXn6W/QLibRjJv8mCXXKaQnD4yRcw1JHWINVCKUKyR04ceroaOOkFbZp2ffRgEpVMrpZ1bbXLnrHg8Cs59vea4mM96vkiKVAXImABtF76QUzrzspJrptu5Gmeiuwjqfa099WPvy76hCV8wsZVJ1jbG4HPH0bViIWGzFwhAiZDNwZUDg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 23, 2024 at 12:38=E2=80=AFPM David Howells wrote: > > Hi Manu, > > Are you using any other network filesystem than 9p, or just 9p? Should be 9p only. We ended up reverting the whole merge with https://patch-diff.githubusercontent.com/raw/kernel-patches/vmtest/pull/288= .patch as my initial commit revert happened to work because of the left over cached .o. FWIW, I quickly checked and virtiofs is not affected. e.g is I was to apply https://github.com/danobi/vmtest/pull/88 to vmtest and recompile the kernel with: CONFIG_FUSE_FS=3Dy CONFIG_VIRTIO_FS=3Dy CONFIG_FUSE_PASSTHROUGH=3Dy qemu-system-x86_64 "-nodefaults" "-display" "none" \ "-serial" "mon:stdio" "-enable-kvm" "-cpu" "host" \ "-qmp" "unix:/tmp/qmp-895732.sock,server=3Don,wait=3Doff" \ "-chardev" "socket,path=3D/tmp/qga-733184.sock,server=3Don,wait=3Doff,id= =3Dqga0" \ "-device" "virtio-serial" \ "-device" "virtserialport,chardev=3Dqga0,name=3Dorg.qemu.guest_agent.0" \ "-object" "memory-backend-memfd,id=3Dmem,share=3Don,size=3D4G" "-numa" "node,memdev=3Dmem" \ "-device" "virtio-serial" "-chardev" "socket,path=3D/tmp/cmdout-713466.sock,server=3Don,wait=3Doff,id=3Dcmdout" = \ "-device" "virtserialport,chardev=3Dcmdout,name=3Dorg.qemu.virtio_serial.= 0" \ "-chardev" "socket,id=3Droot,path=3D/tmp/virtiofsd-807478.sock" \ "-device" "vhost-user-fs-pci,queue-size=3D1024,chardev=3Droot,tag=3Drootf= s" \ "-kernel" "/data/users/chantra/linux/arch/x86/boot/bzImage" \ "-no-reboot" "-append" "rootfstype=3Dvirtiofs root=3Drootfs rw earlyprintk=3Dserial,0,115200 printk.devkmsg=3Don console=3D0,115200 loglevel=3D7 raid=3Dnoautodetect init=3D/tmp/vmtest-initBdg4J.sh panic=3D-1= " \ "-chardev" "socket,id=3Dshared,path=3D/tmp/virtiofsd-992342.sock" \ "-device" "vhost-user-fs-pci,queue-size=3D1024,chardev=3Dshared,tag=3Dvmt= est-shared" \ "-smp" "2" "-m" "4G" would work. Manu > > David >