Re: [PATCH] mm/show_mem: update printk/pr_info messages and replace legacy printk(KERN_CONT ...) with pr_cont()

[Manish Kumar <manish1588@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1645 bytes --]

Hi,

Thanks for the feedback. I understand now that printk→pr_* cleanups are not
accepted as standalone cosmetic patches. I will drop this patch and focus
on patches with real fixes.

Best regards,
Manish Kumar

On Fri, Sep 19, 2025 at 12:16 PM Vlastimil Babka <vbabka@suse.cz> wrote:

> Changelog should not be empty even for trivial patches.
>
> On 9/18/25 20:14, Manish Kumar wrote:
> > Signed-off-by: Manish Kumar <manish1588@gmail.com>
>
> This changes 2 of X in the file. Why only these 2? And no, I'm not
> encouraging to resend with a full file changes. We do these modernizations
> to new APIs only while changing the code for other reasons, not separately,
> if there's nothing wrong otherwise with the legacy api. The churn isn't
> worth it.
>
> > ---
> >  mm/show_mem.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/mm/show_mem.c b/mm/show_mem.c
> > index 0cf8bf5d832d..798949d10ce1 100644
> > --- a/mm/show_mem.c
> > +++ b/mm/show_mem.c
> > @@ -26,7 +26,7 @@ unsigned long totalcma_pages __read_mostly;
> >  static inline void show_node(struct zone *zone)
> >  {
> >       if (IS_ENABLED(CONFIG_NUMA))
> > -             printk("Node %d ", zone_to_nid(zone));
> > +             pr_info("Node %d ", zone_to_nid(zone));
> >  }
> >
> >  long si_mem_available(void)
> > @@ -156,7 +156,7 @@ static void show_migration_types(unsigned char type)
> >       }
> >
> >       *p = '\0';
> > -     printk(KERN_CONT "(%s) ", tmp);
> > +     pr_cont("(%s) ", tmp);
> >  }
> >
> >  static bool node_has_managed_zones(pg_data_t *pgdat, int max_zone_idx)
>
>

[-- Attachment #2: Type: text/html, Size: 2283 bytes --]