Re: CK2 [08/15] slab: Use common kmalloc_index/kmalloc_size functions

[JoonSoo Kim <js1304@gmail.com>]

2012/10/19 Christoph Lameter <cl@linux.com>:

> @@ -693,20 +657,19 @@ static inline struct array_cache *cpu_ca
>  static inline struct kmem_cache *__find_general_cachep(size_t size,
>                                                         gfp_t gfpflags)
>  {
> -       struct cache_sizes *csizep = malloc_sizes;
> +       int i;
>
>  #if DEBUG
>         /* This happens if someone tries to call
>          * kmem_cache_create(), or __kmalloc(), before
>          * the generic caches are initialized.
>          */
> -       BUG_ON(malloc_sizes[INDEX_AC].cs_cachep == NULL);
> +       BUG_ON(kmalloc_caches[INDEX_AC] == NULL);
>  #endif
>         if (!size)
>                 return ZERO_SIZE_PTR;
>
> -       while (size > csizep->cs_size)
> -               csizep++;
> +       i = kmalloc_index(size);

Above kmalloc_index(size) is called with arbitrary size, therefore it
cannot be folded.
This make size of code larger than before,
although '[15/15] Common Kmalloc cache determination' fix this issue properly.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>