From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx104.postini.com [74.125.245.104]) by kanga.kvack.org (Postfix) with SMTP id 9E8266B004D for ; Fri, 1 Jun 2012 08:18:24 -0400 (EDT) Received: by obbwd18 with SMTP id wd18so3612594obb.14 for ; Fri, 01 Jun 2012 05:18:23 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1336665378-2967-1-git-send-email-js1304@gmail.com> Date: Fri, 1 Jun 2012 21:18:23 +0900 Message-ID: Subject: Re: [PATCH] slub: change cmpxchg_double_slab in get_freelist() to __cmpxchg_double_slab From: JoonSoo Kim Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Pekka Enberg Cc: David Rientjes , Christoph Lameter , linux-kernel@vger.kernel.org, linux-mm@kvack.org, torvalds@linux-foundation.org > We now made get_freelist() *require* interrupts to be disabled which > deserves a comment, no? I resend patch(18 May) related to this comment. See below link. http://thread.gmane.org/gmane.linux.kernel.mm/78630/focus=78701 > Also, what do we gain from patches like this? It's somewhat > counterintuitive that we have a function with "cmpxchg" in it which is not > always atomic (i.e. you need to have interrupts disabled). Hmm... This patch have a minor impact which saves a few instructions. But we already have a "__cmpxchg" version which works in irq disabled, so there is no reason for not applying it. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org