From: JoonSoo Kim <js1304@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: David Rientjes <rientjes@google.com>,
Christoph Lameter <cl@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH] slub: change cmpxchg_double_slab in get_freelist() to __cmpxchg_double_slab
Date: Fri, 1 Jun 2012 21:18:23 +0900 [thread overview]
Message-ID: <CAAmzW4PYMExvnCPjLphEOCiqjGMy6TxVQCtvQdW8tew4kNQ0uw@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.02.1206010934460.2163@tux.localdomain>
> We now made get_freelist() *require* interrupts to be disabled which
> deserves a comment, no?
I resend patch(18 May) related to this comment.
See below link.
http://thread.gmane.org/gmane.linux.kernel.mm/78630/focus=78701
> Also, what do we gain from patches like this? It's somewhat
> counterintuitive that we have a function with "cmpxchg" in it which is not
> always atomic (i.e. you need to have interrupts disabled).
Hmm...
This patch have a minor impact which saves a few instructions.
But we already have a "__cmpxchg" version which works in irq disabled,
so there is no reason for not applying it.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-06-01 12:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 15:56 Joonsoo Kim
2012-05-15 6:32 ` David Rientjes
2012-05-31 20:52 ` David Rientjes
2012-06-01 6:39 ` Pekka Enberg
2012-06-01 12:18 ` JoonSoo Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAmzW4PYMExvnCPjLphEOCiqjGMy6TxVQCtvQdW8tew4kNQ0uw@mail.gmail.com \
--to=js1304@gmail.com \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox