From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9028BC4363D for ; Fri, 25 Sep 2020 08:58:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EF86822211 for ; Fri, 25 Sep 2020 08:58:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cg1GOiq7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF86822211 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5FFD48E0001; Fri, 25 Sep 2020 04:58:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58B996B0062; Fri, 25 Sep 2020 04:58:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4505A8E0001; Fri, 25 Sep 2020 04:58:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0243.hostedemail.com [216.40.44.243]) by kanga.kvack.org (Postfix) with ESMTP id 2C5AE6B005C for ; Fri, 25 Sep 2020 04:58:38 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id EB519180AD801 for ; Fri, 25 Sep 2020 08:58:37 +0000 (UTC) X-FDA: 77300983074.26.wool85_1c0441d27166 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id C36A51804B655 for ; Fri, 25 Sep 2020 08:58:37 +0000 (UTC) X-HE-Tag: wool85_1c0441d27166 X-Filterd-Recvd-Size: 4266 Received: from mail-qv1-f67.google.com (mail-qv1-f67.google.com [209.85.219.67]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Fri, 25 Sep 2020 08:58:37 +0000 (UTC) Received: by mail-qv1-f67.google.com with SMTP id ef16so937009qvb.8 for ; Fri, 25 Sep 2020 01:58:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=OBfQBhGGCt8PtYce4ad54bvtM0tuNhXLyEjVZdn2vo0=; b=cg1GOiq7LOLUUr2ZPF9UOQZEhGyHkiSH4usJtyGlc93pFYyp3MeuFIAVNCNgi9hdzv 0fs/VTuatMxzKDQoGO3SfWiIa9zZ5CQlkqu7wcl/s5Lyr9A4ughJC/Yd0amLbg1aBQ7P ALa+P759USwyHBfmdRPqNhUxVjzjDd73Lvla4loc/jOKPZB6CeDv9VfSo6uEAURq3m3I Cu7eqRj3/VRCcMDiaqTKrFR1ippd4ooml63d+7fkKuZIb7arWiFJ1hZ3RHtYjYjssm/r ILjoaJeU0Ds4MRcZW4luRMPTzX/NqFGQgbKYVOjuhhSMI3gltC5fphntE7eEjXvrwZ5D VBBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=OBfQBhGGCt8PtYce4ad54bvtM0tuNhXLyEjVZdn2vo0=; b=gibXtk82jEYRSDt0ak6Ik/u5lDa0B17PrsmCKtv9KlvWiaDx4O4DTMJ+aM8vHQebyZ KyTUAFBtr85RTyPhNnJXgoqx1/HBQAfjfS4reN3gaWxUPjP5rPOQB+cC+SYvKZlMLrdj sLt373HXiOZRzYW9Jq/cmmNkcVJCvXvx4sJ6JIZ4MXFiHMhhzbDuGYAJU4IQelMgU6fH DifMxu2OEL3ECE1qFfdp1PzsXwzO4twhAjJRzqjjwX6JjDSDm6xnv2HIGwf/8xIBXEnL tZCy7B5nl2pbu7khCQtwzs3p0bLejp3nglqJxz8nSPXa/ne9T8YkChIx+x9Rf7k3rbPI ev7A== X-Gm-Message-State: AOAM533HkSUrPwcl6RGAX3IxBqerTcbJVAPtfDFqxe0iZqdtG2UnIriI T7sLrZJE0vdF1g4EKYqxVGUQm3tUoGLLNOM2Iv0= X-Google-Smtp-Source: ABdhPJyBvT5P50o5JK02BpCl7OikwzHKhA1tuwZnSZz9R0J0c7m5++Jp0WKkdcMIhof83aKVOfo8XDzSq1c6s7BDDdI= X-Received: by 2002:a05:6214:292:: with SMTP id l18mr3371262qvv.3.1601024316752; Fri, 25 Sep 2020 01:58:36 -0700 (PDT) MIME-Version: 1.0 References: <1598331582-19923-1-git-send-email-iamjoonsoo.kim@lge.com> <20200827133523.GC3090@techsingularity.net> In-Reply-To: From: Joonsoo Kim Date: Fri, 25 Sep 2020 17:58:25 +0900 Message-ID: Subject: Re: [PATCH for v5.9] mm/page_alloc: handle a missing case for memalloc_nocma_{save/restore} APIs To: Vlastimil Babka Cc: Mel Gorman , Andrew Morton , Linux Memory Management List , LKML , Michal Hocko , "Aneesh Kumar K . V" , kernel-team@lge.com, Joonsoo Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2020=EB=85=84 9=EC=9B=94 25=EC=9D=BC (=EA=B8=88) =EC=98=A4=ED=9B=84 5:55, V= lastimil Babka =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > On 9/25/20 6:59 AM, Joonsoo Kim wrote: > > 2020=EB=85=84 8=EC=9B=94 28=EC=9D=BC (=EA=B8=88) =EC=98=A4=EC=A0=84 8:5= 4, Joonsoo Kim =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > > > Hello, Andrew and Vlastimil. > > > > It's better to fix this possible bug introduced in v5.9-rc1 before > > v5.9 is released. > > Which approach do you prefer? > > If it is determined, I will immediately send a patch as you suggested. > > Hmm both Mel and I preferred the bypass approach and nobody else weighted= in, so > if you don't mind, you can use my suggestion. Hmm maybe alloc_flags & ALL= OC_CMA > check should precede migratetype check in the if () to optimize for users= pace > allocations? Okay! I will implement a bypass approach and send it early next week. Thanks.