From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFF81C433DF for ; Wed, 1 Jul 2020 06:18:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9DD7A20760 for ; Wed, 1 Jul 2020 06:18:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dHI5glD5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9DD7A20760 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0B1978D0001; Wed, 1 Jul 2020 02:18:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 061AE6B0031; Wed, 1 Jul 2020 02:18:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDF9A8D0001; Wed, 1 Jul 2020 02:18:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0176.hostedemail.com [216.40.44.176]) by kanga.kvack.org (Postfix) with ESMTP id D84AE6B0030 for ; Wed, 1 Jul 2020 02:18:29 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 635C6181AC9CB for ; Wed, 1 Jul 2020 06:18:29 +0000 (UTC) X-FDA: 76988502738.21.tray02_5c0a24d26e7e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id 38D60180442C2 for ; Wed, 1 Jul 2020 06:18:29 +0000 (UTC) X-HE-Tag: tray02_5c0a24d26e7e X-Filterd-Recvd-Size: 5093 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Wed, 1 Jul 2020 06:18:28 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id e11so21187617qkm.3 for ; Tue, 30 Jun 2020 23:18:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=mrmTZmnOtw4qO5wq5D6v7IlGV7qQRDmhjYP9i2HjtA0=; b=dHI5glD50UnPuu677fam1ZaQF5rT/cKadHXJt2ZyQc3/14VxnkXNz2t2Sg8df4eFPX CI2xqKfz1q6qb+dAoOWQKhztATFIruJK76kHxp9aUWFlic5V+ciQ5t/FJJ5YqJj+jRD3 a0pbuWGEhPALo3a9ebrMNoO2SK97IoSWEqo9PnHiagCwm7tRp+gk6ssbmwnbsc2rBPoG PVm+0nxvT+OtL9MSauvJG0dyuHv2YkUdej/KxAhIcz6JEPVlHeTIdgOvm0zmia4Wjv+0 +Qwsw9fUOiAOLd8Q0sJzj8xjVCekLrMavcBmElNfXNcG2Ex+3TphT9bhQQTsDDxkUYIC p+eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=mrmTZmnOtw4qO5wq5D6v7IlGV7qQRDmhjYP9i2HjtA0=; b=EuEQ7OAYxRvEJaXZdP5kREX/iWGXF8EHecTPSurxN5oPKzKQCO2w+Qfk/DjezDJlO5 8dAMtzIYDVO0IkMGICyKiPrGsd7JmVkc/s6dwX4XK6IImL6v36LHG3K6YeblZHib5sFl 6yTmJKhBAW2p6L9qiwtEcHLaMUxpDdsBuAc8j5eEAXD/25ABLADScdd9CzouP9LtbWNg tvKC8y4muQwuf6rsSkuV7imld0tesr9IaoVb9QFRqzhsK5qEWaT6izW8cLJ/KfIRiptL JFdmC4RGTu3PiT8FlEHWZZ8blNLZnWQTTtlMnW3GrVAw/QSaG2OFZ11X3Ms/ZZq2QJjX jlJQ== X-Gm-Message-State: AOAM5305T1FkNgrTfFlDkm4w6taDZWS7EHrdW7keJTj/d+UxTWlO/E2A NU5ZBcSQ3bqtc29MlrY2zcIGGNjkZt2KyOXMegQ= X-Google-Smtp-Source: ABdhPJzUk20AhrOT78yKkoIsAOBFs/Y51ri5z57YlLZDocB+kim2j+V5MFNtbXx3zIvbkM852miwdQXOr7b8GwKfPlI= X-Received: by 2002:a37:7d86:: with SMTP id y128mr16397859qkc.343.1593584308177; Tue, 30 Jun 2020 23:18:28 -0700 (PDT) MIME-Version: 1.0 References: <1592371583-30672-1-git-send-email-iamjoonsoo.kim@lge.com> <1592371583-30672-2-git-send-email-iamjoonsoo.kim@lge.com> <7a5c8298-a1e5-93f9-eea6-214b0732ca33@suse.cz> In-Reply-To: <7a5c8298-a1e5-93f9-eea6-214b0732ca33@suse.cz> From: Joonsoo Kim Date: Wed, 1 Jul 2020 15:18:12 +0900 Message-ID: Subject: Re: [PATCH v6 1/6] mm/vmscan: make active/inactive ratio as 1:1 for anon lru To: Vlastimil Babka Cc: Andrew Morton , Linux Memory Management List , LKML , Johannes Weiner , Michal Hocko , Hugh Dickins , Minchan Kim , Mel Gorman , kernel-team@lge.com, Joonsoo Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 38D60180442C2 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000136, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2020=EB=85=84 7=EC=9B=94 1=EC=9D=BC (=EC=88=98) =EC=98=A4=EC=A0=84 2:27, Vl= astimil Babka =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > On 6/17/20 7:26 AM, js1304@gmail.com wrote: > > From: Joonsoo Kim > > > > Current implementation of LRU management for anonymous page has some > > problems. Most important one is that it doesn't protect the workingset, > > that is, pages on the active LRU list. Although, this problem will be > > fixed in the following patchset, the preparation is required and > > this patch does it. > > > > What following patchset does is to restore workingset protection. In th= is > > "Restore" sounds as if the protection used to be there and then it was re= moved. > If it's the case, it should be said what commit did that. Otherwise I wou= ld say > "implement", not "restore"? > > > case, newly created or swap-in pages are started their lifetime on the > > I would rephrase it: "After the following patch, newly created or swap-in= pages > will start their lifetime... " > > > inactive list. If inactive list is too small, there is not enough chanc= e > > to be referenced and the page cannot become the workingset. > > > > In order to provide enough chance to the newly anonymous pages, this pa= tch > > "In order to provide the newly anonymous pages enough chance to be refere= nced > again..." > > > makes active/inactive LRU ratio as 1:1. > > Here I would add: > > This is just a temporary measure. Later patch in the series introduces > workingset detection for anonymous LRU that will be used to better decide= if > pages should start on the active and inactive list. Afterwards this patch= is > effectively reverted. > > > Acked-by: Johannes Weiner > > Signed-off-by: Joonsoo Kim > > Acked-by: Vlastimil Babka Thanks! I will change the commit description as you suggested. Thanks.