From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx118.postini.com [74.125.245.118]) by kanga.kvack.org (Postfix) with SMTP id 4069F6B0072 for ; Mon, 16 Jul 2012 13:32:08 -0400 (EDT) Received: by yhr47 with SMTP id 47so6554339yhr.14 for ; Mon, 16 Jul 2012 10:32:07 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1342455272-32703-1-git-send-email-js1304@gmail.com> Date: Tue, 17 Jul 2012 02:32:07 +0900 Message-ID: Subject: Re: [PATCH 1/3] mm: correct return value of migrate_pages() From: JoonSoo Kim Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Lameter Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org 2012/7/17 Christoph Lameter : > On Tue, 17 Jul 2012, Joonsoo Kim wrote: > >> migrate_pages() should return number of pages not migrated or error code. >> When unmap_and_move return -EAGAIN, outer loop is re-execution without >> initialising nr_failed. This makes nr_failed over-counted. > > The itention of the nr_failed was only to give an indication as to how > many attempts where made. The failed pages where on a separate queue that > seems to have vanished. > >> So this patch correct it by initialising nr_failed in outer loop. > > Well yea it makes sense since retry is initialized there as well. > > Acked-by: Christoph Lameter Thanks for comment. Additinally, I find that migrate_huge_pages() is needed identical fix as migrate_pages(). @@ -1029,6 +1030,7 @@ int migrate_huge_pages(struct list_head *from, for (pass = 0; pass < 10 && retry; pass++) { retry = 0; + nr_failed = 0; list_for_each_entry_safe(page, page2, from, lru) { cond_resched(); When I resend with this, could I include "Acked-by: Christoph Lameter "? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org