From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C991ECAAD3 for ; Wed, 14 Sep 2022 14:49:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 27DE68D0002; Wed, 14 Sep 2022 10:49:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22D4E8D0001; Wed, 14 Sep 2022 10:49:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11C918D0002; Wed, 14 Sep 2022 10:49:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 035A08D0001 for ; Wed, 14 Sep 2022 10:49:48 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CE62C160138 for ; Wed, 14 Sep 2022 14:49:47 +0000 (UTC) X-FDA: 79910975214.16.15F3759 Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) by imf31.hostedemail.com (Postfix) with ESMTP id 90D8C200B5 for ; Wed, 14 Sep 2022 14:49:47 +0000 (UTC) Received: by mail-oo1-f44.google.com with SMTP id t4-20020a4aa3c4000000b00475624f2369so1730430ool.3 for ; Wed, 14 Sep 2022 07:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=kJ9cObmCfJy7zayueRZ8avT0ZkBC3fAXveiFVXW2d3c=; b=BS8LjY8kVKMrnEmhnKSq83R4AizxpIgEbctiVDPMRcdKOmBMECLYxiTY+zmFs9d/Am Zp0NwuDgfToaqteR8JP4GOo7qgCTMbz/9pw9grsuTo+3xmlA67gGc+c4tdcBdEslPqXQ cRaJDWOIXWvkeLsBnVclQAgo7wJ+2Y1vkW7ukrDyi0pGUu0MEJ/TJ3U/zA9frXxZ4PXv GHe9hetUR1JtaCPXOrjBKVVSSo21VdPcBI+zdw4jDL9mf3y4LWC4SClyIdaOKHqcNLVB XmCBcN+UOk2lhGJVwc3JTraZmcdd1AvoTXZyS0XaryNrkZpovJOKgNS2SsofpJ1RR+40 2ocg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=kJ9cObmCfJy7zayueRZ8avT0ZkBC3fAXveiFVXW2d3c=; b=SwcFv8e8Dc9CkbmFCBStNf3jtQlKLCtRjKJOGyoU5liXZ8dGUMCZ6rJTvtLz8mn984 XXZb/BMn3upVWlrlWR+gGBiHizwuDb6OiI13qCr3vG7/Vm6VYQ1oU4g3mkbPSNRyesUg pUoS+d7R5zPQi44h+OtRjb+k2qxt4tfsJurFaZeSV6SWO/hjUxLTJ3AnvZmDhf5iPA/Z hs3WjP7ogKHXDy9y2DgeAXneHPhf61tO8wlJGnRPgBryEkqfLox7Um6Uzht4EN7kq+oG VhD0QIJQGjt8Cygagnz29J2ZPCHP+KbR7AZOkWHy5wA1b9tKfdQCCc8EiXvKPu37Rdbn pB6Q== X-Gm-Message-State: ACgBeo3yKfIChmlKwBgv6NlV9KGaLAJ55lYbkqCtRnhwwHzl8N+o3RN7 ckU2J5mawNIKP9HLlqWzvjWThjwR3BRbRns/IX8= X-Google-Smtp-Source: AA6agR5hbY7TnWmhNQMvFEFho6lqEUCWEj/P/ohu/W7QkUem154xEfPhzk+xspl1CmpWCz2IxmyClW+PwuQx7kBnhqA= X-Received: by 2002:a4a:bf11:0:b0:436:1611:6b51 with SMTP id r17-20020a4abf11000000b0043616116b51mr12780772oop.18.1663166986819; Wed, 14 Sep 2022 07:49:46 -0700 (PDT) MIME-Version: 1.0 References: <20220815072835.74876-1-yang.yang29@zte.com.cn> In-Reply-To: <20220815072835.74876-1-yang.yang29@zte.com.cn> From: Joonsoo Kim Date: Wed, 14 Sep 2022 23:49:35 +0900 Message-ID: Subject: Re: [PATCH v2 2/2] mm/page_io: count submission time as thrashing delay for delayacct To: cgel.zte@gmail.com Cc: akpm@linux-foundation.org, iamjoonsoo.kim@lge.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Yang , Ran Xiaokai , wangyong Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BS8LjY8k; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf31.hostedemail.com: domain of js1304@gmail.com designates 209.85.161.44 as permitted sender) smtp.mailfrom=js1304@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663166987; a=rsa-sha256; cv=none; b=CHOEQQt/V+52QNRpsflagSJzL1JRqbnw4LbWiIC5mk3jiYqO9dF1TtrR0qIFpmDZwrvfnc //FX3jM7mV0GZBMp3Z6NA52WR8fq1OcmK3DrVceVH39aiHzD5qv3MFjHN1n5Tj8IuO7AgD 8TgViM5cqe8tGuHWcUXwxNHrv2BKh6U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663166987; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kJ9cObmCfJy7zayueRZ8avT0ZkBC3fAXveiFVXW2d3c=; b=OGr+PkmIbfELpqqowcD7DFXIs1wV6StBJXcaxhbPXEphmROPnGXvjPOsAAmdYQ5lWkEXJP O5vCeU+GFtx1bt0IW8+u89dGMQ/xawWirQtbQiChMi3LQB5vkH5e4YoifEQCmzVoIN9bcz ScBGNFcyknNzOzbGMoa8m3F9pkM8+LQ= X-Rspam-User: Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BS8LjY8k; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf31.hostedemail.com: domain of js1304@gmail.com designates 209.85.161.44 as permitted sender) smtp.mailfrom=js1304@gmail.com X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 90D8C200B5 X-Stat-Signature: mjf9a3976so5zcmfozgpawbit4dwsa86 X-HE-Tag: 1663166987-919651 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2022=EB=85=84 8=EC=9B=94 15=EC=9D=BC (=EC=9B=94) =EC=98=A4=ED=9B=84 4:33, <= cgel.zte@gmail.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > From: Yang Yang > > Once upon a time, we only support accounting thrashing of page cache. > Then Joonsoo introduced workingset detection for anonymous pages and > we gained the ability to account thrashing of them[1]. > > Likes PSI, we count submission time as thrashing delay because when > the device is congested, or the submitting cgroup IO-throttled, > submission can be a significant part of overall IO time. It's not the main purpose of this patch. Without this patch, swap thrashing through frontswap or some block device supporting rw_page operation isn't measured correctly. I think that description change is required. Please refer to commit 937790699be9c8100e (mm/page_io.c: annotate refault stalls from swap_readpage). No objection on the code side. Thanks.