linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Joonsoo Kim <js1304@gmail.com>
To: cgel.zte@gmail.com
Cc: akpm@linux-foundation.org, iamjoonsoo.kim@lge.com,
	linux-mm@kvack.org,  linux-kernel@vger.kernel.org,
	Yang Yang <yang.yang29@zte.com.cn>,
	 Ran Xiaokai <ran.xiaokai@zte.com.cn>,
	wangyong <wang.yong12@zte.com.cn>
Subject: Re: [PATCH v2 2/2] mm/page_io: count submission time as thrashing delay for delayacct
Date: Wed, 14 Sep 2022 23:49:35 +0900	[thread overview]
Message-ID: <CAAmzW4ORH=kMbzMg7tpGTF_0Ky4Rb1TZ+W=q=pgppNaRxkScQQ@mail.gmail.com> (raw)
In-Reply-To: <20220815072835.74876-1-yang.yang29@zte.com.cn>

2022년 8월 15일 (월) 오후 4:33, <cgel.zte@gmail.com>님이 작성:
>
> From: Yang Yang <yang.yang29@zte.com.cn>
>
> Once upon a time, we only support accounting thrashing of page cache.
> Then Joonsoo introduced workingset detection for anonymous pages and
> we gained the ability to account thrashing of them[1].
>
> Likes PSI, we count submission time as thrashing delay because when
> the device is congested, or the submitting cgroup IO-throttled,
> submission can be a significant part of overall IO time.

It's not the main purpose of this patch. Without this patch,
swap thrashing through frontswap or some block device supporting rw_page
operation isn't measured correctly. I think that description change is
required. Please refer to commit 937790699be9c8100e
(mm/page_io.c: annotate refault stalls from swap_readpage).

No objection on the code side.

Thanks.


      reply	other threads:[~2022-09-14 14:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-15  7:28 cgel.zte
2022-09-14 14:49 ` Joonsoo Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAmzW4ORH=kMbzMg7tpGTF_0Ky4Rb1TZ+W=q=pgppNaRxkScQQ@mail.gmail.com' \
    --to=js1304@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cgel.zte@gmail.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ran.xiaokai@zte.com.cn \
    --cc=wang.yong12@zte.com.cn \
    --cc=yang.yang29@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox