From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A28FC433E0 for ; Fri, 3 Jul 2020 00:54:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C076420836 for ; Fri, 3 Jul 2020 00:54:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fwdqCTnZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C076420836 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5CB938D001B; Thu, 2 Jul 2020 20:54:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57BE28D0002; Thu, 2 Jul 2020 20:54:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46BB08D001B; Thu, 2 Jul 2020 20:54:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0097.hostedemail.com [216.40.44.97]) by kanga.kvack.org (Postfix) with ESMTP id 311CF8D0002 for ; Thu, 2 Jul 2020 20:54:36 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id EB74F180AD807 for ; Fri, 3 Jul 2020 00:54:35 +0000 (UTC) X-FDA: 76994944110.09.pipe08_5305c9826e8d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id C5AE2180AD80F for ; Fri, 3 Jul 2020 00:54:35 +0000 (UTC) X-HE-Tag: pipe08_5305c9826e8d X-Filterd-Recvd-Size: 4489 Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Jul 2020 00:54:35 +0000 (UTC) Received: by mail-qt1-f196.google.com with SMTP id u12so22765688qth.12 for ; Thu, 02 Jul 2020 17:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=gmp3Sx0pjIvLynX6ju8pg2+6n+L9gz/8CB7hRCXkhfk=; b=fwdqCTnZCLxC184dA8HxziJBoAe0zO52Ae1M2LCViDgVE+qlKTRZt5IInzpUEVU5Jx XXWbiMOEeY5wBa9HQH6Kz2c65qVpf2wc6V50kEx/KgToQCtAwOizLd/F+crebi7LZZEF dRAV7gt1RcMoOPuOjKvT7UrQivfvxZzpnOWrLoXPMBhrxrt0bY3oxOYd6gEQKEUnMpG/ +gLfJqft9x6XvsJd4AUg7/jlfZKZrxkgeiyfFBNPnb5rmtnvkdUth0fJp1lK/XQ3LIkM CKggfbt431MdbhyZWRFMASmWg46z3NdY90ZDn/eOFrl26NFhvpyp+M3Sp9TtJnI+3noY uDvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=gmp3Sx0pjIvLynX6ju8pg2+6n+L9gz/8CB7hRCXkhfk=; b=uNbzp5/fszpojSHdH34FPSYfu4AUcRYH1PAq4Gl/sVOWO4kNwGhppHuC6DwvBgY4sg H8L65u35pvVQhHwJlDwTHxUsl14A/QqKsbnjQfM/JGtYgq8/hYgtZFt3Q3qJ1jogTfkK vHm/FQdEEF+PUN3ka3rFUuHwKWF2fuwW+zQaLRFUL4ySRvLAOWU9tulmDH7DwDc/yQDj 1GvtoVlbH3JI/+7e7vJDnqRfTR5GjMkutj5FXe0OJRRB6BqKG2VKyhY6calFhqIzXCsG TEr00K0JkOYx/pB9IDHV4zmrrCXqBO/Ud64UeSRYgDlXGTMPepVaQSaGZCVrH07tIQsD UYlg== X-Gm-Message-State: AOAM532b3ad/cNLdh8ZbPgB2NW4m4WnKOsfTtAaEvsvcqlV3o1vSX01b 1cao4gfGauWCwye8UczlGrokv+qCGoeuoUK/Mpk= X-Google-Smtp-Source: ABdhPJzsWvh1evlYg5LXH01AzOqky+X9zniwui4WabZN4uqJTUu4SWHWM9IUtD/ko5W0xinzq/Q8ecLMkZZli/hM5U0= X-Received: by 2002:ac8:5691:: with SMTP id h17mr30471835qta.35.1593737674869; Thu, 02 Jul 2020 17:54:34 -0700 (PDT) MIME-Version: 1.0 References: <1592371583-30672-1-git-send-email-iamjoonsoo.kim@lge.com> <1592371583-30672-7-git-send-email-iamjoonsoo.kim@lge.com> In-Reply-To: From: Joonsoo Kim Date: Fri, 3 Jul 2020 09:54:23 +0900 Message-ID: Subject: Re: [PATCH v6 6/6] mm/vmscan: restore active/inactive ratio for anonymous LRU To: Vlastimil Babka Cc: Andrew Morton , Linux Memory Management List , LKML , Johannes Weiner , Michal Hocko , Hugh Dickins , Minchan Kim , Mel Gorman , kernel-team@lge.com, Joonsoo Kim , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: C5AE2180AD80F X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2020=EB=85=84 7=EC=9B=94 2=EC=9D=BC (=EB=AA=A9) =EC=98=A4=ED=9B=84 10:45, V= lastimil Babka =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > On 6/17/20 7:26 AM, js1304@gmail.com wrote: > > From: Joonsoo Kim > > > > Now, workingset detection is implemented for anonymous LRU. > > We don't have to worry about the misfound for workingset due to > > the ratio of active/inactive. Let's restore the ratio. > > How about: > > Now that workingset detection is implemented for anonymous LRU, we don't = need > large inactive list to allow detecting frequently accessed pages before t= hey are > reclaimed, anymore. This effectively reverts the temporary measure put in= by > commit "mm/vmscan: make active/inactive ratio as 1:1 for anon lru". Much better!. I will use the comment you suggested. Thanks. > > Acked-by: Johannes Weiner > > Signed-off-by: Joonsoo Kim > > Acked-by: Vlastimil Babka > > Thanks! > I still hope Matthew can review updated patch 4/6 (I'm not really familia= r with > proper xarray handling), and Johannes patch 5/6. Okay, I hope so, too. :) > And then we just need a nice Documentation file describing how reclaim re= ally > works after all the recent changes :) Agreed. Thanks.