From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52392C10F26 for ; Mon, 23 Mar 2020 05:58:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0AC0F20714 for ; Mon, 23 Mar 2020 05:58:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ugUQ+yGa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AC0F20714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 893168E0005; Mon, 23 Mar 2020 01:58:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 845168E0003; Mon, 23 Mar 2020 01:58:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75AA78E0005; Mon, 23 Mar 2020 01:58:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0182.hostedemail.com [216.40.44.182]) by kanga.kvack.org (Postfix) with ESMTP id 5C0268E0003 for ; Mon, 23 Mar 2020 01:58:27 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A1DF82C1E for ; Mon, 23 Mar 2020 05:58:27 +0000 (UTC) X-FDA: 76625572254.19.cream35_f9fa43e73942 X-HE-Tag: cream35_f9fa43e73942 X-Filterd-Recvd-Size: 5662 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Mon, 23 Mar 2020 05:58:27 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id c145so14074224qke.12 for ; Sun, 22 Mar 2020 22:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=AvPMLnaaQp5jiQnFy8j79lDeL85S2eJpDF4bBEQ7H5k=; b=ugUQ+yGaL0p1o6UW9RpqRggClsYXccqqSB8FplD5exKthFaSGIIM/bgCdB2mzcqEYV rdITpGe+oBPR5P1SiacQUztmoejS3s93zIlvhfO0woTNsQTyojw9/idWSLv9bJkBdC3+ wdy3exjAspK7nQ1RZtj8NwwNEgC3RSwMeIkxtTjlUyq2Amwwtdc7kqlgCtcAsMWhtTcR PYaV1/JOX8XEAIgn49RnI1IsKyYT/ykRpJcb3z61Vpc38FjtywISV/mrRgEfxKkuLTBu RCZ9B6W03gW2S1x7f1y1AFwHaBJaCV91k5kr3D1OlfknszE1EroIHKpwBwd7489/vqAZ iE2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AvPMLnaaQp5jiQnFy8j79lDeL85S2eJpDF4bBEQ7H5k=; b=QhoOte6VtBtr3Qo5dp7HZ5GrN9sVNioBa2wV2sD6E3dH2EJGA1zrdB0ZsSMvw3f8h/ xMTQXXOFyHVgJxqdhAjUpRRDdxhnuZ+8Cm/dOg+QFXxOupm8UqGbVECgsJLNt3EoAHKu Bem7GTuw2KVcsAGikwLw5/7GaVQCvj6BN4QNV7q3PjoyCB/DU8VK2+7oWCghkJkbPqCX gqQifT2pwxsNWn+VLqQQ135rc/y9vZ6RoL5Gry7iz8OAULAa8TSok4jkpF+nPahp3hr3 t7lTfGBeaNePRAYY2C7IJKSH/9YlDKtuGvW0/dH4krTpZIabLkT0g6VD0CSEhW+oDv4G /9Jw== X-Gm-Message-State: ANhLgQ3G96ONL8JV3in8vZNYnCZa7gIJT3NHSBcgZy11dd8r3DGUaNnF n4X3HDyx3CFSVp1QfXuMZwIFFYNvsoM3+JfruyQ= X-Google-Smtp-Source: ADFU+vsBWCsq7LemXTgsY9xAMRzKPXtMG8l3GWSVWCDNby+xGCjk3u8G4lK2lTtg/LTSdXLsaN0TJFhT5c2i65ZAksQ= X-Received: by 2002:a37:8cc1:: with SMTP id o184mr1271395qkd.187.1584943106149; Sun, 22 Mar 2020 22:58:26 -0700 (PDT) MIME-Version: 1.0 References: <1584938972-7430-1-git-send-email-iamjoonsoo.kim@lge.com> <1584938972-7430-3-git-send-email-iamjoonsoo.kim@lge.com> <20200323052145.GD3039@MiWiFi-R3L-srv> <20200323054037.GI2987@MiWiFi-R3L-srv> In-Reply-To: <20200323054037.GI2987@MiWiFi-R3L-srv> From: Joonsoo Kim Date: Mon, 23 Mar 2020 14:58:15 +0900 Message-ID: Subject: Re: [PATCH v4 2/2] mm/page_alloc: integrate classzone_idx and high_zoneidx To: Baoquan He Cc: Andrew Morton , Linux Memory Management List , LKML , Johannes Weiner , Michal Hocko , Minchan Kim , Vlastimil Babka , Mel Gorman , kernel-team@lge.com, Ye Xiaolong , David Rientjes , Joonsoo Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.001038, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2020=EB=85=84 3=EC=9B=94 23=EC=9D=BC (=EC=9B=94) =EC=98=A4=ED=9B=84 2:40, B= aoquan He =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > > diff --git a/include/trace/events/compaction.h b/include/trace/events= /compaction.h > > > index e5bf6ee..54e5bf0 100644 > > > --- a/include/trace/events/compaction.h > > > +++ b/include/trace/events/compaction.h > > > @@ -314,40 +314,44 @@ TRACE_EVENT(mm_compaction_kcompactd_sleep, > > > > > > DECLARE_EVENT_CLASS(kcompactd_wake_template, > > > > > > - TP_PROTO(int nid, int order, enum zone_type classzone_idx), > > > + TP_PROTO(int nid, int order, enum zone_type highest_zoneidx), > > > > > > - TP_ARGS(nid, order, classzone_idx), > > > + TP_ARGS(nid, order, highest_zoneidx), > > > > > > TP_STRUCT__entry( > > > __field(int, nid) > > > __field(int, order) > > > - __field(enum zone_type, classzone_idx) > > > + __field(enum zone_type, highest_zoneidx) > > > ), > > > > > > TP_fast_assign( > > > __entry->nid =3D nid; > > > __entry->order =3D order; > > > - __entry->classzone_idx =3D classzone_idx; > > > + __entry->highest_zoneidx =3D highest_zoneidx; > > > ), > > > > > > + /* > > > + * classzone_idx is previous name of the highest_zoneidx. > > > + * Reason not to change it is the ABI requirement of the tracepoi= nt. > > > + */ > > > TP_printk("nid=3D%d order=3D%d classzone_idx=3D%-8s", > > ~~~~~~~~~~ this one could be missed. > > Oh, I realized above 'classzone_idx=3D%-8s' being kept is for the old > script compatibility? then it's OK. Yes, this is for userspace compatibility. There are two places that aren't changed due to compatibility and they are commented on top of the line. Thanks. > > > > And I applied this patch series, use 'git grep classzone_idx' to search > > any relics, found below classzone_idx leftover in perl script. > > [~]$ git grep classzone_idx > > Documentation/trace/postprocess/trace-vmscan-postprocess.pl:my $regex_l= ru_isolate_default =3D 'isolate_mode=3D([0-9]*) classzone_idx=3D([0-9]*) or= der=3D([0-9]*) nr_requested=3D([0-9]*) nr_scanned=3D([0-9]*) nr_skipped=3D(= [0-9]*) nr_taken=3D([0-9]*) lru=3D([a-z_]*)'; > > Documentation/trace/postprocess/trace-vmscan-postprocess.pl: = "isolate_mode", "classzone_idx", "order",