From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA145C2BA1A for ; Tue, 7 Apr 2020 00:43:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9A87820692 for ; Tue, 7 Apr 2020 00:43:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="um7NZxXe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A87820692 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3BE578E0005; Mon, 6 Apr 2020 20:43:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36EF38E0001; Mon, 6 Apr 2020 20:43:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 284648E0005; Mon, 6 Apr 2020 20:43:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id 0E1BC8E0001 for ; Mon, 6 Apr 2020 20:43:06 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id BA249180AD806 for ; Tue, 7 Apr 2020 00:43:05 +0000 (UTC) X-FDA: 76679209530.22.idea59_1b00511927533 X-HE-Tag: idea59_1b00511927533 X-Filterd-Recvd-Size: 3815 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Apr 2020 00:43:05 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id g7so1418766qtj.13 for ; Mon, 06 Apr 2020 17:43:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=SmqCsp5QxJqlhSsYQltOb14Ug2eJJSL1fJBRe6dPxdw=; b=um7NZxXedFQk5SacVy6+a83LWcrVp2HQuSPCovHadsf0PyHz/f+ogGYG1+iaRFL4F6 eR7IOFKrzGBp5xk5MV8gQuurcmw1hyfwTefhepBco90BPMkH2dT2b0hs9R9PUbzd3byF L3g5SCXclNDadXjNeLHeVTMzNUIUblwaKm/5ELl/fqJ+3iNlPmz5UEM76J55YPi6a5TG lEN7SnSQD6Af/NKs7FJg/ZSR+FMIjNtGAncfSwPlvREE6sUlOhC7KExBhdbhr+tQu8yp yQarjeBx12yjA7N+rmI109tF62YFdAUOWhMpd1CJUdl7DOEazNf7NtIb43hFlHno/xsE qgfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=SmqCsp5QxJqlhSsYQltOb14Ug2eJJSL1fJBRe6dPxdw=; b=GncTc4UsQwdNkKDhHgALQigNCxbmuTtyYkPUiVRaxDIJJK+g/FrC4Npv/Pk2DyHfH5 S98TlDViZ7UjV057USqCDZvnilh+chLlcEMGt/JmVNnuZc5fyd+30EsU0vc050Pb/f0s hupv7MoHeSKXj/sh0glxU+PDga2c29E3zeXV+t4eo985bV7Kps1PUnr8gu/cx0M278aH XlqH9ea9nHg79MIUY4ThHB0JRnBl2lgcIdPU3y0S5KDR/fBondRoIyPkX0ksJ2kaQgu4 mTDVWNuifqS3Mc8fG+GMwLIRBMDlb8CqAyrqf3BxC580jgdxGL2UB3EsnI+4PIBZe8dO TPDg== X-Gm-Message-State: AGi0PuZUhAp2kI7nnMm7Nbfp5idX/KOnsAtWOsgAq7oe80vxE3rJNL0q P0vyRd6mu7TwshONZjyHLpP2pSAjRKgfb+0znbI= X-Google-Smtp-Source: APiQypKFLUlQyC1lpZ+FR4f1LmELwsaGrBqeC81xTHnZcXe1pvBhd2QCNb77gJY7gDkXINi1irADx/SfOkUOgOVRkBM= X-Received: by 2002:aed:3346:: with SMTP id u64mr2137234qtd.333.1586220184881; Mon, 06 Apr 2020 17:43:04 -0700 (PDT) MIME-Version: 1.0 References: <1585892447-32059-1-git-send-email-iamjoonsoo.kim@lge.com> <20200406115804.4440-1-hdanton@sina.com> In-Reply-To: <20200406115804.4440-1-hdanton@sina.com> From: Joonsoo Kim Date: Tue, 7 Apr 2020 09:42:54 +0900 Message-ID: Subject: Re: [PATCH v5 05/10] mm/swap: charge the page when adding to the swap cache To: Hillf Danton Cc: Andrew Morton , Linux Memory Management List , LKML , Johannes Weiner , Michal Hocko , Hugh Dickins , Minchan Kim , Vlastimil Babka , Mel Gorman Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.032903, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2020=EB=85=84 4=EC=9B=94 6=EC=9D=BC (=EC=9B=94) =EC=98=A4=ED=9B=84 8:58, Hi= llf Danton =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > > On Fri, 3 Apr 2020 14:40:43 +0900 Joonsoo Kim wrote: > > > > @@ -153,11 +165,16 @@ int add_to_swap_cache(struct page *page, swp_entr= y_t entry, > > xas_unlock_irq(&xas); > > } while (xas_nomem(&xas, gfp)); > > > > - if (!xas_error(&xas)) > > + if (!xas_error(&xas)) { > > + mem_cgroup_commit_charge(page, memcg, false, compound); > > Add a tp > trace_mm_add_to_swap_cache(page); Please let me know the reason of this comment. IMO, adding a tracepoint isn= 't good idea until it is really necessary since it is considered as kernel ABI and it cannot be changed easily. Thanks.