From: JoonSoo Kim <js1304@gmail.com>
To: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>,
linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
Matt Mackall <mpm@selenic.com>,
Glauber Costa <glommer@parallels.com>,
Alex Shi <alex.shi@intel.com>
Subject: Re: [RFC] Common code 07/12] slabs: Move kmem_cache_create mutex handling to common code
Date: Wed, 23 May 2012 01:19:47 +0900 [thread overview]
Message-ID: <CAAmzW4Nt0S-xmwmHhw0AJEikE91pZpnCS+NQosrxAaUDi59pew@mail.gmail.com> (raw)
In-Reply-To: <20120518161930.978054128@linux.com>
2012/5/19 Christoph Lameter <cl@linux.com>:
> Move the mutex handling into the common kmem_cache_create()
> function.
>
> list_add(&s->list, &slab_caches);
> mutex_unlock(&slab_mutex);
> - if (sysfs_slab_add(s)) {
> - mutex_lock(&slab_mutex);
> - list_del(&s->list);
> - kfree(n);
> - kfree(s);
> - goto err;
> - }
> - return s;
> + r = sysfs_slab_add(s);
> + mutex_lock(&slab_mutex);
> +
> + if (!r)
> + return s;
> +
> + list_del(&s->list);
> + kmem_cache_close(s);
> }
> - kfree(n);
> kfree(s);
> }
Before this patch is applied, can we move calling 'sysfs_slab_add' to
common code
for removing slab_mutex entirely in kmem_cache_create?
next prev parent reply other threads:[~2012-05-22 16:19 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 16:19 [RFC] Common code 00/12] Sl[auo]b: Common functionality V2 Christoph Lameter
2012-05-18 16:19 ` [RFC] Common code 01/12] [slob] define page struct fields used in mm_types.h Christoph Lameter
2012-05-21 8:41 ` Glauber Costa
2012-05-22 14:22 ` JoonSoo Kim
2012-05-22 17:42 ` Christoph Lameter
2012-05-23 14:28 ` JoonSoo Kim
2012-05-18 16:19 ` [RFC] Common code 02/12] [slab]: Use page struct fields instead of casting Christoph Lameter
2012-05-22 14:28 ` JoonSoo Kim
2012-05-18 16:19 ` [RFC] Common code 03/12] Extract common fields from struct kmem_cache Christoph Lameter
2012-05-21 9:21 ` Glauber Costa
2012-05-22 14:39 ` JoonSoo Kim
2012-05-18 16:19 ` [RFC] Common code 04/12] slabs: Extract common code for kmem_cache_create Christoph Lameter
2012-05-21 9:24 ` Glauber Costa
2012-05-21 13:48 ` Christoph Lameter
2012-05-22 15:08 ` JoonSoo Kim
2012-05-22 15:23 ` Glauber Costa
2012-05-22 17:49 ` Christoph Lameter
2012-05-18 16:19 ` [RFC] Common code 05/12] slabs: Common definition for boot state of the slab allocators Christoph Lameter
2012-05-21 9:26 ` Glauber Costa
2012-05-22 15:34 ` JoonSoo Kim
2012-05-18 16:19 ` [RFC] Common code 06/12] slabs: Use a common mutex definition Christoph Lameter
2012-05-22 15:44 ` JoonSoo Kim
2012-05-18 16:19 ` [RFC] Common code 07/12] slabs: Move kmem_cache_create mutex handling to common code Christoph Lameter
2012-05-22 16:19 ` JoonSoo Kim [this message]
2012-05-22 17:51 ` Christoph Lameter
2012-05-18 16:19 ` [RFC] Common code 09/12] slabs: Extract a common function for kmem_cache_destroy Christoph Lameter
2012-05-21 9:34 ` Glauber Costa
2012-05-21 18:13 ` Christoph Lameter
2012-05-21 19:19 ` Glauber Costa
2012-05-21 19:31 ` Christoph Lameter
2012-05-21 20:06 ` Glauber Costa
2012-05-21 20:54 ` Christoph Lameter
2012-05-23 15:39 ` JoonSoo Kim
2012-05-23 15:42 ` Christoph Lameter
2012-05-18 16:19 ` [RFC] Common code 10/12] sl[aub]: Use the name "kmem_cache" for the slab cache with the kmem_cache structure Christoph Lameter
2012-05-21 9:35 ` Glauber Costa
2012-05-23 16:17 ` JoonSoo Kim
2012-05-18 16:19 ` [RFC] Common code 11/12] Move freeing of kmem_cache structure to common code Christoph Lameter
2012-05-23 16:17 ` JoonSoo Kim
2012-05-18 16:19 ` [RFC] Common code 12/12] [slauob]: Get rid of __kmem_cache_destroy Christoph Lameter
2012-05-23 16:42 ` JoonSoo Kim
[not found] ` <20120518161931.570041085@linux.com>
2012-05-21 9:27 ` [RFC] Common code 08/12] slabs: list addition move to slab_common Glauber Costa
2012-05-22 16:22 ` JoonSoo Kim
2012-05-21 9:38 ` [RFC] Common code 00/12] Sl[auo]b: Common functionality V2 Glauber Costa
2012-05-21 13:51 ` Christoph Lameter
2012-05-21 14:15 ` Glauber Costa
2012-06-11 2:25 ` Alex Shi
2012-06-29 3:17 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAmzW4Nt0S-xmwmHhw0AJEikE91pZpnCS+NQosrxAaUDi59pew@mail.gmail.com \
--to=js1304@gmail.com \
--cc=alex.shi@intel.com \
--cc=cl@linux.com \
--cc=glommer@parallels.com \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox