From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFFE2C433E0 for ; Wed, 27 May 2020 06:45:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9ECCF20E65 for ; Wed, 27 May 2020 06:45:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="txx+avA2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9ECCF20E65 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1152A800B6; Wed, 27 May 2020 02:45:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C61A80010; Wed, 27 May 2020 02:45:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1DAA800B6; Wed, 27 May 2020 02:45:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0131.hostedemail.com [216.40.44.131]) by kanga.kvack.org (Postfix) with ESMTP id E8E6C80010 for ; Wed, 27 May 2020 02:45:10 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BAA6B4DAD for ; Wed, 27 May 2020 06:45:10 +0000 (UTC) X-FDA: 76861561980.06.hate84_220fa4926d50 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 95C0A10052FA3 for ; Wed, 27 May 2020 06:45:10 +0000 (UTC) X-HE-Tag: hate84_220fa4926d50 X-Filterd-Recvd-Size: 4288 Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 May 2020 06:45:09 +0000 (UTC) Received: by mail-qt1-f193.google.com with SMTP id i68so18382991qtb.5 for ; Tue, 26 May 2020 23:45:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OaLeQoi5DBWLuEVOcYdoFWBz25hF1g/z6p4tBOV7AU0=; b=txx+avA263khYurC1QtUhLXRBgqWxtEsC1Dl81kRn4bWuq926OBSAmSb5cNaAYjTxR jlZm9b8NmKNM2kzmWMHuLcRtaQe1ZbIRkj1I49s7KkjcCMBu/oiKDKKh9tjjjGX6Ir2q VAej7lXbr4I+fH0+fbauGpE3L/8gmXeTFF0JlNqKX1mYdiuR7m54pRKL4APul6PAwz9g Lib5qdMjdd04BGynjCkS+YvFpwFilbSYpydi2J5rohuQas1j1GX5ULZriJcJtV8qEbhS AQOlpf883Jmx4LbNx4DqZtj9nQewCxUzuG+e/B5y92DbXSFoWtXn27m05qFZzZ7Dm6mZ rI7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OaLeQoi5DBWLuEVOcYdoFWBz25hF1g/z6p4tBOV7AU0=; b=e9dWcW6yd0pdj7Uj/CuLxNdHKKz2gLzXBnfBnyUUVn6A8Ki0tsgDUZ2e1tEsU4vROo 0SmdSRBx2f8UuNCdBWKCki/ZGY/nXxbRj5ZZJDd0JFgzwVunoCx5M+GBmqSyken2yAyX YswC+LrxTKPNs78RafFhca4R8fAejxeYfnGxtMXD2qdihdAiTQfYXt54DAQJwdMhzips HVapIeK4OFuWL+W918MGf0Dgn/50AoNA7syATZxHeduosq0wTF3LJIvQYpywmPmYVrVC qpvy0vzhcKi1ciql77mb1/Z9K/k0Y/ASq5+N1DnQCfeYVtJX1tsABI+/LwAcWJnjyakN Y2fA== X-Gm-Message-State: AOAM530Ch2CyC8FKMSi28gtRyS4T7uMDBAOi9+e51T30ShtmTXhe3CEK 5RwFrS6sP51n0XRMKdPcigp+DdQQt+U/XkSA9Mc= X-Google-Smtp-Source: ABdhPJxcAOsdSaDgBBTBw58LUgy2dj68oIaoi7NEt2lX2itCWXLiWCPX24n98PFA7U1Llghnkkqf5DWAZrYXo5iY2UM= X-Received: by 2002:aed:39a2:: with SMTP id m31mr2493881qte.333.1590561909048; Tue, 26 May 2020 23:45:09 -0700 (PDT) MIME-Version: 1.0 References: <1589764857-6800-1-git-send-email-iamjoonsoo.kim@lge.com> <1589764857-6800-2-git-send-email-iamjoonsoo.kim@lge.com> <20200521003716.GA317575@carbon.dhcp.thefacebook.com> In-Reply-To: From: Joonsoo Kim Date: Wed, 27 May 2020 15:45:03 +0900 Message-ID: Subject: Re: [PATCH 01/11] mm/page_isolation: prefer the node of the source page To: Roman Gushchin Cc: Andrew Morton , Linux Memory Management List , LKML , kernel-team@lge.com, Vlastimil Babka , Christoph Hellwig , Mike Kravetz , Naoya Horiguchi , Michal Hocko , Joonsoo Kim Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 95C0A10052FA3 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > > mm/page_isolation.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > > > index 2c11a38..7df89bd 100644 > > > --- a/mm/page_isolation.c > > > +++ b/mm/page_isolation.c > > > @@ -300,5 +300,7 @@ int test_pages_isolated(unsigned long start_pfn, unsigned long end_pfn, > > > > > > struct page *alloc_migrate_target(struct page *page, unsigned long private) > > > { > > > - return new_page_nodemask(page, numa_node_id(), &node_states[N_MEMORY]); > > > + int nid = page_to_nid(page); > > > + > > > + return new_page_nodemask(page, nid, &node_states[N_MEMORY]); > > > > Why not new_page_nodemask(page, page_to_nid(page), &node_states[N_MEMORY]) ? > > Still fits into 80 characters. > > It's just my preference not directly using function call in argument > as much as possible. > If you don't like it, I will change it as you suggested. However, > since alloc_migrate_target() > will be removed in following patch, there will be no difference in the end. Oops... I found that your suggestion exceed 80 character. I will leave the patch as it is. Thanks.