From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx147.postini.com [74.125.245.147]) by kanga.kvack.org (Postfix) with SMTP id 0FE106B005A for ; Thu, 6 Sep 2012 15:27:57 -0400 (EDT) Received: by obhx4 with SMTP id x4so3956897obh.14 for ; Thu, 06 Sep 2012 12:27:56 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1346885323-15689-1-git-send-email-elezegarcia@gmail.com> <1346885323-15689-3-git-send-email-elezegarcia@gmail.com> Date: Fri, 7 Sep 2012 04:27:56 +0900 Message-ID: Subject: Re: [PATCH 3/5] mm, util: Do strndup_user allocation directly, instead of through memdup_user From: JoonSoo Kim Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Ezequiel Garcia Cc: David Rientjes , linux-mm@kvack.org, Pekka Enberg , Christoph Lameter 2012/9/6 Ezequiel Garcia : > Hi David, > > On Wed, Sep 5, 2012 at 9:59 PM, David Rientjes wrote: >> On Wed, 5 Sep 2012, Ezequiel Garcia wrote: >> >>> I'm not sure this is the best solution, >>> but creating another function to reuse between strndup_user >>> and memdup_user seemed like an overkill. >>> >> >> It's not, so you'd need to do two things to fix this: >> >> - provide a reason why strndup_user() is special compared to other >> common library functions that also allocate memory, and >> > > Sorry, I don't understand what you mean. > strndup_user is *not* special than any other function, simply if you use > memdup_user for the allocation you will get traces with strndup_user > as the caller, > and that's not desirable. I'm not sure that this changed should be needed. But, if you want to fix this properly, why don't change __krealloc() ? It is called by krealloc(), and may return krealloc()'s address. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org