From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69EF6C433DF for ; Wed, 17 Jun 2020 05:08:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 045A620720 for ; Wed, 17 Jun 2020 05:08:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M7+46Mbq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 045A620720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 43A666B0002; Wed, 17 Jun 2020 01:08:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EAA26B0003; Wed, 17 Jun 2020 01:08:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 300016B0005; Wed, 17 Jun 2020 01:08:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0244.hostedemail.com [216.40.44.244]) by kanga.kvack.org (Postfix) with ESMTP id 18ED46B0002 for ; Wed, 17 Jun 2020 01:08:58 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C6AEC1EE6 for ; Wed, 17 Jun 2020 05:08:57 +0000 (UTC) X-FDA: 76937524314.09.wall44_4a0536f26e05 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 9F266180AD804 for ; Wed, 17 Jun 2020 05:08:57 +0000 (UTC) X-HE-Tag: wall44_4a0536f26e05 X-Filterd-Recvd-Size: 4842 Received: from mail-qv1-f67.google.com (mail-qv1-f67.google.com [209.85.219.67]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Wed, 17 Jun 2020 05:08:57 +0000 (UTC) Received: by mail-qv1-f67.google.com with SMTP id r16so450703qvm.6 for ; Tue, 16 Jun 2020 22:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=eSxlgyWtSoXSmG1hmoYzEM444NpFB+T4fXxIpsIpthk=; b=M7+46Mbq0O0SaclOTpKcRrjHwmidJX6jYuBGOcEZ74jIc/ta25h4mCJTNKo4bq+83q 7Uf886njOoRqxWR8QDZ7/RsRA5Sugeo26726COXuet5ealArLVgpNAm7WzKWvnkh7F1+ Jw3mYYda8xVnPjMlyXz7F265CnwLEXNnmmS2yFdk8jlUxSipLaxR2UNlpiT1HHST/Czj QSitAsKXFmaKnXzUHNsFAZbaKlGpWROPZnVrleXd4ToGLrxLx3T/hNICu+ms2dOXC6Ou 8DrfE25X06wx/PoqcbLlyhSZSJRF5gJSApRzvsVNAvoz2+qX/vNn52K5xsuuaSGiOkJ0 6LDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=eSxlgyWtSoXSmG1hmoYzEM444NpFB+T4fXxIpsIpthk=; b=D6A5OeaRi1lUgy4rYRBDusAIXlmeLPTd8MazJlQXf4495JiRQ5izy60mOB4dd661hx DFr6mNYGhnn3zx0ZBs8BbYF5DJRbnjoD3i4AGVId523ZHokOZoewzzyXfFf19NnzGr2w G5K/Z5qsSM6Qq/aSE50ImkrExCmgiiARgwp2PvEXt5dw5QmeCZxf6FI70fEq2qy1IeET G3hMq8LMA1EckYZ9BnJHHZ+gitQlKTEqgh/6Rzfeq0KudlRweBmsIKcWaGcHRZDEiVFm rvZ3m/+UQzOkxsQIBn8DfkE1b3pziJdCnxB/cuP7Qa+dqqoAVdrY5Y9jEBQBO4aacUTQ 5cxA== X-Gm-Message-State: AOAM532PZFaPqRSHLp08CsTyIZrANd03zUOBiLn2NJKqTrA2Kv+HQIop h1rrXCc40pH5iUWuU8PqoQYW3v3QMEQnVeKCqB0= X-Google-Smtp-Source: ABdhPJz7N8RtOL+jmqif9kGxaS4c46DrOpN8lqkzazFSK/+moVt8Qzr4sDusq4/Vi8wkxzE0zK4f3ge4DurCHG3LqFA= X-Received: by 2002:ad4:4d04:: with SMTP id l4mr5937206qvl.88.1592370536428; Tue, 16 Jun 2020 22:08:56 -0700 (PDT) MIME-Version: 1.0 References: <1592288204-27734-1-git-send-email-iamjoonsoo.kim@lge.com> <1592288204-27734-3-git-send-email-iamjoonsoo.kim@lge.com> <20200616113601.a8ab80635b6434efe43d2ffc@linux-foundation.org> In-Reply-To: <20200616113601.a8ab80635b6434efe43d2ffc@linux-foundation.org> From: Joonsoo Kim Date: Wed, 17 Jun 2020 14:08:45 +0900 Message-ID: Subject: Re: [PATCH for v5.8 2/3] mm/swap: fix for "mm: workingset: age nonresident information alongside anonymous pages" To: Andrew Morton Cc: Linux Memory Management List , LKML , Johannes Weiner , Rik van Riel , Minchan Kim , Michal Hocko , kernel-team@lge.com, Joonsoo Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 9F266180AD804 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2020=EB=85=84 6=EC=9B=94 17=EC=9D=BC (=EC=88=98) =EC=98=A4=EC=A0=84 3:36, A= ndrew Morton =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84= =B1: > > On Tue, 16 Jun 2020 15:16:43 +0900 js1304@gmail.com wrote: > > > Subject: [PATCH for v5.8 2/3] mm/swap: fix for "mm: workingset: age non= resident information alongside anonymous pages" > > I'm having trouble locating such a patch. > > > Non-file-lru page could also be activated in mark_page_accessed() > > and we need to count this activation for nonresident_age. > > > > Note that it's better for this patch to be squashed into the patch > > "mm: workingset: age nonresident information alongside anonymous pages"= . > > > > Signed-off-by: Joonsoo Kim > > --- > > mm/swap.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/mm/swap.c b/mm/swap.c > > index 667133d..c5d5114 100644 > > --- a/mm/swap.c > > +++ b/mm/swap.c > > @@ -443,8 +443,7 @@ void mark_page_accessed(struct page *page) > > else > > __lru_cache_activate_page(page); > > ClearPageReferenced(page); > > - if (page_is_file_lru(page)) > > - workingset_activation(page); > > + workingset_activation(page); > > } > > if (page_is_idle(page)) > > clear_page_idle(page); > > AFAICT this patch Fixes: a528910e12ec7ee ("mm: thrash detection-based fil= e > cache sizing")? No, This patch could be squashed into the previous patch, "mm: workingset: age nonresident information alongside anonymous pages", in this patchset. I intentionally do not unify them by my hand since review is required. Thanks.