From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38FF4C433DF for ; Thu, 21 May 2020 01:18:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E0A1C20748 for ; Thu, 21 May 2020 01:18:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O9a+aLg6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0A1C20748 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6BECD80008; Wed, 20 May 2020 21:18:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6966880007; Wed, 20 May 2020 21:18:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5855180008; Wed, 20 May 2020 21:18:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0165.hostedemail.com [216.40.44.165]) by kanga.kvack.org (Postfix) with ESMTP id 3F9B880007 for ; Wed, 20 May 2020 21:18:55 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 031A149960F for ; Thu, 21 May 2020 01:18:55 +0000 (UTC) X-FDA: 76838967030.13.leaf88_8805e97bec822 X-HE-Tag: leaf88_8805e97bec822 X-Filterd-Recvd-Size: 4704 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 May 2020 01:18:54 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id m11so5758225qka.4 for ; Wed, 20 May 2020 18:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+3OSvgXp7d7mMIPIrDIx/ulZwnpTuAbryXHJMArWUuQ=; b=O9a+aLg6MZdkXFs1LsULVLnKRF5oQ7OJXY5Sr0xaIN+SB9yOAbz5p04DDYltlb+9Xc DM3CgKMQVBluzSQ8dfonEJ8dHgYP422uFe+uJrcIZQXVHkIFg9D4VuS1gy75u4FSRqaG X+TzGieXKYui5LqRkAPf5s4FQyvX1PqNQIoqhP4Pm6cbZP+6N8laTS8E86BYr05tmU07 gu/PITan9RsnwIYMrUUEeeN19HdB9mzr1PqwXJNsdYuBaxsMr1mHJ4gvsi0/XSMH1qFv jwyKDbTLKSvzmkqxguIgJJOAlQ5I4qazA/Pv5y9ZGwKL9mEhnB5X8m2irbMYSZn21Cpr xf0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+3OSvgXp7d7mMIPIrDIx/ulZwnpTuAbryXHJMArWUuQ=; b=mWuTyJqw52RNjQ2lKgghn2puUuwtzaqTC/lKA7e365Wql7EtNUXGDFvCvem8CEupzb 6NbrJq6pDKpzjKSVI9frHA0fblN2f88/pFH8P48EsKMxScSu8sjiWbPnjTjHYfzwBw5l 6VU3kAotEtTfcFBorkCiVdQuaBkhnfy14S1ONDi/MPXBi9M6uD6C2xC81yUl6q/YVzmV EVOpwaNXS3ahYjRRjgl8s0ginO8qJcIUYH/IDZUStC+fU5bJ/OtpGKa57Lo38QpmaZzS /uJS8pwRqOJ/RcHR3XNvk8b9AoQoopseEVkGr86cNKhLMMnSHn/DSb/ar1PRhoxGeVcE 7XBA== X-Gm-Message-State: AOAM5308wNfJnQsTcCox6G9tgrbg3Jhk5MQrb+1AJxDABUXdIkJb5HrQ ewf7vUmLF9o/KBppM0yIFUzAVfDERDdRJgc2iL4= X-Google-Smtp-Source: ABdhPJxLkEGz9zfJhSCYb7AbUJ1yc+ysNJnfCiDfARS6DDS7rkatp9xk4ZX7CVbYQ8bOB7pUuRykc/JiZUuDYPyUs7U= X-Received: by 2002:a37:6cc2:: with SMTP id h185mr5096040qkc.272.1590023933988; Wed, 20 May 2020 18:18:53 -0700 (PDT) MIME-Version: 1.0 References: <1589764857-6800-1-git-send-email-iamjoonsoo.kim@lge.com> <1589764857-6800-2-git-send-email-iamjoonsoo.kim@lge.com> <20200521003716.GA317575@carbon.dhcp.thefacebook.com> In-Reply-To: <20200521003716.GA317575@carbon.dhcp.thefacebook.com> From: Joonsoo Kim Date: Thu, 21 May 2020 10:18:40 +0900 Message-ID: Subject: Re: [PATCH 01/11] mm/page_isolation: prefer the node of the source page To: Roman Gushchin Cc: Andrew Morton , Linux Memory Management List , LKML , kernel-team@lge.com, Vlastimil Babka , Christoph Hellwig , Mike Kravetz , Naoya Horiguchi , Michal Hocko , Joonsoo Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2020=EB=85=84 5=EC=9B=94 21=EC=9D=BC (=EB=AA=A9) =EC=98=A4=EC=A0=84 9:37, R= oman Gushchin =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > On Mon, May 18, 2020 at 10:20:47AM +0900, js1304@gmail.com wrote: > > From: Joonsoo Kim > > > > For locality, it's better to migrate the page to the same node > > rather than the node of the current caller's cpu. > > > > Signed-off-by: Joonsoo Kim > > Acked-by: Roman Gushchin Thanks for review! > > --- > > mm/page_isolation.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > > index 2c11a38..7df89bd 100644 > > --- a/mm/page_isolation.c > > +++ b/mm/page_isolation.c > > @@ -300,5 +300,7 @@ int test_pages_isolated(unsigned long start_pfn, un= signed long end_pfn, > > > > struct page *alloc_migrate_target(struct page *page, unsigned long pri= vate) > > { > > - return new_page_nodemask(page, numa_node_id(), &node_states[N_MEM= ORY]); > > + int nid =3D page_to_nid(page); > > + > > + return new_page_nodemask(page, nid, &node_states[N_MEMORY]); > > Why not new_page_nodemask(page, page_to_nid(page), &node_states[N_MEMORY]= ) ? > Still fits into 80 characters. It's just my preference not directly using function call in argument as much as possible. If you don't like it, I will change it as you suggested. However, since alloc_migrate_target() will be removed in following patch, there will be no difference in the end. Thanks.