From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f199.google.com (mail-wr0-f199.google.com [209.85.128.199]) by kanga.kvack.org (Postfix) with ESMTP id 91B0C6B0006 for ; Tue, 22 May 2018 20:09:06 -0400 (EDT) Received: by mail-wr0-f199.google.com with SMTP id p7-v6so15903180wrj.4 for ; Tue, 22 May 2018 17:09:06 -0700 (PDT) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id n93-v6sor8886200wrb.51.2018.05.22.17.09.04 for (Google Transport Security); Tue, 22 May 2018 17:09:05 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180522170257.ae5387d8717e81def908a53b@linux-foundation.org> References: <20180517125959.8095-1-ville.syrjala@linux.intel.com> <20180517132109.GU12670@dhcp22.suse.cz> <20180517133629.GH23723@intel.com> <20180517135832.GI23723@intel.com> <20180517164947.GV12670@dhcp22.suse.cz> <20180517170816.GW12670@dhcp22.suse.cz> <20180518040104.GA17433@js1304-desktop> <20180519144632.GE23723@intel.com> <20180521061631.GA26882@js1304-desktop> <20180522170257.ae5387d8717e81def908a53b@linux-foundation.org> From: Joonsoo Kim Date: Wed, 23 May 2018 09:09:04 +0900 Message-ID: Subject: Re: [PATCH] Revert "mm/cma: manage the memory of the CMA area by using the ZONE_MOVABLE" Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Laura Abbott , Michal Hocko , "Aneesh Kumar K . V" , Tony Lindgren , Vlastimil Babka , Johannes Weiner , Laura Abbott , Marek Szyprowski , Mel Gorman , Michal Nazarewicz , Minchan Kim , Rik van Riel , Russell King , Will Deacon , Linus Torvalds , Linux Memory Management List , LKML 2018-05-23 9:02 GMT+09:00 Andrew Morton : > On Mon, 21 May 2018 15:16:33 +0900 Joonsoo Kim wrote: > >> > (gdb) list *(dma_direct_alloc+0x22f) >> > 0x573fbf is in dma_direct_alloc (../lib/dma-direct.c:104). >> > 94 >> > 95 if (!page) >> > 96 return NULL; >> > 97 ret = page_address(page); >> > 98 if (force_dma_unencrypted()) { >> > 99 set_memory_decrypted((unsigned long)ret, 1 << page_order); >> > 100 *dma_handle = __phys_to_dma(dev, page_to_phys(page)); >> > 101 } else { >> > 102 *dma_handle = phys_to_dma(dev, page_to_phys(page)); >> > 103 } >> > 104 memset(ret, 0, size); >> > 105 return ret; >> > 106 } >> > >> >> Okay. I find the reason about this error. > > It's getting rather late and we don't seem to have a final set of fixes > yet. Perhaps the best approach here is to revert and try again for > 4.18? Yes. Reverting seems to be a right decision at this moment. Could you apply original revert patch from Ville? Thanks.