From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E22D0C433E0 for ; Mon, 15 Jun 2020 06:15:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A0CE2206DB for ; Mon, 15 Jun 2020 06:15:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YhYAievL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0CE2206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 303206B0002; Mon, 15 Jun 2020 02:15:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B30D6B0003; Mon, 15 Jun 2020 02:15:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A27F6B0005; Mon, 15 Jun 2020 02:15:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0041.hostedemail.com [216.40.44.41]) by kanga.kvack.org (Postfix) with ESMTP id F309F6B0002 for ; Mon, 15 Jun 2020 02:15:40 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 91DF6181AC9BF for ; Mon, 15 Jun 2020 06:15:40 +0000 (UTC) X-FDA: 76930434840.06.fear22_560d36826df4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 6056B1003FC32 for ; Mon, 15 Jun 2020 06:15:40 +0000 (UTC) X-HE-Tag: fear22_560d36826df4 X-Filterd-Recvd-Size: 3507 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Mon, 15 Jun 2020 06:15:39 +0000 (UTC) Received: by mail-qk1-f169.google.com with SMTP id l17so14703060qki.9 for ; Sun, 14 Jun 2020 23:15:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Pq8wSoIwYToPYyYMgXetLZRme7ou0tgoOwDcqdnlKHE=; b=YhYAievLTb+s1aYwoEae3p1JzZ8ET8WqfcyarhCMhIGjmFW2VuSv56qtK0iTXYAOJK FxW7ggnTNvKInUW/vfv9UtPmG7tFHvy2paKRofuftyaDFLjAyrCMSJ3Occs4TzSmNiL1 +PLfC8COBKhE03g2EZeGMzANYHNxIgo4U3/pYEDsusGE3TZzIb9S+/N/euRHah/dUSoD NkXs3wEDD/qErfLaT1UUhe6OyD/uUVWe6U0GBAunp9czEivTVXw0CTOxd/JDr1k5fQyC 1OQUVn+/VpGR8XOY4P6eiKzicVZ2zF5UM7xL/lHifQegmlu0ThYcdOsWYeqsjxQk3GJU UPXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Pq8wSoIwYToPYyYMgXetLZRme7ou0tgoOwDcqdnlKHE=; b=FNwgEq+OfwvPmFDgp9g8j9rZZ+F4DP/+b/BTTwQZoWpemS3fxjkojy19qRY5GCKE9W ZyDn+jEQP3aNORdmugiBGa0g6SSVRstmIF+oldN7E+JLZBRer6eocJgka1D8HIuTT3+9 jhW8G0KpKANcb62HDQ0IN0/Aa8I6Swww79nVuG8YPLvMxCEjuqJHDr2DcszBB8vm9b3S 0+TSc8QsNOeSoZcXc6Ji28fMvJ8Z00Kf5SflTKZ4ssianQdEg4ZL8d8uJxPrGRo3Vm27 5wXCY4OpnpsWX8OqkR9O67Y58X3XbO3dT+NJVG5YYlQKYysREer/cbz5ZknH2YtQv8aA d+Jw== X-Gm-Message-State: AOAM530XpNS22VrGjpZZcJrEJYJ5azb3Al1Ir3DHqQ7UZlX96HjEEAhQ UvvW1ZJhyQO4HGAj20WS3DoieaocUHYi/9zR8qc= X-Google-Smtp-Source: ABdhPJwE9J+eJGLQhM9cvcRVG6bRyMsop11pz6QRuQPdJvXk05CFa//kxOLWGMIJPV9VNYj91tLpzDE60uTUbAk0KG0= X-Received: by 2002:a05:620a:a4a:: with SMTP id j10mr13337550qka.272.1592201739302; Sun, 14 Jun 2020 23:15:39 -0700 (PDT) MIME-Version: 1.0 References: <20200614123923.99189-1-songmuchun@bytedance.com> <20200614123923.99189-3-songmuchun@bytedance.com> In-Reply-To: <20200614123923.99189-3-songmuchun@bytedance.com> From: Joonsoo Kim Date: Mon, 15 Jun 2020 15:15:28 +0900 Message-ID: Subject: Re: [PATCH 2/3] mm/slub: Use node_nr_slabs() instead of slabs_node() To: Muchun Song Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 6056B1003FC32 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000021, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2020=EB=85=84 6=EC=9B=94 14=EC=9D=BC (=EC=9D=BC) =EC=98=A4=ED=9B=84 9:39, M= uchun Song =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > In the some code, we already get the kmem_cache_node, so we can > use node_nr_slabs() directly instead of slabs_node(). Check the > condition of n->nr_partial can also be removed because we can get > the correct result via node_nr_slabs(). > > Signed-off-by: Muchun Song If appying this patch, there is no reference to slabs_node(). Please remove= it. Thanks.