From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx197.postini.com [74.125.245.197]) by kanga.kvack.org (Postfix) with SMTP id 6D9C76B0078 for ; Wed, 31 Oct 2012 13:11:43 -0400 (EDT) Received: by mail-oa0-f41.google.com with SMTP id k14so2062943oag.14 for ; Wed, 31 Oct 2012 10:11:42 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1351451576-2611-1-git-send-email-js1304@gmail.com> <20121029021219.GK15767@bbox> Date: Thu, 1 Nov 2012 02:11:42 +0900 Message-ID: Subject: Re: [PATCH 0/5] minor clean-up and optimize highmem related code From: JoonSoo Kim Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Peter Zijlstra Hello, Andrew. 2012/10/29 JoonSoo Kim : > Hi, Minchan. > > 2012/10/29 Minchan Kim : >> Hi Joonsoo, >> >> On Mon, Oct 29, 2012 at 04:12:51AM +0900, Joonsoo Kim wrote: >>> This patchset clean-up and optimize highmem related code. >>> >>> [1] is just clean-up and doesn't introduce any functional change. >>> [2-3] are for clean-up and optimization. >>> These eliminate an useless lock opearation and list management. >>> [4-5] is for optimization related to flush_all_zero_pkmaps(). >>> >>> Joonsoo Kim (5): >>> mm, highmem: use PKMAP_NR() to calculate an index of pkmap >>> mm, highmem: remove useless pool_lock >>> mm, highmem: remove page_address_pool list >>> mm, highmem: makes flush_all_zero_pkmaps() return index of last >>> flushed entry >>> mm, highmem: get virtual address of the page using PKMAP_ADDR() >> >> This patchset looks awesome to me. >> If you have a plan to respin, please CCed Peter. > > Thanks for review. > I will wait more review and respin, the day after tomorrow. > Version 2 will include fix about your comment. Could you pick up second version of this patchset? [3] is changed to leave one blank line. [4] is changed in order to further optimize according to Minchan's comment. It return first index of flushed entry, instead of last index. Others doesn't changed. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org