From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx202.postini.com [74.125.245.202]) by kanga.kvack.org (Postfix) with SMTP id 613F96B0075 for ; Fri, 6 Jul 2012 12:58:25 -0400 (EDT) Received: by obhx4 with SMTP id x4so13551648obh.14 for ; Fri, 06 Jul 2012 09:58:24 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20120706155920.GA7721@barrios> References: <1341588521-17744-1-git-send-email-js1304@gmail.com> <20120706155920.GA7721@barrios> Date: Sat, 7 Jul 2012 01:58:24 +0900 Message-ID: Subject: Re: [PATCH] mm: don't invoke __alloc_pages_direct_compact when order 0 From: JoonSoo Kim Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: akpm@linux-foundation.org, Pekka Enberg , Christoph Lameter , linux-kernel@vger.kernel.org, linux-mm@kvack.org 2012/7/7 Minchan Kim : > Hi Joonsoo, > > On Sat, Jul 07, 2012 at 12:28:41AM +0900, Joonsoo Kim wrote: >> __alloc_pages_direct_compact has many arguments so invoking it is very costly. > > It's already slow path so it's pointless for such optimization. I know this is so minor optimization. But why don't we do such a one? Is there any weak point? >> And in almost invoking case, order is 0, so return immediately. > > You can't make sure it. Okay. >> >> Let's not invoke it when order 0 > > Let's not ruin git blame. Hmm... When I do git blame, I can't find anything related to this. Thanks for comments. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org