From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C4B3C2BA1A for ; Tue, 7 Apr 2020 00:40:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4BC9D20692 for ; Tue, 7 Apr 2020 00:40:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vNKOZDHk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BC9D20692 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E47E98E0006; Mon, 6 Apr 2020 20:40:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF8538E0001; Mon, 6 Apr 2020 20:40:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D35F88E0006; Mon, 6 Apr 2020 20:40:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0182.hostedemail.com [216.40.44.182]) by kanga.kvack.org (Postfix) with ESMTP id BBAB38E0001 for ; Mon, 6 Apr 2020 20:40:55 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 72F18180AD806 for ; Tue, 7 Apr 2020 00:40:55 +0000 (UTC) X-FDA: 76679204070.12.mint91_805ffe13a64c X-HE-Tag: mint91_805ffe13a64c X-Filterd-Recvd-Size: 5189 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Apr 2020 00:40:54 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id v7so44988qkc.0 for ; Mon, 06 Apr 2020 17:40:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=3LF/o4UOLHZ7u5AeS29ADFIWE/RbgKztcg6yxkuc2qQ=; b=vNKOZDHkVJsbIEl7B7c09QFBaVWbhOwlnie7l8bQaV7AYsc9mGKPyWD/eASJY9Vo4X sK+TIV22dunx7p11iPc1/gUFM3n632Nb5QGtVSA6r+s0pRCjvuCJTp/Pw4URio2TACHk cBPNCV0W206g4WLSdowuC4Zqnnjil4NH2lwpyYrFHaSwp9PiZ7TzpFrxgFrKgQ0bwRh3 rC4vY+aRHIGemp3dKSWPWJtPpeEQs0Yb0U+ArAknFJ36qVwHIC+y0SW+dCaRTBR5kQWX a4jae8RXk6OejxqWk8TdsZObJ7GU98u+I7xlS+ygtKwi9MlGxW5nC4gPC+u9Hk+MMOck XJNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=3LF/o4UOLHZ7u5AeS29ADFIWE/RbgKztcg6yxkuc2qQ=; b=fNwNUHP2Sbi5q6Ya7/DFIiM7FkeM6+QtxJDozfHHO1tkVQ0DYJfjy3J0jOm5SmkHCh 4Exsj2jUVbu5aneBTy9CvAhXNj01o7H9BraP/vXKzIoAYac7405PGlIAd7VhGpGDNL9n S65cu3upKfM3l04PsWDfuDlLpQZdFHtwBCuXrcEeJwOOhUq8I1sJl6vRCH9IVDRmRiU9 9vFBauf5s8fqbxd5XMgma6SA1ZAyc3b68izoWwuNN/Ju/07e1Le/mzIz8JgrmV0wMpg3 vmlrGjyFqE7LQBeDThUWUKIwvBQx4EAYSx9zIldzGLEGLvjAanmiqCgH8izSc4WoYkc+ i9Ww== X-Gm-Message-State: AGi0PuZZxduuzldggjOe+O4tOz7ukT+4WToBl9eV03sWpfEo+YBhOkCs jkDcsuOiDV56dpeuxwDType62xIBRO9LE5rngD4= X-Google-Smtp-Source: APiQypJFrTcD8M7cUC55n3DG+zlL6SuC0I0p5zWmGQ68W8FY6zH5fvJsjpMf8bVNRdIshpZimFwOSYplzRb7pfniCZw= X-Received: by 2002:a37:af86:: with SMTP id y128mr24790013qke.429.1586220054400; Mon, 06 Apr 2020 17:40:54 -0700 (PDT) MIME-Version: 1.0 References: <1585892447-32059-1-git-send-email-iamjoonsoo.kim@lge.com> <20200406091814.17256-1-hdanton@sina.com> In-Reply-To: <20200406091814.17256-1-hdanton@sina.com> From: Joonsoo Kim Date: Tue, 7 Apr 2020 09:40:43 +0900 Message-ID: Subject: Re: [PATCH v5 02/10] mm/vmscan: protect the workingset on anonymous LRU To: Hillf Danton Cc: Andrew Morton , Linux Memory Management List , LKML , Johannes Weiner , Michal Hocko , Hugh Dickins , Minchan Kim , Vlastimil Babka , Mel Gorman , kernel-team@lge.com, Joonsoo Kim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.008841, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 2020=EB=85=84 4=EC=9B=94 6=EC=9D=BC (=EC=9B=94) =EC=98=A4=ED=9B=84 6:18, Hi= llf Danton =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > > > On Fri, 3 Apr 2020 14:40:40 +0900 Joonsoo Kim wrote: > > > > @@ -3093,11 +3093,10 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) > > if (unlikely(page !=3D swapcache && swapcache)) { > > page_add_new_anon_rmap(page, vma, vmf->address, false); > > mem_cgroup_commit_charge(page, memcg, false, false); > > - lru_cache_add_active_or_unevictable(page, vma); > > + lru_cache_add_inactive_or_unevictable(page, vma); > > } else { > > do_page_add_anon_rmap(page, vma, vmf->address, exclusive)= ; > > mem_cgroup_commit_charge(page, memcg, true, false); > > - activate_page(page); > > } > > > > swap_free(entry); > ... > > @@ -996,8 +996,6 @@ static enum page_references page_check_references(s= truct page *page, > > return PAGEREF_RECLAIM; > > > > if (referenced_ptes) { > > - if (PageSwapBacked(page)) > > - return PAGEREF_ACTIVATE; > > /* > > * All mapped pages start out with page table > > * references from the instantiating fault, so we need > > @@ -1020,7 +1018,7 @@ static enum page_references page_check_references= (struct page *page, > > /* > > * Activate file-backed executable pages after first usag= e. > > */ > > - if (vm_flags & VM_EXEC) > > + if ((vm_flags & VM_EXEC) && !PageSwapBacked(page)) > > return PAGEREF_ACTIVATE; > > > > return PAGEREF_KEEP; > > -- > > 2.7.4 > > Both changes other than > s/lru_cache_add_active_or_unevictable/lru_cache_add_inactive_or_unevictab= le/ > are likely worth their own seperate commits with a concise log. IMO, all of the changes in this patch provides just one logical change for LRU management on anonymous page so it's better to be together. Thanks.